feat: make it possible to choose image name #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -291,7 +291,7 @@ impl ManifestBuilder { | |||
|
|
|||
| pub fn get_image(mut self) -> Result<Self> { | |||
| self.manifest.service.image = | |||
| get_image_name(&self.api_client, &self.token, &self.org_name, &None)?; | |||
| get_image_name(&self.api_client, &self.token, &self.org_name, &None, &None)?; | |||
There was a problem hiding this comment.
We should probably rename get_image and get_image_name. It returns name, but also has a parameter called name.
There was a problem hiding this comment.
the manifest already has a get_image function so I think it would have conflicts
| @@ -43,7 +43,6 @@ impl Token { | |||
| } | |||
|
|
|||
| pub struct UserConfigLoader { | |||
| pub path: Utf8PathBuf, | |||
There was a problem hiding this comment.
This wasn't used before?
bittermandel
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the
svcs image-namecommand to be able to specify a custom image name instead of using the folder name