Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multi-action transaction support with retries #8

Merged
merged 5 commits into from
Oct 11, 2024
Merged

feat: multi-action transaction support with retries #8

merged 5 commits into from
Oct 11, 2024

Conversation

bittermandel
Copy link
Contributor

No description provided.

mikn
mikn reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@mikn mikn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments may well be because I do not understand Rust, so educate me if I am wrong ❤️

crates/valv/src/lib.rs Outdated Show resolved Hide resolved
crates/valv/src/lib.rs Outdated Show resolved Hide resolved
crates/valv/src/lib.rs Outdated Show resolved Hide resolved
crates/valv/src/storage/fdb.rs Show resolved Hide resolved
crates/valv/src/storage/fdb.rs Show resolved Hide resolved
crates/valv/src/lib.rs Outdated Show resolved Hide resolved
crates/valv/src/lib.rs Outdated Show resolved Hide resolved
mikn
mikn reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@mikn mikn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks a lot better 👍

crates/valv/src/lib.rs Outdated Show resolved Hide resolved
crates/valv/src/lib.rs Show resolved Hide resolved
crates/valv/src/lib.rs Show resolved Hide resolved
crates/valv/src/lib.rs Outdated Show resolved Hide resolved
@mikn
Copy link
Member

mikn commented Oct 11, 2024

I'm sorry, but this is hilarious :D

@bittermandel
Copy link
Contributor Author

I'm sorry, but this is hilarious :D

:D what did I do

@bittermandel
Copy link
Contributor Author

I'm sorry, but this is hilarious :D

OMG I've been developing without format on save for WEEKS

@bittermandel bittermandel merged commit 9285b94 into main Oct 11, 2024
2 checks passed
@bittermandel bittermandel deleted the feat/transaction-support branch October 11, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikn mikn mikn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bittermandel @mikn