remove compiling warning #1623
remove compiling warning #1623
Conversation
…n-20240228 update to main 20240228 commit
This patch clears out many errors detected by Intel Fortran. Most are false positives from stub functions which would normally be replaced in production and report unset output. These variables are now assigned dummy values in order to pacify the compiler. The `stat` function in POSIX was incorrectly passing its `buf` object to the C `stat` function as `intent(in)`, causing the compiler to believe that the contents were unset. Oddly, this was already working correctly, and perhaps warrants further investigation, but it has now been correctly set to `intent(inout)`. The `ppoly_*` variables in `check_reconstruction_1d` appear to have been incorrectly declared as `out`, when they are clearly used as `in` to validate the values. This has been corrected. `register_diag_field` in the ice shelf diag manager was incorrectly declared and the function appeared to return nothing. Perhaps this function was not used for anything. An IO statement in MOM_open_boundary had a syntax error; this has been fixed. `get_dataset` returns a `dataset_type`, so some compilers expect the stub function to also return a valid `dataset`. Since the stub `dataset_type` contains no fields, any locally declared instance should be sufficient as a return value.
Error cleanup (Intel Fortran)
…n-20240401 update to MOM6 main repo 20240401 commit
jiandewang
requested review from
marshallward,
alperaltuntas,
kshedstrom,
sanAkel and
abozec
|
The initializations to |
|
@klindsay28 Thanks for catching this. I agree: As for whether to let the compiler convert -1.0 (or even -1) to |
The default values for the database transfer functions were incorrectly assiged as integer literals, recast to types using real32/64 but actually corresponding to whatever integer kind equals real32/64. We now simply assign it a literal value of -1. and rely on the compiler to handle the recasting. Although none of these functions were intended to be used, and -1 would probably be eventually cast into an appropriate real type, it is better to get this correct. Thanks to Keith Lindsay for suggesting this change.
|
@jiandewang @klindsay28 I've submitted a PR to this branch which changes the |
Replace db array default values with real literals
just merged. Thanks |
|
somehow I closed this by mistake. Re-open it |
|
@alperaltuntas and @abozec can you review it ? |
|
@alperaltuntas can you review this PR ? (I guess it maybe bypassed your radar) |
|
NCAR approves this PR. |
|
thanks for everybody's reviewing. I am going to merge it |
This mini PR address the compiling warning removing request by NCEP Central Operational branch. Thanks for @marshallward's work.