Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Christmas background on 18th instead of 25th #109

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

tsa96
Copy link
Member

@tsa96 tsa96 commented Dec 7, 2023

Currently the background runs from 25th to 31st, feels a bit short. Figured starting a week earlier would be a bit better, 2 weeks feels reasonable.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@Gocnak Gocnak force-pushed the refactor/xmas-dates branch from 8038e67 to 4075721 Compare December 9, 2023 07:17
@Gocnak Gocnak enabled auto-merge (rebase) December 9, 2023 07:18
@Gocnak Gocnak merged commit 41d9500 into master Dec 9, 2023
1 check passed
@Gocnak Gocnak deleted the refactor/xmas-dates branch December 9, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants