Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate number of unmatched phenotypes per column #245

Open
jmcmurry opened this issue Apr 26, 2016 · 9 comments
Open

Indicate number of unmatched phenotypes per column #245

jmcmurry opened this issue Apr 26, 2016 · 9 comments

Comments

@jmcmurry
Copy link
Member

This is really more of an owlsim / scigraph issue but manifesting here.

It is not clear why we're seeing higher scores for diseases that have fewer phenotype matches. I expected this to be the result of slightly different scoring, or weighting by IC score, but this appears not to be the case?

screen shot 2016-04-26 at 2 50 28 pm

@kshefchek @jnguyenx ?

@jmcmurry jmcmurry added the bug label Apr 26, 2016
@jnguyenx
Copy link
Contributor

Scoring is done by the owlsim server. @cmungall must have answers for that.

@cmungall
Copy link
Member

we have an option to show unmatched phenotypes for the query, but not for the matches. If we did, you'd see the lower scoring ones would have many unmatched phenotypes

@jmcmurry
Copy link
Member Author

Ah right; of course. Perhaps then, phenogrid could at least have a number for each column showing how many unmatched phenotypes there are? That would help make more sense of reports like this.

@jmcmurry jmcmurry added enhancement and removed bug labels Apr 27, 2016
@jmcmurry jmcmurry changed the title Results of profile match score seem to contraindicate individual phenotype match scores Indicate number of unmatched phenotypes per column Apr 27, 2016
@mellybelly
Copy link

mellybelly commented Apr 27, 2016

I've always disliked the hidden unmatched terms. If we implement a hierarchical y axis there might be a way to render them differently rather than hiding them

@jmcmurry
Copy link
Member Author

On a related note, when we get to phenogrid from a disease page (compare tab) I can't figure out why it is that the top disease hit isn't either:

A) a different disease altogether
OR
B) the same disease as the query disease but scoring a 100% profile match

We have neither A nor B now: the top hit is always identical in name/ID to the disease that spawned the query; however the match scores can be well below 100; for example https://monarchinitiative.org/disease/OMIM%3A127750#compare has a match score of 79. What am I missing?

@cmungall
Copy link
Member

In this case, what is in owlsim doesn't match what is in solr. This is odd as the owlsim data is dumped directly from golr. It could be a data synchrony issue, or it could be something wrong with the golr-exporter script. @jnguyenx and @kltm can explore more tomorrow.

@cmungall
Copy link
Member

cmungall commented Apr 27, 2016

Checked on beta, same issue. But it also showed odd fly matches.

Following up, we should not be including inferred phenotypes like these
https://beta.monarchinitiative.org/gene/FlyBase:FBgn0040074

(this belongs in a separate ticket, just noting here for now)

EDIT: not a phenogrid issue, now tracked here: https://github.com/monarch-initiative/monarch-app/issues/1243

@jmcmurry jmcmurry reopened this Apr 27, 2016
@yuanzhou
Copy link
Collaborator

Let me know if there's any changes better to be made in Phenogrid, or just help with testing.

@harryhoch
Copy link
Collaborator

@yuanzhou, don't worry about this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants