-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate number of unmatched phenotypes per column #245
Comments
Scoring is done by the owlsim server. @cmungall must have answers for that. |
we have an option to show unmatched phenotypes for the query, but not for the matches. If we did, you'd see the lower scoring ones would have many unmatched phenotypes |
Ah right; of course. Perhaps then, phenogrid could at least have a number for each column showing how many unmatched phenotypes there are? That would help make more sense of reports like this. |
I've always disliked the hidden unmatched terms. If we implement a hierarchical y axis there might be a way to render them differently rather than hiding them |
On a related note, when we get to phenogrid from a disease page (compare tab) I can't figure out why it is that the top disease hit isn't either: A) a different disease altogether We have neither A nor B now: the top hit is always identical in name/ID to the disease that spawned the query; however the match scores can be well below 100; for example https://monarchinitiative.org/disease/OMIM%3A127750#compare has a match score of 79. What am I missing? |
Checked on beta, same issue. But it also showed odd fly matches. Following up, we should not be including inferred phenotypes like these (this belongs in a separate ticket, just noting here for now) EDIT: not a phenogrid issue, now tracked here: https://github.com/monarch-initiative/monarch-app/issues/1243 |
Let me know if there's any changes better to be made in Phenogrid, or just help with testing. |
@yuanzhou, don't worry about this for now. |
This is really more of an owlsim / scigraph issue but manifesting here.
It is not clear why we're seeing higher scores for diseases that have fewer phenotype matches. I expected this to be the result of slightly different scoring, or weighting by IC score, but this appears not to be the case?
@kshefchek @jnguyenx ?
The text was updated successfully, but these errors were encountered: