Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epee: delete dead code #9586

Closed
wants to merge 1 commit into from
Closed

epee: delete dead code #9586

wants to merge 1 commit into from
+0 −1,100

Conversation

0xFFFC0000
Copy link
Collaborator

No description provided.

vtnerd
vtnerd reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@vtnerd vtnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap.

The idea was to replace the serialization code in a series of patches. The read patch has unfortunately stalled, so all of this looks like dead code.

@vtnerd
Copy link
Contributor

vtnerd commented Nov 22, 2024

The "next" PR for this code is #8970 .

@0xFFFC0000
Copy link
Collaborator Author

In that case, I am closing this PR.

Please feel free to reopen this PR if you are not going to push subsequent mentioned PRs.

@0xFFFC0000 0xFFFC0000 closed this Nov 23, 2024
@0xFFFC0000
Copy link
Collaborator Author

Although I closed this.

@vtnerd do you remember what was the blocker for that PR of yours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtnerd vtnerd vtnerd left review comments

Assignees
No one assigned
Labels
easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xFFFC0000 @vtnerd