cli --enable 'env' #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea! I'd prefer this to be more generic. Could we instead have a |
|
Yeah sounds good to me . I think we really need a follow up PR to covert all the recurse and common functions to just pass one argument of an options object . Cause the amount of arguments is getting rediculous and hard to track. Also I think the use of bind has to go as it makes finding errors very difficult in my own experience . |
|
Don't merge yet, found a few bugs |
|
Ok should be g2g now |
|
anything else missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow included documents to be pre-processed and inject env vars without needing !GetEnv