Make sure the OpenGL context is "current" before drawing on it #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If there are multiple
SKGLControlsdrawing at the same time, there is the chance that one view may draw on another view. Or cause issues. This is because OpenGL is basically a thread-static library, and can only have a single "current" context per thread. By callingMakeCurrent, we are letting OpenGL know that this view is drawing and all operations are here. The next view that wants to draw then also lets OpenGL know that it wants to do some work and the OpenGL can "shift" over to that one.Bugs Fixed
API Changes
None.
Behavioral Changes
When multiple
SKGLControlsare created, there is some cross-talk. This PR makes sure that each view requests control over all operations.PR Checklist