Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribution #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Distribution #23

wants to merge 2 commits into from

Conversation

neuegram
Copy link

@neuegram neuegram commented Mar 6, 2016

I'll need to add docs, tests, and examples later...

@montanaflynn
Copy link
Owner

Thanks a lot @neuegram this looks great. Once there are some tests I can add the docs / examples.

@MishraShivendra
Copy link
Contributor

@neuegram @montanaflynn
I wanted to introduce very similar changes. Is it Ok If I do a bit of reformatting around this code and push with the test-cases?
Shivendra

@montanaflynn
Copy link
Owner

@MishraShivendra that's fine with me

@MishraShivendra
Copy link
Contributor

Not sure how should I do this. Should I fork @neuegram's repo and give pull request to him, updating this pull request? or Merge this pull request to a private branch where I can place my changes and then eventually merge that to mainline?

Shivendra

@montanaflynn
Copy link
Owner

I would merge it into your own branch and submit a PR from that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neuegram @montanaflynn @MishraShivendra