-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Meteor 3 #93
base: master
Are you sure you want to change the base?
Support Meteor 3 #93
Conversation
Right now there is no way to know if a promise has been |
@@ -81,12 +80,6 @@ SystemModel.prototype.buildPayload = function () { | |||
metrics.mongoPoolCheckedOutConnections = driverMetrics.checkedOut; | |||
metrics.mongoPoolCreatedConnections = driverMetrics.created; | |||
|
|||
const fiberMetrics = getFiberMetrics(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would there be any async hooks/ALS metrics that would be useful instead? Can we track how many hooks or ASL stores are being used in the app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can, will research.
Got the following error when trying beta 5:
Initially couldn't even install because of this: meteor/meteor#13268 My packages:
|
Thanks @StorytellerCZ. I'll look into it this week. |
@zodern I'm seeing the same error as @StorytellerCZ when trying to use the 3.0 beta -- it seems to be a conflict with |
Collection hooks recently got a fix from MS core team on one thing, so it might be a good idea to test again. |
@StorytellerCZ I had tried with |
This reverts commit 70a7d5e.
Remove fibers from the agent and integrate with Async Hooks and Async Local Storage.