Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better localization for promptLocation #1980

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Txus5012
Copy link
Contributor

@Txus5012 Txus5012 commented May 1, 2024

As it is now, promptLocation works very well in english but not in other languages.

  • Title and hint aren't localized.
  • Button labels aren't shown correctly. In some languages location and side are said in the opposite order. Also, the location can be male or female and the word for the side changes, and different languages can treat this differently. Because of this, I think it's better to make strings for each location.

It is also important that even if location value is translated, location key shouldn't be.

@moo-man
Copy link
Owner

moo-man commented May 1, 2024

I didn't include this because, well, I just don't like it and would rather find an alternative, perhaps even move it to a specific function that localization modules can override.

@Forien
Copy link
Contributor

Forien commented May 1, 2024

Maybe moving these out to game.wfrp4e.config?

@Txus5012
Copy link
Contributor Author

Txus5012 commented May 2, 2024

Maybe the scripts of the items could send this info?

@Txus5012
Copy link
Contributor Author

Txus5012 commented May 4, 2024

Better like this? This solves all the issues execpt the gender one, but that's a minor one.

@moo-man
Copy link
Owner

moo-man commented May 4, 2024

It is better, yeah, though I'm considering whether or not translation modules should just overwrite the function entirely so they have complete control over how it's handled 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants