Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"other" overcast custom value, customizable overcast table per lore (i.e. Dhar) #2176

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

silentmark
Copy link
Contributor

This is small request that would allow two things:

  • customize overcast tables per lore, i.e. WoM doesn't describe overcast rules for Dhar, this option would allow to define custom table for Dhar spells that would have lower values.
  • customize "other" value for overcast rules instead of hardcoded "2". this would allow to customize behavior of some spells from unofficial grimoire, i.e. Ward (+3 SL to increase Ward power) or Terryfing and few others. In addition, this would go beyond, and allow to "define" a formula tha would increase cost of "other" overcast for each step in similar way to table.

@silentmark silentmark changed the base branch from develop to master October 6, 2024 21:28
@silentmark
Copy link
Contributor Author

@moo-man - PR updated to latest changes.

@@ -19,6 +19,7 @@ export class OvercastItemModel extends BaseItemModel {
additional : new fields.StringField(),
characteristic : new fields.StringField(),
bonus : new fields.BooleanField(),
cost : new fields.StringField()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this referenced anywhere else other than on the Sheet. Is this utilized anywhere?

If so, what is the point of having this as well as "other" in config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to be able to create a formula, that can be calculated per overcast 'level' its in WoM cast test used -
image

I didnt add it to regular CastTest, as there overcast rules are super straightforward.

@silentmark silentmark changed the base branch from master to develop October 11, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants