Improvement: Implement accessibility statement and feedback mechanism, resolves #567.

[detomon]

Resolves #567.

[christianwolters]

Hi @detomon,

I'd like to review your pull request but there are unrelated commits in this PR.
(maybe a rebase went wrong?)

Can you please cleanup your PR by resetting your branch to current main and cherry-pick your main commit?

Cheers
Christian

[detomon]

Hi @christianwolters,

It seems that main has been rebase at some point. Should be ok now.

Thank you for taking the time to review our pull request!

[christianwolters]

Hi @detomon,

thank you and your coworkers for this contribution. I really like seeing a11y getting a united boost here (sorry ^^)

My manual user facing tests checked out, during code review I found a few spots that still need some work:

• I commented directly in code as you should see above

Furthermore, please take a look at your version.php

• you are introducing new settings, so please increment the value of $plugin->version

Cheers
Christian

[christianwolters]

Review

Following https://github.com/moodle-an-hochschulen/moodle-plugin-maintaining/wiki/Check-list-for-peer-reviewing-patches-and-pull-requests

Documentation

• Commit Message understandable and issue referenced (via resolves keyword)
• Patch author correct
• CHANGES.md appended
• README.md appended
• Credits appended
• Appropriate Comment quantity
• Successful Moodle PHPDoc check

version.php

• Checked if $plugin->version increment necessary (and increment done if necessary)
• $plugin->release untouched

lib.php

• Only necessary functions

Languages

• Only english strings
• Necessary magic strings added (e.g. capabilities)

Automated tests

• New functionality covered
• No failing steps or scenarios

Mustache templates

• Example context exists

CSS and styles.css

• Bootstrap styles used if possible

Duplicated code

• Duplicated code is marked properly

Github action

• All green

Commit history and scope

• Already single commit
• Focus on single purpose
• No surplus files

Additional aspects for Boost Union

• No usage of $theme->settings
• Usage of isset() checks when processing plugin settings in renderer / output code
• Usage of admin_setting_configselect instead of admin_setting_configcheckbox
• Modified mustache templates properly marked and .upstream template in place

Review result

Hi @detomon, these are the results of my review. (I forgot to append the checklist)

See comments and conversation above, open checks:

• Appropriate Comment quantity
• Checked if $plugin->version increment necessary (and increment done if necessary)

Do you have time in the next weeks to address the open points?

Cheers
Christian

[detomon]

Hoi @christianwolters,

I just pushed the changes regarding the missing points.

Cheers,
Simon

[christianwolters]

Hi @detomon,

thank you for your changes, this looks good.

As this is PR involces changes in many files, I'll now hand over to @abias for a second review and integration.

Cheers
Christian