-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add selectable SCSS snippets #710
base: main
Are you sure you want to change the base?
Conversation
Hi @Menrath , many thanks for taking the time to submit this PR after the Devcamp! As soon as I have time, I will then review the PR. Cheers, |
41d45e6
to
125838b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Those improvements all look good to me!
@abias I started some drafts on manually uploading snippets: Two possible solutions: just use a filepicker and add a delete action to the table, or use the filemanager and it's builtin "management" of uploaded files. I would favour the first, as the UI could be more compact. Maybe also putting the pilepicker in a modal to save UI space? |
5696e9a
to
b9fa4ca
Compare
@Menrath - Thanks for asking. I just went ahead and pushed some additional commits which introduce a settings tab on the CSS snippets page on which you will find a (already functional) kill switch for the built-in snippets and a (currently not yet working) filepicker for uploaded snippets. I would appreciate if you could go ahead and add the necessary logic to load and use the uploaded snippets on this basis. |
… members of the MoodleMootDACH dev camp team 22.
…n is not the active theme
…used during development
This is a result from a DevCamp session at the 2024 https://moodlemootdach.org
Thanks for @abias, @bartdenhoed and the others!
Note: All commits in this PR should definitely get squashed before merging.
Description:
TODO
What is still missing:
Additional features / aspects:
To Discuss: