Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Support more seamless upgrade to 4.5 by only requiring /cache/classes/loaders.php if it is present, resolves #708. #764

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

abias
Copy link
Member

@abias abias commented Nov 19, 2024

No description provided.

@abias
Copy link
Member Author

abias commented Nov 19, 2024

Note: This PR must not be merged into main and 4.5. It will be merged into 4.4 and backported to 4.3 and 4.1

…e/classes/loaders.php if it is present, resolves #708.
@abias abias merged commit 792eecd into MOODLE_404_STABLE Nov 20, 2024
0 of 12 checks passed
@abias abias deleted the issue-708 branch November 20, 2024 06:40
abias added a commit that referenced this pull request Nov 20, 2024
…e/classes/loaders.php if it is present, resolves #708. (#764)
abias added a commit that referenced this pull request Nov 20, 2024
…e/classes/loaders.php if it is present, resolves #708. (#764)
@ralf-krause
Copy link
Contributor

ralf-krause commented Nov 20, 2024

Hi Alex,
you wrote:
Note: This PR must not be merged into main and 4.5. It will be merged into 4.4 and backported to 4.3 and 4.1

You add some code into the next Boost Union releases v4.1-r33, 4.3-r19 and 4.4-r6. v4.2-r21 is missing because an upgrade also can be done from Moodle 4.2 to Moodle 4.5. The minimal is Moodle 4.1.2 to update to Moodle 4.5 … and this includes 4.1.2 and better, and all versions 4.2.x, 4.3.x, and 4.4.x.

I fear that this will not fix the problem completely. An admin must know that the Boost Union update to the next version is required before he starts the upgrade to Moodle 4.5.

Ralf

@abias
Copy link
Member Author

abias commented Nov 20, 2024

Hi @ralf-krause ,

I see your point.
But this upgrading issue is a problem of already installed pre-4.5 plugin versions.
We made a mistake in the past and we cannot turn back time.

I can only publish new plugin releases for older Moodle versions and hope that the admins update to these latest 4.1 / 4.3 / 4.4 plugin versions before they move on to Moodle 4.5. If the admins do this, they won't be affected by the upgrading issue.

Regarding 4.2, this Moodle version is out of support for more than a month now and we have stopped publishing new BU versions for 4.2 since then. Even if I would publish a new BU release for 4.2 with the fix, I would not assume that admins will install it if they do not even manage to keep their Moodle core up to date and safe.

And anyway, this issue is indeed a blocker for the 4.5 upgrade, that's right. But it does not destroy any data. As soon as the BU plugin is upgraded to 4.5, Moodle core can be upgraded without any issue.

Cheers,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants