Skip to content

Commit

Permalink
fix: Check against deep dependencies.
Browse files Browse the repository at this point in the history
  • Loading branch information
milesj committed Nov 27, 2024
1 parent 755033b commit 4c99ccf
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
- Fixed a Git "fatal: bad object" error when submodules are in being used.
- Fixed an issue where `moon ci` would trigger a shallow checkout error, even when a base revision
is provided.
- Fixed an issue were changes in a non-direct dependency would not mark a deep dependent as
affected.

## 1.30.0

Expand Down
2 changes: 1 addition & 1 deletion crates/app/src/commands/ci.rs
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ async fn generate_action_graph(

let mut action_graph_builder = session.build_action_graph(workspace_graph).await?;
action_graph_builder.set_touched_files(touched_files)?;
action_graph_builder.set_affected_scopes(UpstreamScope::Direct, DownstreamScope::Deep)?;
action_graph_builder.set_affected_scopes(UpstreamScope::Deep, DownstreamScope::Deep)?;

// Run dependents to ensure consumers still work correctly
action_graph_builder.run_from_requirements(RunRequirements {
Expand Down
2 changes: 1 addition & 1 deletion crates/app/src/commands/run.rs
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ pub async fn run_target(
if should_run_affected {
action_graph_builder.set_touched_files(&touched_files)?;
action_graph_builder.set_affected_scopes(
UpstreamScope::Direct,
UpstreamScope::Deep,
if args.dependents {
DownstreamScope::Direct
} else {
Expand Down
4 changes: 2 additions & 2 deletions crates/task-hasher/src/task_hasher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use starbase_utils::glob::{self, GlobSet};
use std::collections::BTreeMap;
use std::env;
use std::path::{Path, PathBuf};
use tracing::{debug, warn};
use tracing::{trace, warn};

// Hash all inputs for a task, but exclude outputs and moon specific configuration files!
pub struct TaskHasher<'task> {
Expand Down Expand Up @@ -226,7 +226,7 @@ impl<'task> TaskHasher<'task> {
}

if ignore.is_match(path) {
debug!(
trace!(
"Not hashing input {} as it matches an ignore pattern",
color::rel_path(&rel_path),
);
Expand Down

0 comments on commit 4c99ccf

Please sign in to comment.