internal: Rewrite platform runtime logic. #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run report for 1d7cf773
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(18.18.0) |
21.4s | Passed | |
| 🟩 | SyncNodeProject(types) |
1.6ms | Passed | |
| 🟩 | InstallNodeDeps(18.18.0) |
1m 31s | Passed | |
| 🟩 | RunTarget(types:build) |
4.4s | Passed | |
| 🟩 | SyncNodeProject(runtime) |
2.6ms | Passed | |
| 🟩 | SyncNodeProject(website) |
2.4ms | Passed | |
| 🟩 | SyncNodeProject(report) |
3.7ms | Passed | |
| 🟩 | RunTarget(runtime:build) |
3.9s | Passed | |
| 🟩 | SyncWorkspace |
0.1ms | Passed | |
| 🟩 | RunTarget(website:typecheck) |
7.1s | Passed | |
| 🟩 | RunTarget(website:test) |
7.8s | Passed | |
| 🟩 | RunTarget(website:lint) |
12.3s | Passed | |
| 🟩 | RunTarget(website:format) |
20.5s | Passed | |
| 🟩 | RunTarget(report:typecheck) |
11.7s | Passed | |
| 🟩 | RunTarget(report:test) |
4.6s | Passed | |
| 🟩 | RunTarget(report:lint) |
8.8s | Passed | |
| 🟩 | RunTarget(report:format) |
7.8s | Passed | |
| 🟩 | RunTarget(report:build) |
4.9s | Passed | |
| 🟩 | RunTarget(runtime:typecheck) |
6.6s | Passed | |
| 🟩 | RunTarget(runtime:test) |
3.2s | Passed | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | RunTarget(runtime:lint) |
7.4s | Passed | |
| 🟩 | RunTarget(runtime:format) |
7.4s | Passed | |
| 🟩 | RunTarget(website:build) |
2m 34s | Passed | SLOW |
Environment
OS: Linux
Matrix:
os = ubuntu-latest
node-version = 18
Variables:
MOON_NODE_VERSION = 18.18.0
Touched files
Cargo.lock
crates/core/action-pipeline/src/actions/install_deps.rs
crates/core/action-pipeline/src/actions/setup_tool.rs
crates/core/action-pipeline/src/subscribers/moonbase.rs
crates/core/action-pipeline/tests/estimator_test.rs
crates/core/action/Cargo.toml
crates/core/action/src/node.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/emitter/Cargo.toml
crates/core/platform-runtime/Cargo.toml
crates/core/platform-runtime/src/lib.rs
crates/core/platform-runtime/src/runtime.rs
crates/core/platform-runtime/src/version.rs
crates/core/platform/Cargo.toml
crates/core/platform/src/platform.rs
crates/core/runner/Cargo.toml
crates/core/tool/Cargo.toml
crates/core/tool/src/manager.rs
crates/deno/platform/src/platform.rs
crates/deno/tool/Cargo.toml
crates/deno/tool/src/deno_tool.rs
crates/node/platform/src/platform.rs
crates/node/tool/Cargo.toml
crates/node/tool/src/node_tool.rs
crates/node/tool/src/npm_tool.rs
crates/node/tool/src/pnpm_tool.rs
crates/node/tool/src/yarn_tool.rs
crates/rust/platform/src/rust_platform.rs
crates/rust/platform/tests/rust_platform_test.rs
crates/rust/tool/Cargo.toml
crates/rust/tool/src/rust_tool.rs
crates/system/platform/src/platform.rs
nextgen/config/src/lib.rs
nextgen/platform-runtime/Cargo.toml
nextgen/platform-runtime/src/lib.rs
rust-toolchain.toml
Run report for 1d7cf773
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(16.20.2) |
19.4s | Passed | |
| 🟩 | SyncNodeProject(types) |
1.5ms | Passed | |
| 🟩 | InstallNodeDeps(16.20.2) |
1m 19s | Passed | |
| 🟩 | RunTarget(types:build) |
4.2s | Passed | |
| 🟩 | SyncNodeProject(runtime) |
1.9ms | Passed | |
| 🟩 | SyncNodeProject(website) |
1.7ms | Passed | |
| 🟩 | SyncNodeProject(report) |
4.3ms | Passed | |
| 🟩 | RunTarget(runtime:build) |
3.6s | Passed | |
| 🟩 | SyncWorkspace |
0.1ms | Passed | |
| 🟩 | RunTarget(website:typecheck) |
6.8s | Passed | |
| 🟩 | RunTarget(website:test) |
7.4s | Passed | |
| 🟩 | RunTarget(website:lint) |
11.3s | Passed | |
| 🟩 | RunTarget(website:format) |
17.8s | Passed | |
| 🟩 | RunTarget(report:typecheck) |
9.8s | Passed | |
| 🟩 | RunTarget(report:test) |
4.3s | Passed | |
| 🟩 | RunTarget(report:lint) |
7.9s | Passed | |
| 🟩 | RunTarget(report:format) |
7.1s | Passed | |
| 🟩 | RunTarget(report:build) |
4.4s | Passed | |
| 🟩 | RunTarget(runtime:typecheck) |
6.1s | Passed | |
| 🟩 | RunTarget(runtime:test) |
3s | Passed | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | RunTarget(runtime:lint) |
6.7s | Passed | |
| 🟩 | RunTarget(runtime:format) |
6.7s | Passed | |
| 🟩 | RunTarget(website:build) |
2m 9s | Passed | SLOW |
Environment
OS: Linux
Matrix:
os = ubuntu-latest
node-version = 16
Variables:
MOON_NODE_VERSION = 16.20.2
Touched files
Cargo.lock
crates/core/action-pipeline/src/actions/install_deps.rs
crates/core/action-pipeline/src/actions/setup_tool.rs
crates/core/action-pipeline/src/subscribers/moonbase.rs
crates/core/action-pipeline/tests/estimator_test.rs
crates/core/action/Cargo.toml
crates/core/action/src/node.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/emitter/Cargo.toml
crates/core/platform-runtime/Cargo.toml
crates/core/platform-runtime/src/lib.rs
crates/core/platform-runtime/src/runtime.rs
crates/core/platform-runtime/src/version.rs
crates/core/platform/Cargo.toml
crates/core/platform/src/platform.rs
crates/core/runner/Cargo.toml
crates/core/tool/Cargo.toml
crates/core/tool/src/manager.rs
crates/deno/platform/src/platform.rs
crates/deno/tool/Cargo.toml
crates/deno/tool/src/deno_tool.rs
crates/node/platform/src/platform.rs
crates/node/tool/Cargo.toml
crates/node/tool/src/node_tool.rs
crates/node/tool/src/npm_tool.rs
crates/node/tool/src/pnpm_tool.rs
crates/node/tool/src/yarn_tool.rs
crates/rust/platform/src/rust_platform.rs
crates/rust/platform/tests/rust_platform_test.rs
crates/rust/tool/Cargo.toml
crates/rust/tool/src/rust_tool.rs
crates/system/platform/src/platform.rs
nextgen/config/src/lib.rs
nextgen/platform-runtime/Cargo.toml
nextgen/platform-runtime/src/lib.rs
rust-toolchain.toml
Run report for 1d7cf773
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(20.7.0) |
31.2s | Passed | |
| 🟩 | SyncNodeProject(types) |
7.4ms | Passed | |
| 🟩 | InstallNodeDeps(20.7.0) |
2m 6s | Passed | SLOW |
| 🟩 | RunTarget(types:build) |
6.8s | Passed | |
| 🟩 | SyncNodeProject(runtime) |
4.7ms | Passed | |
| 🟩 | SyncNodeProject(website) |
3.7ms | Passed | |
| 🟩 | SyncNodeProject(report) |
3.6ms | Passed | |
| 🟩 | RunTarget(runtime:build) |
6.2s | Passed | |
| 🟩 | SyncWorkspace |
0.2ms | Passed | |
| 🟩 | RunTarget(website:typecheck) |
10.4s | Passed | |
| 🟩 | RunTarget(website:test) |
2.1s | Passed | |
| 🟩 | RunTarget(website:lint) |
27.3s | Passed | |
| 🟩 | RunTarget(website:format) |
29.9s | Passed | |
| 🟩 | RunTarget(report:typecheck) |
15s | Passed | |
| 🟩 | RunTarget(report:test) |
7.6s | Passed | |
| 🟩 | RunTarget(report:lint) |
15.7s | Passed | |
| 🟩 | RunTarget(report:format) |
13.5s | Passed | |
| 🟩 | RunTarget(report:build) |
7.5s | Passed | |
| 🟩 | RunTarget(runtime:typecheck) |
10.1s | Passed | |
| 🟩 | RunTarget(runtime:test) |
5.1s | Passed | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | RunTarget(runtime:lint) |
13.5s | Passed | |
| 🟩 | RunTarget(runtime:format) |
13.3s | Passed | |
| 🟩 | RunTarget(website:build) |
3m 9s | Passed | SLOW |
Environment
OS: Windows
Matrix:
os = windows-latest
node-version = 20
Variables:
MOON_NODE_VERSION = 20.7.0
Touched files
Cargo.lock
crates/core/action-pipeline/src/actions/install_deps.rs
crates/core/action-pipeline/src/actions/setup_tool.rs
crates/core/action-pipeline/src/subscribers/moonbase.rs
crates/core/action-pipeline/tests/estimator_test.rs
crates/core/action/Cargo.toml
crates/core/action/src/node.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/emitter/Cargo.toml
crates/core/platform-runtime/Cargo.toml
crates/core/platform-runtime/src/lib.rs
crates/core/platform-runtime/src/runtime.rs
crates/core/platform-runtime/src/version.rs
crates/core/platform/Cargo.toml
crates/core/platform/src/platform.rs
crates/core/runner/Cargo.toml
crates/core/tool/Cargo.toml
crates/core/tool/src/manager.rs
crates/deno/platform/src/platform.rs
crates/deno/tool/Cargo.toml
crates/deno/tool/src/deno_tool.rs
crates/node/platform/src/platform.rs
crates/node/tool/Cargo.toml
crates/node/tool/src/node_tool.rs
crates/node/tool/src/npm_tool.rs
crates/node/tool/src/pnpm_tool.rs
crates/node/tool/src/yarn_tool.rs
crates/rust/platform/src/rust_platform.rs
crates/rust/platform/tests/rust_platform_test.rs
crates/rust/tool/Cargo.toml
crates/rust/tool/src/rust_tool.rs
crates/system/platform/src/platform.rs
nextgen/config/src/lib.rs
nextgen/platform-runtime/Cargo.toml
nextgen/platform-runtime/src/lib.rs
rust-toolchain.toml
Run report for 1d7cf773
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(16.20.2) |
21s | Passed | |
| 🟩 | SyncNodeProject(types) |
2.8ms | Passed | |
| 🟩 | InstallNodeDeps(16.20.2) |
1m 38s | Passed | |
| 🟩 | RunTarget(types:build) |
5.2s | Passed | |
| 🟩 | SyncNodeProject(runtime) |
2.7ms | Passed | |
| 🟩 | SyncNodeProject(website) |
3.1ms | Passed | |
| 🟩 | SyncNodeProject(report) |
3.1ms | Passed | |
| 🟩 | RunTarget(runtime:build) |
4.7s | Passed | |
| 🟩 | SyncWorkspace |
15.1ms | Passed | |
| 🟩 | RunTarget(website:typecheck) |
7.7s | Passed | |
| 🟩 | RunTarget(website:test) |
8.6s | Passed | |
| 🟩 | RunTarget(website:lint) |
14.3s | Passed | |
| 🟩 | RunTarget(website:format) |
22.1s | Passed | |
| 🟩 | RunTarget(report:typecheck) |
11.9s | Passed | |
| 🟩 | RunTarget(report:test) |
5.6s | Passed | |
| 🟩 | RunTarget(report:lint) |
11.4s | Passed | |
| 🟩 | RunTarget(report:format) |
10.1s | Passed | |
| 🟩 | RunTarget(report:build) |
5.7s | Passed | |
| 🟩 | RunTarget(runtime:typecheck) |
8.3s | Passed | |
| 🟩 | RunTarget(runtime:test) |
4.5s | Passed | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | RunTarget(runtime:lint) |
9.2s | Passed | |
| 🟩 | RunTarget(runtime:format) |
9.1s | Passed | |
| 🟩 | RunTarget(website:build) |
2m 17s | Passed | SLOW |
Environment
OS: Windows
Matrix:
os = windows-latest
node-version = 16
Variables:
MOON_NODE_VERSION = 16.20.2
Touched files
Cargo.lock
crates/core/action-pipeline/src/actions/install_deps.rs
crates/core/action-pipeline/src/actions/setup_tool.rs
crates/core/action-pipeline/src/subscribers/moonbase.rs
crates/core/action-pipeline/tests/estimator_test.rs
crates/core/action/Cargo.toml
crates/core/action/src/node.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/emitter/Cargo.toml
crates/core/platform-runtime/Cargo.toml
crates/core/platform-runtime/src/lib.rs
crates/core/platform-runtime/src/runtime.rs
crates/core/platform-runtime/src/version.rs
crates/core/platform/Cargo.toml
crates/core/platform/src/platform.rs
crates/core/runner/Cargo.toml
crates/core/tool/Cargo.toml
crates/core/tool/src/manager.rs
crates/deno/platform/src/platform.rs
crates/deno/tool/Cargo.toml
crates/deno/tool/src/deno_tool.rs
crates/node/platform/src/platform.rs
crates/node/tool/Cargo.toml
crates/node/tool/src/node_tool.rs
crates/node/tool/src/npm_tool.rs
crates/node/tool/src/pnpm_tool.rs
crates/node/tool/src/yarn_tool.rs
crates/rust/platform/src/rust_platform.rs
crates/rust/platform/tests/rust_platform_test.rs
crates/rust/tool/Cargo.toml
crates/rust/tool/src/rust_tool.rs
crates/system/platform/src/platform.rs
nextgen/config/src/lib.rs
nextgen/platform-runtime/Cargo.toml
nextgen/platform-runtime/src/lib.rs
rust-toolchain.toml
Run report for 1d7cf773
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(20.7.0) |
21.3s | Passed | |
| 🟩 | SyncNodeProject(types) |
1.6ms | Passed | |
| 🟩 | InstallNodeDeps(20.7.0) |
1m 24s | Passed | |
| 🟩 | RunTarget(types:build) |
3.9s | Passed | |
| 🟩 | SyncNodeProject(runtime) |
2ms | Passed | |
| 🟩 | SyncNodeProject(website) |
2ms | Passed | |
| 🟩 | SyncNodeProject(report) |
1.6ms | Passed | |
| 🟩 | RunTarget(runtime:build) |
3.4s | Passed | |
| 🟩 | SyncWorkspace |
12.8ms | Passed | |
| 🟩 | RunTarget(website:typecheck) |
6.1s | Passed | |
| 🟩 | RunTarget(website:test) |
6.7s | Passed | |
| 🟩 | RunTarget(website:lint) |
10.1s | Passed | |
| 🟩 | RunTarget(website:format) |
17.3s | Passed | |
| 🟩 | RunTarget(report:typecheck) |
10.2s | Passed | |
| 🟩 | RunTarget(report:test) |
4s | Passed | |
| 🟩 | RunTarget(report:lint) |
7.4s | Passed | |
| 🟩 | RunTarget(report:format) |
6.5s | Passed | |
| 🟩 | RunTarget(report:build) |
4.2s | Passed | |
| 🟩 | RunTarget(runtime:typecheck) |
5.7s | Passed | |
| 🟩 | RunTarget(runtime:test) |
2.8s | Passed | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | RunTarget(runtime:lint) |
6.2s | Passed | |
| 🟩 | RunTarget(runtime:format) |
6.2s | Passed | |
| 🟩 | RunTarget(website:build) |
2m 3s | Passed | SLOW |
Environment
OS: Linux
Matrix:
os = ubuntu-latest
node-version = 20
Variables:
MOON_NODE_VERSION = 20.7.0
Touched files
Cargo.lock
crates/core/action-pipeline/src/actions/install_deps.rs
crates/core/action-pipeline/src/actions/setup_tool.rs
crates/core/action-pipeline/src/subscribers/moonbase.rs
crates/core/action-pipeline/tests/estimator_test.rs
crates/core/action/Cargo.toml
crates/core/action/src/node.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/emitter/Cargo.toml
crates/core/platform-runtime/Cargo.toml
crates/core/platform-runtime/src/lib.rs
crates/core/platform-runtime/src/runtime.rs
crates/core/platform-runtime/src/version.rs
crates/core/platform/Cargo.toml
crates/core/platform/src/platform.rs
crates/core/runner/Cargo.toml
crates/core/tool/Cargo.toml
crates/core/tool/src/manager.rs
crates/deno/platform/src/platform.rs
crates/deno/tool/Cargo.toml
crates/deno/tool/src/deno_tool.rs
crates/node/platform/src/platform.rs
crates/node/tool/Cargo.toml
crates/node/tool/src/node_tool.rs
crates/node/tool/src/npm_tool.rs
crates/node/tool/src/pnpm_tool.rs
crates/node/tool/src/yarn_tool.rs
crates/rust/platform/src/rust_platform.rs
crates/rust/platform/tests/rust_platform_test.rs
crates/rust/tool/Cargo.toml
crates/rust/tool/src/rust_tool.rs
crates/system/platform/src/platform.rs
nextgen/config/src/lib.rs
nextgen/platform-runtime/Cargo.toml
nextgen/platform-runtime/src/lib.rs
rust-toolchain.toml
Run report for 1d7cf773
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(18.18.0) |
54.4s | Passed | |
| 🟩 | SyncNodeProject(types) |
4ms | Passed | |
| 🟩 | InstallNodeDeps(18.18.0) |
2m 2s | Passed | SLOW |
| 🟩 | RunTarget(types:build) |
7.1s | Passed | |
| 🟩 | SyncNodeProject(runtime) |
4ms | Passed | |
| 🟩 | SyncNodeProject(website) |
947.4ms | Passed | |
| 🟩 | SyncNodeProject(report) |
947.3ms | Passed | |
| 🟩 | RunTarget(runtime:build) |
7.1s | Passed | |
| 🟩 | SyncWorkspace |
0.2ms | Passed | |
| 🟩 | RunTarget(website:typecheck) |
9.9s | Passed | |
| 🟩 | RunTarget(website:test) |
11.1s | Passed | |
| 🟩 | RunTarget(website:lint) |
20.6s | Passed | |
| 🟩 | RunTarget(website:format) |
30.5s | Passed | |
| 🟩 | RunTarget(report:typecheck) |
15.4s | Passed | |
| 🟩 | RunTarget(report:test) |
7.9s | Passed | |
| 🟩 | RunTarget(report:lint) |
16.3s | Passed | |
| 🟩 | RunTarget(report:format) |
14s | Passed | |
| 🟩 | RunTarget(report:build) |
7.8s | Passed | |
| 🟩 | RunTarget(runtime:typecheck) |
10.2s | Passed | |
| 🟩 | RunTarget(runtime:test) |
5s | Passed | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | RunTarget(runtime:lint) |
14s | Passed | |
| 🟩 | RunTarget(runtime:format) |
13.8s | Passed | |
| 🟩 | RunTarget(website:build) |
3m 14s | Passed | SLOW |
Environment
OS: Windows
Matrix:
os = windows-latest
node-version = 18
Variables:
MOON_NODE_VERSION = 18.18.0
Touched files
Cargo.lock
crates/core/action-pipeline/src/actions/install_deps.rs
crates/core/action-pipeline/src/actions/setup_tool.rs
crates/core/action-pipeline/src/subscribers/moonbase.rs
crates/core/action-pipeline/tests/estimator_test.rs
crates/core/action/Cargo.toml
crates/core/action/src/node.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/emitter/Cargo.toml
crates/core/platform-runtime/Cargo.toml
crates/core/platform-runtime/src/lib.rs
crates/core/platform-runtime/src/runtime.rs
crates/core/platform-runtime/src/version.rs
crates/core/platform/Cargo.toml
crates/core/platform/src/platform.rs
crates/core/runner/Cargo.toml
crates/core/tool/Cargo.toml
crates/core/tool/src/manager.rs
crates/deno/platform/src/platform.rs
crates/deno/tool/Cargo.toml
crates/deno/tool/src/deno_tool.rs
crates/node/platform/src/platform.rs
crates/node/tool/Cargo.toml
crates/node/tool/src/node_tool.rs
crates/node/tool/src/npm_tool.rs
crates/node/tool/src/pnpm_tool.rs
crates/node/tool/src/yarn_tool.rs
crates/rust/platform/src/rust_platform.rs
crates/rust/platform/tests/rust_platform_test.rs
crates/rust/tool/Cargo.toml
crates/rust/tool/src/rust_tool.rs
crates/system/platform/src/platform.rs
nextgen/config/src/lib.rs
nextgen/platform-runtime/Cargo.toml
nextgen/platform-runtime/src/lib.rs
rust-toolchain.toml
milesj
added a commit
that referenced
this pull request
Sep 25, 2023
* Add new crate. * Update tool. * Update actions. * Update deno and rust. * Update node and system. * Fix lints. * Delete old code. * Redo override. * Rename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is easier to work with.