Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow non-yaml files in .moon/tasks. #1080

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix: Allow non-yaml files in .moon/tasks. #1080

merged 2 commits into from
Sep 28, 2023

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Sep 28, 2023

Fixes #1077

@github-actions
Copy link

Run report for 6c3fd532 (ubuntu-latest, 18)

Total time: 4m 57s | Comparison time: 5m 10s | Estimated savings: 13.9s (4.5% faster)

Action Time Status Info
🟩 SetupNodeTool(18.18.0) 15.7s Passed
🟩 SyncNodeProject(types) 1.6ms Passed
🟩 InstallNodeDeps(18.18.0) 1m 20s Passed
🟩 RunTarget(types:build) 3.9s Passed
🟩 SyncNodeProject(runtime) 1.9ms Passed
🟩 SyncNodeProject(website) 2.4ms Passed
🟩 SyncNodeProject(report) 1.7ms Passed
🟩 RunTarget(runtime:build) 3.6s Passed
🟩 SyncWorkspace 0ms Passed
🟩 RunTarget(website:typecheck) 6.6s Passed
🟩 RunTarget(website:test) 7.2s Passed
🟩 RunTarget(website:lint) 11.6s Passed
🟩 RunTarget(website:format) 19.4s Passed
🟩 RunTarget(report:typecheck) 11s Passed
🟩 RunTarget(report:test) 4.3s Passed
🟩 RunTarget(report:lint) 8.2s Passed
🟩 RunTarget(report:format) 7.3s Passed
🟩 RunTarget(report:build) 4.5s Passed
🟩 RunTarget(runtime:typecheck) 6s Passed
🟩 RunTarget(runtime:test) 3s Passed
And 3 more...
Expanded report
Action Time Status Info
🟩 RunTarget(runtime:lint) 7s Passed
🟩 RunTarget(runtime:format) 7s Passed
🟩 RunTarget(website:build) 2m 22s Passed SLOW
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.18.0
Touched files
.yarn/versions/8dfb2dc3.yml
nextgen/config/src/inherited_tasks_config.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

Run report for 6c3fd532 (ubuntu-latest, 16)

Total time: 4m 58s | Comparison time: 5m 13s | Estimated savings: 14.9s (4.7% faster)

Action Time Status Info
🟩 SetupNodeTool(16.20.2) 14.1s Passed
🟩 SyncNodeProject(types) 2.9ms Passed
🟩 InstallNodeDeps(16.20.2) 1m 14s Passed
🟩 RunTarget(types:build) 4.7s Passed
🟩 SyncNodeProject(runtime) 2.2ms Passed
🟩 SyncNodeProject(website) 22ms Passed
🟩 SyncNodeProject(report) 20.4ms Passed
🟩 RunTarget(runtime:build) 3.9s Passed
🟩 SyncWorkspace 0ms Passed
🟩 RunTarget(website:typecheck) 7.5s Passed
🟩 RunTarget(website:test) 8.1s Passed
🟩 RunTarget(website:lint) 12.3s Passed
🟩 RunTarget(website:format) 19.7s Passed
🟩 RunTarget(report:typecheck) 11s Passed
🟩 RunTarget(report:test) 4.7s Passed
🟩 RunTarget(report:lint) 8.6s Passed
🟩 RunTarget(report:format) 7.6s Passed
🟩 RunTarget(report:build) 4.8s Passed
🟩 RunTarget(runtime:typecheck) 6.7s Passed
🟩 RunTarget(runtime:test) 3.2s Passed
And 3 more...
Expanded report
Action Time Status Info
🟩 RunTarget(runtime:lint) 7.2s Passed
🟩 RunTarget(runtime:format) 7.2s Passed
🟩 RunTarget(website:build) 2m 27s Passed SLOW
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 16

Variables:

MOON_NODE_VERSION = 16.20.2
Touched files
.yarn/versions/8dfb2dc3.yml
nextgen/config/src/inherited_tasks_config.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

Run report for 6c3fd532 (ubuntu-latest, 20)

Total time: 5m 35s | Comparison time: 5m 50s | Estimated savings: 15.2s (4.3% faster)

Action Time Status Info
🟩 SetupNodeTool(20.7.0) 18.6s Passed
🟩 SyncNodeProject(types) 9.7ms Passed
🟩 InstallNodeDeps(20.7.0) 1m 30s Passed
🟩 RunTarget(types:build) 5s Passed
🟩 SyncNodeProject(runtime) 3.1ms Passed
🟩 SyncNodeProject(website) 4ms Passed
🟩 SyncNodeProject(report) 4ms Passed
🟩 RunTarget(runtime:build) 4.4s Passed
🟩 SyncWorkspace 0ms Passed
🟩 RunTarget(website:typecheck) 7.6s Passed
🟩 RunTarget(website:test) 8.2s Passed
🟩 RunTarget(website:lint) 13s Passed
🟩 RunTarget(website:format) 21.4s Passed
🟩 RunTarget(report:typecheck) 12s Passed
🟩 RunTarget(report:test) 4.9s Passed
🟩 RunTarget(report:lint) 9.1s Passed
🟩 RunTarget(report:format) 8.1s Passed
🟩 RunTarget(report:build) 5.2s Passed
🟩 RunTarget(runtime:typecheck) 6.9s Passed
🟩 RunTarget(runtime:test) 3.3s Passed
And 3 more...
Expanded report
Action Time Status Info
🟩 RunTarget(runtime:lint) 7.6s Passed
🟩 RunTarget(runtime:format) 7.6s Passed
🟩 RunTarget(website:build) 2m 39s Passed SLOW
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.7.0
Touched files
.yarn/versions/8dfb2dc3.yml
nextgen/config/src/inherited_tasks_config.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

Run report for 6c3fd532 (windows-latest, 20)

Total time: 7m 1s | Comparison time: 7m 20s | Estimated savings: 19.7s (4.5% faster)

Action Time Status Info
🟩 SetupNodeTool(20.7.0) 25.4s Passed
🟩 SyncNodeProject(types) 9.3ms Passed
🟩 InstallNodeDeps(20.7.0) 3m 14s Passed SLOW
🟩 RunTarget(types:build) 4.8s Passed
🟩 SyncNodeProject(runtime) 2.8ms Passed
🟩 SyncNodeProject(website) 2.7ms Passed
🟩 SyncNodeProject(report) 2.7ms Passed
🟩 RunTarget(runtime:build) 4.4s Passed
🟩 SyncWorkspace 0.1ms Passed
🟩 RunTarget(website:typecheck) 6.8s Passed
🟩 RunTarget(website:test) 7.6s Passed
🟩 RunTarget(website:lint) 13.4s Passed
🟩 RunTarget(website:format) 20.5s Passed
🟩 RunTarget(report:typecheck) 10.9s Passed
🟩 RunTarget(report:test) 5.3s Passed
🟩 RunTarget(report:lint) 10.4s Passed
🟩 RunTarget(report:format) 8.9s Passed
🟩 RunTarget(report:build) 5.4s Passed
🟩 RunTarget(runtime:typecheck) 7s Passed
🟩 RunTarget(runtime:test) 3.4s Passed
And 3 more...
Expanded report
Action Time Status Info
🟩 RunTarget(runtime:lint) 8.6s Passed
🟩 RunTarget(runtime:format) 8.5s Passed
🟩 RunTarget(website:build) 2m 13s Passed SLOW
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.7.0
Touched files
.yarn/versions/8dfb2dc3.yml
nextgen/config/src/inherited_tasks_config.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

Run report for 6c3fd532 (windows-latest, 16)

Total time: 7m 39s | Comparison time: 8m 11s | Estimated savings: 32s (6.5% faster)

Action Time Status Info
🟩 SetupNodeTool(16.20.2) 22s Passed
🟩 SyncNodeProject(types) 3.1ms Passed
🟩 InstallNodeDeps(16.20.2) 2m 29s Passed SLOW
🟩 RunTarget(types:build) 7.9s Passed
🟩 SyncNodeProject(runtime) 3.3ms Passed
🟩 SyncNodeProject(website) 3.3ms Passed
🟩 SyncNodeProject(report) 3.2ms Passed
🟩 RunTarget(runtime:build) 6.4s Passed
🟩 SyncWorkspace 0.2ms Passed
🟩 RunTarget(website:typecheck) 10.9s Passed
🟩 RunTarget(website:test) 12s Passed
🟩 RunTarget(website:lint) 20.3s Passed
🟩 RunTarget(website:format) 31.8s Passed
🟩 RunTarget(report:typecheck) 17s Passed
🟩 RunTarget(report:test) 7.9s Passed
🟩 RunTarget(report:lint) 14.9s Passed
🟩 RunTarget(report:format) 12.6s Passed
🟩 RunTarget(report:build) 7.8s Passed
🟩 RunTarget(runtime:typecheck) 10.4s Passed
🟩 RunTarget(runtime:test) 4.9s Passed
And 3 more...
Expanded report
Action Time Status Info
🟩 RunTarget(runtime:lint) 12.9s Passed
🟩 RunTarget(runtime:format) 12.8s Passed
🟩 RunTarget(website:build) 3m 6s Passed SLOW
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 16

Variables:

MOON_NODE_VERSION = 16.20.2
Touched files
.yarn/versions/8dfb2dc3.yml
nextgen/config/src/inherited_tasks_config.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

Run report for 6c3fd532 (windows-latest, 18)

Total time: 9m 22s | Comparison time: 9m 49s | Estimated savings: 27.7s (4.7% faster)

Action Time Status Info
🟩 SetupNodeTool(18.18.0) 30.9s Passed
🟩 SyncNodeProject(types) 12.5ms Passed
🟩 InstallNodeDeps(18.18.0) 3m 58s Passed SLOW
🟩 RunTarget(types:build) 7.9s Passed
🟩 SyncNodeProject(runtime) 429.4ms Passed
🟩 SyncNodeProject(website) 3.9ms Passed
🟩 SyncNodeProject(report) 3.8ms Passed
🟩 RunTarget(runtime:build) 6.1s Passed
🟩 SyncWorkspace 0.2ms Passed
🟩 RunTarget(website:typecheck) 10.4s Passed
🟩 RunTarget(website:test) 11.7s Passed
🟩 RunTarget(website:lint) 20.4s Passed
🟩 RunTarget(website:format) 29.8s Passed
🟩 RunTarget(report:typecheck) 14.6s Passed
🟩 RunTarget(report:test) 7.1s Passed
🟩 RunTarget(report:lint) 14.7s Passed
🟩 RunTarget(report:format) 12.6s Passed
🟩 RunTarget(report:build) 7.4s Passed
🟩 RunTarget(runtime:typecheck) 9.5s Passed
🟩 RunTarget(runtime:test) 4.4s Passed
And 3 more...
Expanded report
Action Time Status Info
🟩 RunTarget(runtime:lint) 12.1s Passed
🟩 RunTarget(runtime:format) 12.5s Passed
🟩 RunTarget(website:build) 3m 15s Passed SLOW
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.18.0
Touched files
.yarn/versions/8dfb2dc3.yml
nextgen/config/src/inherited_tasks_config.rs
packages/cli/CHANGELOG.md

@milesj milesj merged commit 0c38cc5 into master Sep 28, 2023
24 checks passed
@milesj milesj deleted the fix-1077 branch September 28, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[bug][regression] moon now fails if there are non-json/yaml config files present
1 participant