fix: Include args when generating Git hooks. #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run report for c018414b
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(18.18.0) |
15.2s | Passed | |
| 🟩 | SyncNodeProject(types) |
477.3ms | Passed | |
| 🟩 | InstallNodeDeps(18.18.0) |
1m 21s | Passed | |
| 🟦 | RunTarget(types:build) |
1.4s | Cached | |
| 🟩 | SyncNodeProject(runtime) |
625.8ms | Passed | |
| 🟩 | SyncNodeProject(website) |
449.1ms | Passed | |
| 🟩 | SyncNodeProject(report) |
456.4ms | Passed | |
| 🟦 | RunTarget(runtime:build) |
953.3ms | Cached | |
| 🟩 | SyncWorkspace |
451.2ms | Passed | |
| 🟦 | RunTarget(website:typecheck) |
1.3s | Cached | |
| 🟦 | RunTarget(website:test) |
1.6s | Cached | |
| 🟦 | RunTarget(website:lint) |
1.7s | Cached | |
| 🟩 | RunTarget(website:format) |
9.8s | Passed | |
| 🟦 | RunTarget(report:typecheck) |
9.8s | Cached | |
| 🟦 | RunTarget(report:test) |
1.7s | Cached | |
| 🟦 | RunTarget(report:lint) |
1.6s | Cached | |
| 🟩 | RunTarget(report:format) |
2.1s | Passed | |
| 🟦 | RunTarget(report:build) |
2.1s | Cached | |
| 🟦 | RunTarget(runtime:typecheck) |
1.6s | Cached | |
| 🟦 | RunTarget(runtime:test) |
1.6s | Cached | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟦 | RunTarget(runtime:lint) |
1.6s | Cached | |
| 🟩 | RunTarget(runtime:format) |
1.8s | Passed | |
| 🟩 | RunTarget(website:build) |
2m 22s | Passed | SLOW |
Environment
OS: Linux
Matrix:
os = ubuntu-latest
node-version = 18
Variables:
MOON_NODE_VERSION = 18.18.0
Touched files
crates/core/moon/src/lib.rs
nextgen/api/src/launchpad.rs
nextgen/vcs-hooks/src/hooks_generator.rs
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks.snap
packages/cli/CHANGELOG.md
Run report for 7eeaad26
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(18.18.0) |
1m 28s | Passed | |
| 🟩 | SyncNodeProject(types) |
443.9ms | Passed | |
| 🟩 | InstallNodeDeps(18.18.0) |
2m 40s | Passed | SLOW |
| 🟦 | RunTarget(types:build) |
1.3s | Cached | |
| 🟩 | SyncNodeProject(runtime) |
366ms | Passed | |
| 🟩 | SyncNodeProject(website) |
312.2ms | Passed | |
| 🟩 | SyncNodeProject(report) |
312.3ms | Passed | |
| 🟦 | RunTarget(runtime:build) |
848.7ms | Cached | |
| 🟩 | SyncWorkspace |
354.6ms | Passed | |
| 🟦 | RunTarget(website:typecheck) |
1.3s | Cached | |
| 🟦 | RunTarget(website:test) |
1.6s | Cached | |
| 🟦 | RunTarget(website:lint) |
1.4s | Cached | |
| 🟩 | RunTarget(website:format) |
11.9s | Passed | |
| 🟦 | RunTarget(report:typecheck) |
11.9s | Cached | |
| 🟦 | RunTarget(report:test) |
1.5s | Cached | |
| 🟦 | RunTarget(report:lint) |
1.5s | Cached | |
| 🟩 | RunTarget(report:format) |
2.2s | Passed | |
| 🟦 | RunTarget(report:build) |
2.2s | Cached | |
| 🟦 | RunTarget(runtime:typecheck) |
1.4s | Cached | |
| 🟦 | RunTarget(runtime:test) |
1.3s | Cached | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟦 | RunTarget(runtime:lint) |
1.4s | Cached | |
| 🟩 | RunTarget(runtime:format) |
1.9s | Passed | |
| 🟦 | RunTarget(website:build) |
7.1s | Cached |
Environment
OS: Windows
Matrix:
os = windows-latest
node-version = 18
Variables:
MOON_NODE_VERSION = 18.18.0
Touched files
crates/core/moon/src/lib.rs
nextgen/api/src/launchpad.rs
nextgen/vcs-hooks/src/hooks_generator.rs
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks.snap
packages/cli/CHANGELOG.md
Run report for c018414b
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(16.20.2) |
14.8s | Passed | |
| 🟩 | SyncNodeProject(types) |
413.8ms | Passed | |
| 🟩 | InstallNodeDeps(16.20.2) |
1m 15s | Passed | |
| 🟦 | RunTarget(types:build) |
1.4s | Cached | |
| 🟩 | SyncNodeProject(runtime) |
539.3ms | Passed | |
| 🟩 | SyncNodeProject(website) |
674.8ms | Passed | |
| 🟩 | SyncNodeProject(report) |
459.6ms | Passed | |
| 🟦 | RunTarget(runtime:build) |
850.9ms | Cached | |
| 🟩 | SyncWorkspace |
439.6ms | Passed | |
| 🟦 | RunTarget(website:typecheck) |
1.3s | Cached | |
| 🟦 | RunTarget(website:test) |
1.7s | Cached | |
| 🟦 | RunTarget(website:lint) |
1.7s | Cached | |
| 🟩 | RunTarget(website:format) |
8.9s | Passed | |
| 🟦 | RunTarget(report:typecheck) |
8.8s | Cached | |
| 🟦 | RunTarget(report:test) |
1.6s | Cached | |
| 🟦 | RunTarget(report:lint) |
1.6s | Cached | |
| 🟩 | RunTarget(report:format) |
2s | Passed | |
| 🟦 | RunTarget(report:build) |
2s | Cached | |
| 🟦 | RunTarget(runtime:typecheck) |
1.6s | Cached | |
| 🟦 | RunTarget(runtime:test) |
1.6s | Cached | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟦 | RunTarget(runtime:lint) |
1.6s | Cached | |
| 🟩 | RunTarget(runtime:format) |
1.7s | Passed | |
| 🟩 | RunTarget(website:build) |
2m 20s | Passed | SLOW |
Environment
OS: Linux
Matrix:
os = ubuntu-latest
node-version = 16
Variables:
MOON_NODE_VERSION = 16.20.2
Touched files
crates/core/moon/src/lib.rs
nextgen/api/src/launchpad.rs
nextgen/vcs-hooks/src/hooks_generator.rs
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks.snap
packages/cli/CHANGELOG.md
Run report for c018414b
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(20.7.0) |
20.4s | Passed | |
| 🟩 | SyncNodeProject(types) |
500.9ms | Passed | |
| 🟩 | InstallNodeDeps(20.7.0) |
1m 46s | Passed | |
| 🟦 | RunTarget(types:build) |
1.5s | Cached | |
| 🟩 | SyncNodeProject(runtime) |
875.5ms | Passed | |
| 🟩 | SyncNodeProject(website) |
608ms | Passed | |
| 🟩 | SyncNodeProject(report) |
618.7ms | Passed | |
| 🟦 | RunTarget(runtime:build) |
703.7ms | Cached | |
| 🟩 | SyncWorkspace |
503.2ms | Passed | |
| 🟦 | RunTarget(website:typecheck) |
1.1s | Cached | |
| 🟦 | RunTarget(website:test) |
1.3s | Cached | |
| 🟦 | RunTarget(website:lint) |
1.2s | Cached | |
| 🟩 | RunTarget(website:format) |
11.5s | Passed | |
| 🟦 | RunTarget(report:typecheck) |
11.6s | Cached | |
| 🟦 | RunTarget(report:test) |
1.2s | Cached | |
| 🟦 | RunTarget(report:lint) |
1.2s | Cached | |
| 🟩 | RunTarget(report:format) |
2.3s | Passed | |
| 🟦 | RunTarget(report:build) |
2.4s | Cached | |
| 🟦 | RunTarget(runtime:typecheck) |
1.4s | Cached | |
| 🟦 | RunTarget(runtime:test) |
1.3s | Cached | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟦 | RunTarget(runtime:lint) |
1.3s | Cached | |
| 🟩 | RunTarget(runtime:format) |
1.8s | Passed | |
| 🟩 | RunTarget(website:build) |
3m 11s | Passed | SLOW |
Environment
OS: Linux
Matrix:
os = ubuntu-latest
node-version = 20
Variables:
MOON_NODE_VERSION = 20.7.0
Touched files
crates/core/moon/src/lib.rs
nextgen/api/src/launchpad.rs
nextgen/vcs-hooks/src/hooks_generator.rs
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks.snap
packages/cli/CHANGELOG.md
Run report for c018414b
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(20.7.0) |
16.9s | Passed | |
| 🟩 | SyncNodeProject(types) |
436.1ms | Passed | |
| 🟩 | InstallNodeDeps(20.7.0) |
1m 12s | Passed | |
| 🟦 | RunTarget(types:build) |
1.3s | Cached | |
| 🟩 | SyncNodeProject(runtime) |
550.5ms | Passed | |
| 🟩 | SyncNodeProject(website) |
449.2ms | Passed | |
| 🟩 | SyncNodeProject(report) |
449.4ms | Passed | |
| 🟦 | RunTarget(runtime:build) |
780.9ms | Cached | |
| 🟩 | SyncWorkspace |
425.7ms | Passed | |
| 🟦 | RunTarget(website:typecheck) |
1.1s | Cached | |
| 🟦 | RunTarget(website:test) |
1.4s | Cached | |
| 🟦 | RunTarget(website:lint) |
1.5s | Cached | |
| 🟩 | RunTarget(website:format) |
7.1s | Passed | |
| 🟦 | RunTarget(report:typecheck) |
7.1s | Cached | |
| 🟦 | RunTarget(report:test) |
1.4s | Cached | |
| 🟦 | RunTarget(report:lint) |
1.3s | Cached | |
| 🟩 | RunTarget(report:format) |
1.7s | Passed | |
| 🟦 | RunTarget(report:build) |
1.8s | Cached | |
| 🟦 | RunTarget(runtime:typecheck) |
1.4s | Cached | |
| 🟦 | RunTarget(runtime:test) |
1.4s | Cached | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟦 | RunTarget(runtime:lint) |
1.3s | Cached | |
| 🟩 | RunTarget(runtime:format) |
1.5s | Passed | |
| 🟩 | RunTarget(website:build) |
1m 40s | Passed |
Environment
OS: Windows
Matrix:
os = windows-latest
node-version = 20
Variables:
MOON_NODE_VERSION = 20.7.0
Touched files
crates/core/moon/src/lib.rs
nextgen/api/src/launchpad.rs
nextgen/vcs-hooks/src/hooks_generator.rs
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks.snap
packages/cli/CHANGELOG.md
Run report for c018414b
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SetupNodeTool(16.20.2) |
2m 9s | Passed | SLOW |
| 🟩 | SyncNodeProject(types) |
399.5ms | Passed | |
| 🟩 | InstallNodeDeps(16.20.2) |
2m 19s | Passed | SLOW |
| 🟦 | RunTarget(types:build) |
1.2s | Cached | |
| 🟩 | SyncNodeProject(runtime) |
406.1ms | Passed | |
| 🟩 | SyncNodeProject(website) |
309.2ms | Passed | |
| 🟩 | SyncNodeProject(report) |
309.5ms | Passed | |
| 🟦 | RunTarget(runtime:build) |
866ms | Cached | |
| 🟩 | SyncWorkspace |
281.1ms | Passed | |
| 🟦 | RunTarget(website:typecheck) |
983.6ms | Cached | |
| 🟦 | RunTarget(website:test) |
1.4s | Cached | |
| 🟦 | RunTarget(website:lint) |
1.5s | Cached | |
| 🟩 | RunTarget(website:format) |
9.7s | Passed | |
| 🟦 | RunTarget(report:typecheck) |
9.6s | Cached | |
| 🟦 | RunTarget(report:test) |
1.4s | Cached | |
| 🟦 | RunTarget(report:lint) |
1.3s | Cached | |
| 🟩 | RunTarget(report:format) |
1.9s | Passed | |
| 🟦 | RunTarget(report:build) |
2s | Cached | |
| 🟦 | RunTarget(runtime:typecheck) |
1.4s | Cached | |
| 🟦 | RunTarget(runtime:test) |
1.4s | Cached | |
| And 3 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟦 | RunTarget(runtime:lint) |
1.4s | Cached | |
| 🟩 | RunTarget(runtime:format) |
1.7s | Passed | |
| 🟦 | RunTarget(website:build) |
6.5s | Cached |
Environment
OS: Windows
Matrix:
os = windows-latest
node-version = 16
Variables:
MOON_NODE_VERSION = 16.20.2
Touched files
crates/core/moon/src/lib.rs
nextgen/api/src/launchpad.rs
nextgen/vcs-hooks/src/hooks_generator.rs
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__unix__links_git_hooks.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks-2.snap
nextgen/vcs-hooks/tests/snapshots/hooks_generator_test__windows__links_git_hooks.snap
packages/cli/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1078
According to https://git-scm.com/docs/githooks the most args a hook can receive is 3, so passing all 3 to every hook. I tested this locally and its fine, they just are undefined.