Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix self-referencing tasks using project aliases. #1082

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Sep 28, 2023

Fixes #1079

@github-actions
Copy link

Run report for 636e81f1 (ubuntu-latest, 20)

Total time: 4m 9s | Comparison time: 7m 18s | Estimated savings: 3m 8s (43.0% faster)

Action Time Status Info
🟩 SetupNodeTool(20.7.0) 15.3s Passed
🟩 SyncNodeProject(types) 444.1ms Passed
🟩 InstallNodeDeps(20.7.0) 1m 19s Passed
🟦 RunTarget(types:build) 1.4s Cached
🟩 SyncNodeProject(runtime) 512.8ms Passed
🟩 SyncNodeProject(website) 401.5ms Passed
🟩 SyncNodeProject(report) 408.5ms Passed
🟦 RunTarget(runtime:build) 951.6ms Cached
🟩 SyncWorkspace 386.1ms Passed
🟦 RunTarget(website:typecheck) 1.2s Cached
🟦 RunTarget(website:test) 1.6s Cached
🟦 RunTarget(website:lint) 1.6s Cached
🟩 RunTarget(website:format) 9s Passed
🟦 RunTarget(report:typecheck) 9.1s Cached
🟦 RunTarget(report:test) 1.6s Cached
🟦 RunTarget(report:lint) 1.5s Cached
🟩 RunTarget(report:format) 1.9s Passed
🟦 RunTarget(report:build) 2s Cached
🟦 RunTarget(runtime:typecheck) 1.7s Cached
🟦 RunTarget(runtime:test) 1.6s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.5s Cached
🟩 RunTarget(runtime:format) 1.6s Passed
🟩 RunTarget(website:build) 2m 13s Passed SLOW
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.7.0
Touched files
crates/cli/src/commands/task.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/runner/src/runner.rs
crates/core/terminal/src/theme.rs
nextgen/project-builder/src/project_builder.rs
nextgen/project-expander/src/tasks_expander.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project/src/project.rs
nextgen/task-builder/src/tasks_builder.rs
packages/cli/CHANGELOG.md
website/docs/commands/query/projects.mdx
website/docs/commands/query/tasks.mdx

@github-actions
Copy link

Run report for 636e81f1 (ubuntu-latest, 18)

Total time: 4m 18s | Comparison time: 7m 37s | Estimated savings: 3m 18s (43.4% faster)

Action Time Status Info
🟩 SetupNodeTool(18.18.0) 15.2s Passed
🟩 SyncNodeProject(types) 391.7ms Passed
🟩 InstallNodeDeps(18.18.0) 1m 20s Passed
🟦 RunTarget(types:build) 1.4s Cached
🟩 SyncNodeProject(runtime) 488ms Passed
🟩 SyncNodeProject(website) 610.8ms Passed
🟩 SyncNodeProject(report) 416.4ms Passed
🟦 RunTarget(runtime:build) 938.2ms Cached
🟩 SyncWorkspace 405.1ms Passed
🟦 RunTarget(website:typecheck) 1.3s Cached
🟦 RunTarget(website:test) 1.7s Cached
🟦 RunTarget(website:lint) 1.6s Cached
🟩 RunTarget(website:format) 10.1s Passed
🟦 RunTarget(report:typecheck) 10.1s Cached
🟦 RunTarget(report:test) 1.6s Cached
🟦 RunTarget(report:lint) 1.6s Cached
🟩 RunTarget(report:format) 1.9s Passed
🟦 RunTarget(report:build) 2.1s Cached
🟦 RunTarget(runtime:typecheck) 1.7s Cached
🟦 RunTarget(runtime:test) 1.6s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.6s Cached
🟩 RunTarget(runtime:format) 1.7s Passed
🟩 RunTarget(website:build) 2m 21s Passed SLOW
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.18.0
Touched files
crates/cli/src/commands/task.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/runner/src/runner.rs
crates/core/terminal/src/theme.rs
nextgen/project-builder/src/project_builder.rs
nextgen/project-expander/src/tasks_expander.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project/src/project.rs
nextgen/task-builder/src/tasks_builder.rs
packages/cli/CHANGELOG.md
website/docs/commands/query/projects.mdx
website/docs/commands/query/tasks.mdx

@github-actions
Copy link

Run report for 636e81f1 (windows-latest, 18)

Total time: 2m 46s | Comparison time: 7m 45s | Estimated savings: 4m 58s (64.2% faster)

Action Time Status Info
🟩 SetupNodeTool(18.18.0) 25.2s Passed
🟩 SyncNodeProject(types) 332.8ms Passed
🟩 InstallNodeDeps(18.18.0) 1m 48s Passed
🟦 RunTarget(types:build) 1.9s Cached
🟩 SyncNodeProject(runtime) 407.1ms Passed
🟩 SyncNodeProject(website) 485.8ms Passed
🟩 SyncNodeProject(report) 331.9ms Passed
🟦 RunTarget(runtime:build) 857.2ms Cached
🟩 SyncWorkspace 319.6ms Passed
🟦 RunTarget(website:typecheck) 1s Cached
🟦 RunTarget(website:test) 1.4s Cached
🟦 RunTarget(website:lint) 1.4s Cached
🟩 RunTarget(website:format) 11.7s Passed
🟦 RunTarget(report:typecheck) 11.8s Cached
🟦 RunTarget(report:test) 1.5s Cached
🟦 RunTarget(report:lint) 1.5s Cached
🟩 RunTarget(report:format) 2.1s Passed
🟦 RunTarget(report:build) 2.1s Cached
🟦 RunTarget(runtime:typecheck) 1.4s Cached
🟦 RunTarget(runtime:test) 1.3s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.3s Cached
🟩 RunTarget(runtime:format) 1.7s Passed
🟦 RunTarget(website:build) 10s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.18.0
Touched files
crates/cli/src/commands/task.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/runner/src/runner.rs
crates/core/terminal/src/theme.rs
nextgen/project-builder/src/project_builder.rs
nextgen/project-expander/src/tasks_expander.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project/src/project.rs
nextgen/task-builder/src/tasks_builder.rs
packages/cli/CHANGELOG.md
website/docs/commands/query/projects.mdx
website/docs/commands/query/tasks.mdx

@github-actions
Copy link

Run report for 636e81f1 (ubuntu-latest, 16)

Total time: 4m 49s | Comparison time: 7m 50s | Estimated savings: 3m (38.4% faster)

Action Time Status Info
🟩 SetupNodeTool(16.20.2) 17.3s Passed
🟩 SyncNodeProject(types) 510.5ms Passed
🟩 InstallNodeDeps(16.20.2) 1m 27s Passed
🟦 RunTarget(types:build) 1.2s Cached
🟩 SyncNodeProject(runtime) 609.1ms Passed
🟩 SyncNodeProject(website) 508.7ms Passed
🟩 SyncNodeProject(report) 517.2ms Passed
🟦 RunTarget(runtime:build) 722.5ms Cached
🟩 SyncWorkspace 497.8ms Passed
🟦 RunTarget(website:typecheck) 1.2s Cached
🟦 RunTarget(website:test) 1.4s Cached
🟦 RunTarget(website:lint) 1.5s Cached
🟩 RunTarget(website:format) 10.7s Passed
🟦 RunTarget(report:typecheck) 10.6s Cached
🟦 RunTarget(report:test) 1.3s Cached
🟦 RunTarget(report:lint) 1.3s Cached
🟩 RunTarget(report:format) 1.9s Passed
🟦 RunTarget(report:build) 2s Cached
🟦 RunTarget(runtime:typecheck) 1.4s Cached
🟦 RunTarget(runtime:test) 1.3s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.2s Cached
🟩 RunTarget(runtime:format) 1.7s Passed
🟩 RunTarget(website:build) 2m 43s Passed SLOW
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 16

Variables:

MOON_NODE_VERSION = 16.20.2
Touched files
crates/cli/src/commands/task.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/runner/src/runner.rs
crates/core/terminal/src/theme.rs
nextgen/project-builder/src/project_builder.rs
nextgen/project-expander/src/tasks_expander.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project/src/project.rs
nextgen/task-builder/src/tasks_builder.rs
packages/cli/CHANGELOG.md
website/docs/commands/query/projects.mdx
website/docs/commands/query/tasks.mdx

@github-actions
Copy link

Run report for 636e81f1 (windows-latest, 20)

Total time: 2m 21s | Comparison time: 6m 21s | Estimated savings: 4m (63.0% faster)

Action Time Status Info
🟩 SetupNodeTool(20.7.0) 19.2s Passed
🟩 SyncNodeProject(types) 301.2ms Passed
🟩 InstallNodeDeps(20.7.0) 1m 36s Passed
🟦 RunTarget(types:build) 1.3s Cached
🟩 SyncNodeProject(runtime) 405ms Passed
🟩 SyncNodeProject(website) 286.7ms Passed
🟩 SyncNodeProject(report) 286.9ms Passed
🟦 RunTarget(runtime:build) 827.4ms Cached
🟩 SyncWorkspace 299.1ms Passed
🟦 RunTarget(website:typecheck) 971.9ms Cached
🟦 RunTarget(website:test) 1.4s Cached
🟦 RunTarget(website:lint) 1.4s Cached
🟩 RunTarget(website:format) 9.5s Passed
🟦 RunTarget(report:typecheck) 9.5s Cached
🟦 RunTarget(report:test) 1.4s Cached
🟦 RunTarget(report:lint) 1.4s Cached
🟩 RunTarget(report:format) 1.8s Passed
🟦 RunTarget(report:build) 1.9s Cached
🟦 RunTarget(runtime:typecheck) 1.4s Cached
🟦 RunTarget(runtime:test) 1.3s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.5s Cached
🟩 RunTarget(runtime:format) 1.7s Passed
🟦 RunTarget(website:build) 5.8s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.7.0
Touched files
crates/cli/src/commands/task.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/runner/src/runner.rs
crates/core/terminal/src/theme.rs
nextgen/project-builder/src/project_builder.rs
nextgen/project-expander/src/tasks_expander.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project/src/project.rs
nextgen/task-builder/src/tasks_builder.rs
packages/cli/CHANGELOG.md
website/docs/commands/query/projects.mdx
website/docs/commands/query/tasks.mdx

@github-actions
Copy link

Run report for 636e81f1 (windows-latest, 16)

Total time: 2m 49s | Comparison time: 7m 51s | Estimated savings: 5m 1s (64.0% faster)

Action Time Status Info
🟩 SetupNodeTool(16.20.2) 20.6s Passed
🟩 SyncNodeProject(types) 309.5ms Passed
🟩 InstallNodeDeps(16.20.2) 1m 56s Passed
🟦 RunTarget(types:build) 1.5s Cached
🟩 SyncNodeProject(runtime) 356.9ms Passed
🟩 SyncNodeProject(website) 299.5ms Passed
🟩 SyncNodeProject(report) 299.8ms Passed
🟦 RunTarget(runtime:build) 1.3s Cached
🟩 SyncWorkspace 314.6ms Passed
🟦 RunTarget(website:typecheck) 999.9ms Cached
🟦 RunTarget(website:test) 1.4s Cached
🟦 RunTarget(website:lint) 1.4s Cached
🟩 RunTarget(website:format) 12.5s Passed
🟦 RunTarget(report:typecheck) 13.3s Cached
🟦 RunTarget(report:test) 2.3s Cached
🟦 RunTarget(report:lint) 1.4s Cached
🟩 RunTarget(report:format) 2.2s Passed
🟦 RunTarget(report:build) 2.2s Cached
🟦 RunTarget(runtime:typecheck) 1.6s Cached
🟦 RunTarget(runtime:test) 1.8s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.6s Cached
🟩 RunTarget(runtime:format) 1.7s Passed
🟦 RunTarget(website:build) 6.8s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 16

Variables:

MOON_NODE_VERSION = 16.20.2
Touched files
crates/cli/src/commands/task.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/runner/src/runner.rs
crates/core/terminal/src/theme.rs
nextgen/project-builder/src/project_builder.rs
nextgen/project-expander/src/tasks_expander.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project/src/project.rs
nextgen/task-builder/src/tasks_builder.rs
packages/cli/CHANGELOG.md
website/docs/commands/query/projects.mdx
website/docs/commands/query/tasks.mdx

@milesj milesj merged commit 40a6aae into master Sep 28, 2023
25 checks passed
@milesj milesj deleted the fix-1079 branch September 28, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[bug] query projects stack overflow
1 participant