Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Update moon dep-graph to support task by path. #1084

Merged
merged 6 commits into from
Sep 29, 2023
Merged

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Sep 29, 2023

Fixes #1076

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Run report for 118ea4e6 (ubuntu-latest, 16)

Total time: 1m 58s | Comparison time: 6m 16s | Estimated savings: 4m 18s (68.5% faster)

Action Time Status Info
🟩 SetupNodeTool(16.20.2) 15.3s Passed
🟩 SyncNodeProject(types) 454.1ms Passed
🟩 InstallNodeDeps(16.20.2) 1m 16s Passed
🟦 RunTarget(types:build) 1.4s Cached
🟩 SyncNodeProject(runtime) 551.4ms Passed
🟩 SyncNodeProject(website) 453.9ms Passed
🟩 SyncNodeProject(report) 460.5ms Passed
🟦 RunTarget(runtime:build) 964.2ms Cached
🟩 SyncWorkspace 443.5ms Passed
🟦 RunTarget(website:typecheck) 1.3s Cached
🟦 RunTarget(website:test) 1.6s Cached
🟦 RunTarget(website:lint) 1.7s Cached
🟩 RunTarget(website:format) 9.2s Passed
🟦 RunTarget(report:typecheck) 9.2s Cached
🟦 RunTarget(report:test) 1.7s Cached
🟦 RunTarget(report:lint) 1.6s Cached
🟩 RunTarget(report:format) 2s Passed
🟦 RunTarget(report:build) 2s Cached
🟦 RunTarget(runtime:typecheck) 1.6s Cached
🟦 RunTarget(runtime:test) 1.7s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.6s Cached
🟩 RunTarget(runtime:format) 1.7s Passed
🟦 RunTarget(website:build) 5.9s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 16

Variables:

MOON_NODE_VERSION = 16.20.2
Touched files
.yarn/versions/41ec5248.yml
crates/cli/src/commands/check.rs
crates/cli/src/commands/generate.rs
crates/cli/src/commands/graph/dep.rs
crates/cli/src/commands/init/mod.rs
crates/cli/src/commands/run.rs
crates/cli/src/commands/task.rs
crates/cli/tests/dep_graph_test.rs
crates/cli/tests/snapshots/dep_graph_test__focused_by_task_in_cwd.snap
crates/core/action-context/src/lib.rs
crates/core/action-pipeline/src/processor.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/moon/src/lib.rs
crates/core/runner/src/runner.rs
nextgen/process/src/command_inspector.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project-graph/tests/project_graph_test.rs
nextgen/target/src/lib.rs
nextgen/target/src/target.rs
nextgen/target/src/target_locator.rs
nextgen/target/tests/target_test.rs
nextgen/task/src/task.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Run report for 118ea4e6 (ubuntu-latest, 18)

Total time: 2m 4s | Comparison time: 6m 26s | Estimated savings: 4m 21s (67.7% faster)

Action Time Status Info
🟩 SetupNodeTool(18.18.0) 16.5s Passed
🟩 SyncNodeProject(types) 461.8ms Passed
🟩 InstallNodeDeps(18.18.0) 1m 20s Passed
🟦 RunTarget(types:build) 1.4s Cached
🟩 SyncNodeProject(runtime) 582.9ms Passed
🟩 SyncNodeProject(website) 448.7ms Passed
🟩 SyncNodeProject(report) 465.8ms Passed
🟦 RunTarget(runtime:build) 887.6ms Cached
🟩 SyncWorkspace 426.9ms Passed
🟦 RunTarget(website:typecheck) 1.3s Cached
🟦 RunTarget(website:test) 1.7s Cached
🟦 RunTarget(website:lint) 1.6s Cached
🟩 RunTarget(website:format) 10.1s Passed
🟦 RunTarget(report:typecheck) 10.1s Cached
🟦 RunTarget(report:test) 1.6s Cached
🟦 RunTarget(report:lint) 1.6s Cached
🟩 RunTarget(report:format) 2s Passed
🟦 RunTarget(report:build) 2s Cached
🟦 RunTarget(runtime:typecheck) 1.6s Cached
🟦 RunTarget(runtime:test) 1.7s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.6s Cached
🟩 RunTarget(runtime:format) 1.8s Passed
🟦 RunTarget(website:build) 5.6s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.18.0
Touched files
.yarn/versions/41ec5248.yml
crates/cli/src/commands/check.rs
crates/cli/src/commands/generate.rs
crates/cli/src/commands/graph/dep.rs
crates/cli/src/commands/init/mod.rs
crates/cli/src/commands/run.rs
crates/cli/src/commands/task.rs
crates/cli/tests/dep_graph_test.rs
crates/cli/tests/snapshots/dep_graph_test__focused_by_task_in_cwd.snap
crates/core/action-context/src/lib.rs
crates/core/action-pipeline/src/processor.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/moon/src/lib.rs
crates/core/runner/src/runner.rs
nextgen/process/src/command_inspector.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project-graph/tests/project_graph_test.rs
nextgen/target/src/lib.rs
nextgen/target/src/target.rs
nextgen/target/src/target_locator.rs
nextgen/target/tests/target_test.rs
nextgen/task/src/task.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Run report for 118ea4e6 (windows-latest, 16)

Total time: 2m 21s | Comparison time: 6m 31s | Estimated savings: 4m 10s (64.0% faster)

Action Time Status Info
🟩 SetupNodeTool(16.20.2) 17.7s Passed
🟩 SyncNodeProject(types) 441.1ms Passed
🟩 InstallNodeDeps(16.20.2) 1m 36s Passed
🟦 RunTarget(types:build) 1.3s Cached
🟩 SyncNodeProject(runtime) 496ms Passed
🟩 SyncNodeProject(website) 428.8ms Passed
🟩 SyncNodeProject(report) 429.1ms Passed
🟦 RunTarget(runtime:build) 822ms Cached
🟩 SyncWorkspace 392.8ms Passed
🟦 RunTarget(website:typecheck) 1s Cached
🟦 RunTarget(website:test) 1.3s Cached
🟦 RunTarget(website:lint) 1.4s Cached
🟩 RunTarget(website:format) 9.6s Passed
🟦 RunTarget(report:typecheck) 9.6s Cached
🟦 RunTarget(report:test) 1.4s Cached
🟦 RunTarget(report:lint) 1.4s Cached
🟩 RunTarget(report:format) 2.1s Passed
🟦 RunTarget(report:build) 2s Cached
🟦 RunTarget(runtime:typecheck) 1.4s Cached
🟦 RunTarget(runtime:test) 1.4s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.3s Cached
🟩 RunTarget(runtime:format) 1.7s Passed
🟦 RunTarget(website:build) 6.9s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 16

Variables:

MOON_NODE_VERSION = 16.20.2
Touched files
.yarn/versions/41ec5248.yml
crates/cli/src/commands/check.rs
crates/cli/src/commands/generate.rs
crates/cli/src/commands/graph/dep.rs
crates/cli/src/commands/init/mod.rs
crates/cli/src/commands/run.rs
crates/cli/src/commands/task.rs
crates/cli/tests/dep_graph_test.rs
crates/cli/tests/snapshots/dep_graph_test__focused_by_task_in_cwd.snap
crates/core/action-context/src/lib.rs
crates/core/action-pipeline/src/processor.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/moon/src/lib.rs
crates/core/runner/src/runner.rs
nextgen/process/src/command_inspector.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project-graph/tests/project_graph_test.rs
nextgen/target/src/lib.rs
nextgen/target/src/target.rs
nextgen/target/src/target_locator.rs
nextgen/target/tests/target_test.rs
nextgen/task/src/task.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Run report for 118ea4e6 (windows-latest, 18)

Total time: 3m 21s | Comparison time: 8m 21s | Estimated savings: 4m 59s (59.8% faster)

Action Time Status Info
🟩 SetupNodeTool(18.18.0) 30.7s Passed
🟩 SyncNodeProject(types) 320.1ms Passed
🟩 InstallNodeDeps(18.18.0) 2m 18s Passed SLOW
🟦 RunTarget(types:build) 1.8s Cached
🟩 SyncNodeProject(runtime) 1.8s Passed
🟩 SyncNodeProject(website) 456.3ms Passed
🟩 SyncNodeProject(report) 310.8ms Passed
🟦 RunTarget(runtime:build) 856.8ms Cached
🟩 SyncWorkspace 356.9ms Passed
🟦 RunTarget(website:typecheck) 1.1s Cached
🟦 RunTarget(website:test) 1.5s Cached
🟦 RunTarget(website:lint) 1.4s Cached
🟩 RunTarget(website:format) 12.9s Passed
🟦 RunTarget(report:typecheck) 13s Cached
🟦 RunTarget(report:test) 1.5s Cached
🟦 RunTarget(report:lint) 1.4s Cached
🟩 RunTarget(report:format) 2.3s Passed
🟦 RunTarget(report:build) 2.4s Cached
🟦 RunTarget(runtime:typecheck) 1.5s Cached
🟦 RunTarget(runtime:test) 1.4s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.5s Cached
🟩 RunTarget(runtime:format) 2s Passed
🟦 RunTarget(website:build) 8s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.18.0
Touched files
.yarn/versions/41ec5248.yml
crates/cli/src/commands/check.rs
crates/cli/src/commands/generate.rs
crates/cli/src/commands/graph/dep.rs
crates/cli/src/commands/init/mod.rs
crates/cli/src/commands/run.rs
crates/cli/src/commands/task.rs
crates/cli/tests/dep_graph_test.rs
crates/cli/tests/snapshots/dep_graph_test__focused_by_task_in_cwd.snap
crates/core/action-context/src/lib.rs
crates/core/action-pipeline/src/processor.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/moon/src/lib.rs
crates/core/runner/src/runner.rs
nextgen/process/src/command_inspector.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project-graph/tests/project_graph_test.rs
nextgen/target/src/lib.rs
nextgen/target/src/target.rs
nextgen/target/src/target_locator.rs
nextgen/target/tests/target_test.rs
nextgen/task/src/task.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Run report for 118ea4e6 (windows-latest, 20)

Total time: 2m 46s | Comparison time: 6m 41s | Estimated savings: 3m 55s (58.5% faster)

Action Time Status Info
🟩 SetupNodeTool(20.8.0) 25.8s Passed
🟩 SyncNodeProject(types) 412.9ms Passed
🟩 InstallNodeDeps(20.8.0) 1m 54s Passed
🟦 RunTarget(types:build) 1.2s Cached
🟩 SyncNodeProject(runtime) 495.5ms Passed
🟩 SyncNodeProject(website) 582.4ms Passed
🟩 SyncNodeProject(report) 389.4ms Passed
🟦 RunTarget(runtime:build) 678.5ms Cached
🟩 SyncWorkspace 386.8ms Passed
🟦 RunTarget(website:typecheck) 884.2ms Cached
🟦 RunTarget(website:test) 1s Cached
🟦 RunTarget(website:lint) 1.1s Cached
🟩 RunTarget(website:format) 10.6s Passed
🟦 RunTarget(report:typecheck) 10.8s Cached
🟦 RunTarget(report:test) 1.2s Cached
🟦 RunTarget(report:lint) 1s Cached
🟩 RunTarget(report:format) 1.9s Passed
🟦 RunTarget(report:build) 1.9s Cached
🟦 RunTarget(runtime:typecheck) 949.3ms Cached
🟦 RunTarget(runtime:test) 940.1ms Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 974.6ms Cached
🟩 RunTarget(runtime:format) 1.8s Passed
🟦 RunTarget(website:build) 6.8s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.8.0
Touched files
.yarn/versions/41ec5248.yml
crates/cli/src/commands/check.rs
crates/cli/src/commands/generate.rs
crates/cli/src/commands/graph/dep.rs
crates/cli/src/commands/init/mod.rs
crates/cli/src/commands/run.rs
crates/cli/src/commands/task.rs
crates/cli/tests/dep_graph_test.rs
crates/cli/tests/snapshots/dep_graph_test__focused_by_task_in_cwd.snap
crates/core/action-context/src/lib.rs
crates/core/action-pipeline/src/processor.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/moon/src/lib.rs
crates/core/runner/src/runner.rs
nextgen/process/src/command_inspector.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project-graph/tests/project_graph_test.rs
nextgen/target/src/lib.rs
nextgen/target/src/target.rs
nextgen/target/src/target_locator.rs
nextgen/target/tests/target_test.rs
nextgen/task/src/task.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Run report for 118ea4e6 (ubuntu-latest, 20)

Total time: 2m 18s | Comparison time: 6m 19s | Estimated savings: 4m (63.4% faster)

Action Time Status Info
🟩 SetupNodeTool(20.8.0) 18.8s Passed
🟩 SyncNodeProject(types) 604.6ms Passed
🟩 InstallNodeDeps(20.8.0) 1m 34s Passed
🟦 RunTarget(types:build) 1.4s Cached
🟩 SyncNodeProject(runtime) 748.7ms Passed
🟩 SyncNodeProject(website) 497.5ms Passed
🟩 SyncNodeProject(report) 502.1ms Passed
🟦 RunTarget(runtime:build) 688ms Cached
🟩 SyncWorkspace 486.9ms Passed
🟦 RunTarget(website:typecheck) 1.3s Cached
🟦 RunTarget(website:test) 1.5s Cached
🟦 RunTarget(website:lint) 1.5s Cached
🟩 RunTarget(website:format) 10.1s Passed
🟦 RunTarget(report:typecheck) 10s Cached
🟦 RunTarget(report:test) 1.4s Cached
🟦 RunTarget(report:lint) 1.3s Cached
🟩 RunTarget(report:format) 2.3s Passed
🟦 RunTarget(report:build) 2.3s Cached
🟦 RunTarget(runtime:typecheck) 1.2s Cached
🟦 RunTarget(runtime:test) 1.2s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.2s Cached
🟩 RunTarget(runtime:format) 1.6s Passed
🟦 RunTarget(website:build) 5.2s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.8.0
Touched files
.yarn/versions/41ec5248.yml
crates/cli/src/commands/check.rs
crates/cli/src/commands/generate.rs
crates/cli/src/commands/graph/dep.rs
crates/cli/src/commands/init/mod.rs
crates/cli/src/commands/run.rs
crates/cli/src/commands/task.rs
crates/cli/tests/dep_graph_test.rs
crates/cli/tests/snapshots/dep_graph_test__focused_by_task_in_cwd.snap
crates/core/action-context/src/lib.rs
crates/core/action-pipeline/src/processor.rs
crates/core/dep-graph/src/dep_builder.rs
crates/core/moon/src/lib.rs
crates/core/runner/src/runner.rs
nextgen/process/src/command_inspector.rs
nextgen/project-graph/src/project_graph.rs
nextgen/project-graph/src/project_graph_builder.rs
nextgen/project-graph/tests/project_graph_test.rs
nextgen/target/src/lib.rs
nextgen/target/src/target.rs
nextgen/target/src/target_locator.rs
nextgen/target/tests/target_test.rs
nextgen/task/src/task.rs
packages/cli/CHANGELOG.md

@milesj milesj merged commit 7865ed2 into master Sep 29, 2023
25 checks passed
@milesj milesj deleted the target-locator branch September 29, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[bug] moon dep-graph behavior is inconsistent with moon run
1 participant