Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix upper/lower case for codegen. #1090

Merged
merged 1 commit into from
Oct 1, 2023
Merged

fix: Fix upper/lower case for codegen. #1090

merged 1 commit into from
Oct 1, 2023

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Oct 1, 2023

The casing functions would remove chars like - since it tries to convert it. This is unexpected.

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Run report for a8b33faf (ubuntu-latest, 20)

Total time: 2m | Comparison time: 6m 11s | Estimated savings: 4m 10s (67.5% faster)

Action Time Status Info
🟩 SetupNodeTool(20.8.0) 15.2s Passed
🟩 SyncNodeProject(types) 420.2ms Passed
🟩 InstallNodeDeps(20.8.0) 1m 19s Passed
🟦 RunTarget(types:build) 1.3s Cached
🟩 SyncNodeProject(runtime) 482.4ms Passed
🟩 SyncNodeProject(website) 416ms Passed
🟩 SyncNodeProject(report) 423.2ms Passed
🟦 RunTarget(runtime:build) 878.4ms Cached
🟩 SyncWorkspace 454ms Passed
🟦 RunTarget(website:typecheck) 1.3s Cached
🟦 RunTarget(website:test) 1.7s Cached
🟦 RunTarget(website:lint) 1.7s Cached
🟩 RunTarget(website:format) 9.2s Passed
🟦 RunTarget(report:typecheck) 9.2s Cached
🟦 RunTarget(report:test) 1.6s Cached
🟦 RunTarget(report:lint) 1.6s Cached
🟩 RunTarget(report:format) 2s Passed
🟦 RunTarget(report:build) 2s Cached
🟦 RunTarget(runtime:typecheck) 1.6s Cached
🟦 RunTarget(runtime:test) 1.5s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.5s Cached
🟩 RunTarget(runtime:format) 1.6s Passed
🟦 RunTarget(website:build) 5.5s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.8.0
Touched files
nextgen/codegen/src/filters.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Run report for a8b33faf (ubuntu-latest, 16)

Total time: 2m 6s | Comparison time: 7m 25s | Estimated savings: 5m 18s (71.5% faster)

Action Time Status Info
🟩 SetupNodeTool(16.20.2) 16.1s Passed
🟩 SyncNodeProject(types) 557.3ms Passed
🟩 InstallNodeDeps(16.20.2) 1m 20s Passed
🟦 RunTarget(types:build) 1.5s Cached
🟩 SyncNodeProject(runtime) 764.3ms Passed
🟩 SyncNodeProject(website) 799ms Passed
🟩 SyncNodeProject(report) 805.6ms Passed
🟦 RunTarget(runtime:build) 804.3ms Cached
🟩 SyncWorkspace 528.4ms Passed
🟦 RunTarget(website:typecheck) 1.3s Cached
🟦 RunTarget(website:test) 1.5s Cached
🟦 RunTarget(website:lint) 1.6s Cached
🟩 RunTarget(website:format) 8.5s Passed
🟦 RunTarget(report:typecheck) 8.5s Cached
🟦 RunTarget(report:test) 6.6s Cached
🟦 RunTarget(report:lint) 6.5s Cached
🟩 RunTarget(report:format) 2s Passed
🟦 RunTarget(report:build) 2.1s Cached
🟦 RunTarget(runtime:typecheck) 1.6s Cached
🟦 RunTarget(runtime:test) 1.5s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.6s Cached
🟩 RunTarget(runtime:format) 1.9s Passed
🟦 RunTarget(website:build) 4.7s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 16

Variables:

MOON_NODE_VERSION = 16.20.2
Touched files
nextgen/codegen/src/filters.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Run report for a8b33faf (ubuntu-latest, 18)

Total time: 2m 36s | Comparison time: 7m 17s | Estimated savings: 4m 40s (64.1% faster)

Action Time Status Info
🟩 SetupNodeTool(18.18.0) 20.8s Passed
🟩 SyncNodeProject(types) 513ms Passed
🟩 InstallNodeDeps(18.18.0) 1m 45s Passed
🟦 RunTarget(types:build) 1.4s Cached
🟩 SyncNodeProject(runtime) 600.9ms Passed
🟩 SyncNodeProject(website) 503.1ms Passed
🟩 SyncNodeProject(report) 512.1ms Passed
🟦 RunTarget(runtime:build) 825.7ms Cached
🟩 SyncWorkspace 528.6ms Passed
🟦 RunTarget(website:typecheck) 1.3s Cached
🟦 RunTarget(website:test) 1.6s Cached
🟦 RunTarget(website:lint) 1.6s Cached
🟩 RunTarget(website:format) 12s Passed
🟦 RunTarget(report:typecheck) 12s Cached
🟦 RunTarget(report:test) 1.6s Cached
🟦 RunTarget(report:lint) 1.5s Cached
🟩 RunTarget(report:format) 2.3s Passed
🟦 RunTarget(report:build) 2.4s Cached
🟦 RunTarget(runtime:typecheck) 1.7s Cached
🟦 RunTarget(runtime:test) 1.6s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.5s Cached
🟩 RunTarget(runtime:format) 2s Passed
🟦 RunTarget(website:build) 6s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.18.0
Touched files
nextgen/codegen/src/filters.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Run report for a8b33faf (windows-latest, 16)

Total time: 2m 24s | Comparison time: 6m 36s | Estimated savings: 4m 12s (63.7% faster)

Action Time Status Info
🟩 SetupNodeTool(16.20.2) 20.5s Passed
🟩 SyncNodeProject(types) 315.4ms Passed
🟩 InstallNodeDeps(16.20.2) 1m 36s Passed
🟦 RunTarget(types:build) 1.2s Cached
🟩 SyncNodeProject(runtime) 392.9ms Passed
🟩 SyncNodeProject(website) 301.3ms Passed
🟩 SyncNodeProject(report) 301.4ms Passed
🟦 RunTarget(runtime:build) 851.1ms Cached
🟩 SyncWorkspace 303.9ms Passed
🟦 RunTarget(website:typecheck) 993.9ms Cached
🟦 RunTarget(website:test) 1.4s Cached
🟦 RunTarget(website:lint) 1.4s Cached
🟩 RunTarget(website:format) 9.6s Passed
🟦 RunTarget(report:typecheck) 9.6s Cached
🟦 RunTarget(report:test) 1.4s Cached
🟦 RunTarget(report:lint) 1.4s Cached
🟩 RunTarget(report:format) 1.9s Passed
🟦 RunTarget(report:build) 1.9s Cached
🟦 RunTarget(runtime:typecheck) 1.4s Cached
🟦 RunTarget(runtime:test) 1.3s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.3s Cached
🟩 RunTarget(runtime:format) 1.7s Passed
🟦 RunTarget(website:build) 7.4s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 16

Variables:

MOON_NODE_VERSION = 16.20.2
Touched files
nextgen/codegen/src/filters.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Run report for a8b33faf (windows-latest, 20)

Total time: 3m 26s | Comparison time: 7m 36s | Estimated savings: 4m 9s (54.7% faster)

Action Time Status Info
🟩 SetupNodeTool(20.8.0) 22.8s Passed
🟩 SyncNodeProject(types) 314.9ms Passed
🟩 InstallNodeDeps(20.8.0) 2m 36s Passed SLOW
🟦 RunTarget(types:build) 1.2s Cached
🟩 SyncNodeProject(runtime) 334.9ms Passed
🟩 SyncNodeProject(website) 274.4ms Passed
🟩 SyncNodeProject(report) 274.6ms Passed
🟦 RunTarget(runtime:build) 826.9ms Cached
🟩 SyncWorkspace 286.4ms Passed
🟦 RunTarget(website:typecheck) 943.7ms Cached
🟦 RunTarget(website:test) 1.3s Cached
🟦 RunTarget(website:lint) 1.3s Cached
🟩 RunTarget(website:format) 8.9s Passed
🟦 RunTarget(report:typecheck) 8.9s Cached
🟦 RunTarget(report:test) 1.4s Cached
🟦 RunTarget(report:lint) 1.3s Cached
🟩 RunTarget(report:format) 1.8s Passed
🟦 RunTarget(report:build) 1.8s Cached
🟦 RunTarget(runtime:typecheck) 1.3s Cached
🟦 RunTarget(runtime:test) 1.3s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.3s Cached
🟩 RunTarget(runtime:format) 1.5s Passed
🟦 RunTarget(website:build) 8.3s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.8.0
Touched files
nextgen/codegen/src/filters.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Run report for a8b33faf (windows-latest, 18)

Total time: 2m 26s | Comparison time: 6m 28s | Estimated savings: 4m 1s (62.3% faster)

Action Time Status Info
🟩 SetupNodeTool(18.18.0) 20.7s Passed
🟩 SyncNodeProject(types) 301.7ms Passed
🟩 InstallNodeDeps(18.18.0) 1m 39s Passed
🟦 RunTarget(types:build) 1.5s Cached
🟩 SyncNodeProject(runtime) 365.1ms Passed
🟩 SyncNodeProject(website) 345.3ms Passed
🟩 SyncNodeProject(report) 346ms Passed
🟦 RunTarget(runtime:build) 816.6ms Cached
🟩 SyncWorkspace 326.3ms Passed
🟦 RunTarget(website:typecheck) 985.9ms Cached
🟦 RunTarget(website:test) 1.3s Cached
🟦 RunTarget(website:lint) 1.3s Cached
🟩 RunTarget(website:format) 9.9s Passed
🟦 RunTarget(report:typecheck) 9.9s Cached
🟦 RunTarget(report:test) 1.3s Cached
🟦 RunTarget(report:lint) 1.4s Cached
🟩 RunTarget(report:format) 1.8s Passed
🟦 RunTarget(report:build) 1.8s Cached
🟦 RunTarget(runtime:typecheck) 1.3s Cached
🟦 RunTarget(runtime:test) 1.3s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.3s Cached
🟩 RunTarget(runtime:format) 1.7s Passed
🟦 RunTarget(website:build) 5.8s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.18.0
Touched files
nextgen/codegen/src/filters.rs
packages/cli/CHANGELOG.md

@milesj milesj merged commit 7073b97 into master Oct 1, 2023
25 checks passed
@milesj milesj deleted the fix-codegen-casing branch October 1, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant