Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Implement a new action graph. #1093

Merged
merged 22 commits into from
Oct 6, 2023
Merged
Prev Previous commit
Fix test.
  • Loading branch information
milesj committed Oct 6, 2023
commit ddc0e98440558833504f7ea99a6e3388bc3af7ca
4 changes: 2 additions & 2 deletions crates/core/dep-graph/tests/dep_graph_test.rs
Original file line number Diff line number Diff line change
@@ -262,11 +262,11 @@ mod run_target {
vec![NodeIndex::new(1)],
vec![
NodeIndex::new(2),
NodeIndex::new(5),
NodeIndex::new(4),
NodeIndex::new(6),
NodeIndex::new(7)
],
vec![NodeIndex::new(4), NodeIndex::new(12), NodeIndex::new(13)],
vec![NodeIndex::new(5), NodeIndex::new(12), NodeIndex::new(13)],
vec![NodeIndex::new(3), NodeIndex::new(11)],
vec![NodeIndex::new(0)],
vec![
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@ digraph {
1 [ label="SetupNodeTool(16.0.0)" style=filled, shape=oval, fillcolor=gray, fontcolor=black]
2 [ label="InstallNodeDeps(16.0.0)" style=filled, shape=oval, fillcolor=gray, fontcolor=black]
3 [ label="SyncNodeProject(persistent)" style=filled, shape=oval, fillcolor=gray, fontcolor=black]
4 [ label="SyncNodeProject(buildA)" style=filled, shape=oval, fillcolor=gray, fontcolor=black]
5 [ label="SyncNodeProject(buildC)" style=filled, shape=oval, fillcolor=gray, fontcolor=black]
4 [ label="SyncNodeProject(buildC)" style=filled, shape=oval, fillcolor=gray, fontcolor=black]
5 [ label="SyncNodeProject(buildA)" style=filled, shape=oval, fillcolor=gray, fontcolor=black]
6 [ label="SyncNodeProject(basic)" style=filled, shape=oval, fillcolor=gray, fontcolor=black]
7 [ label="SyncNodeProject(noTasks)" style=filled, shape=oval, fillcolor=gray, fontcolor=black]
8 [ label="RunPersistentTarget(persistent:dev)" style=filled, shape=oval, fillcolor=gray, fontcolor=black]
@@ -21,13 +21,13 @@ digraph {
2 -> 1 [ arrowhead=box, arrowtail=box]
3 -> 1 [ arrowhead=box, arrowtail=box]
4 -> 1 [ arrowhead=box, arrowtail=box]
3 -> 4 [ arrowhead=box, arrowtail=box]
5 -> 1 [ arrowhead=box, arrowtail=box]
4 -> 5 [ arrowhead=box, arrowtail=box]
5 -> 4 [ arrowhead=box, arrowtail=box]
6 -> 1 [ arrowhead=box, arrowtail=box]
4 -> 6 [ arrowhead=box, arrowtail=box]
5 -> 6 [ arrowhead=box, arrowtail=box]
7 -> 1 [ arrowhead=box, arrowtail=box]
4 -> 7 [ arrowhead=box, arrowtail=box]
3 -> 4 [ arrowhead=box, arrowtail=box]
5 -> 7 [ arrowhead=box, arrowtail=box]
3 -> 5 [ arrowhead=box, arrowtail=box]
8 -> 2 [ arrowhead=box, arrowtail=box]
8 -> 3 [ arrowhead=box, arrowtail=box]
@@ -36,11 +36,11 @@ digraph {
10 -> 2 [ arrowhead=box, arrowtail=box]
10 -> 3 [ arrowhead=box, arrowtail=box]
11 -> 2 [ arrowhead=box, arrowtail=box]
11 -> 4 [ arrowhead=box, arrowtail=box]
11 -> 5 [ arrowhead=box, arrowtail=box]
12 -> 2 [ arrowhead=box, arrowtail=box]
12 -> 6 [ arrowhead=box, arrowtail=box]
13 -> 2 [ arrowhead=box, arrowtail=box]
13 -> 5 [ arrowhead=box, arrowtail=box]
13 -> 4 [ arrowhead=box, arrowtail=box]
11 -> 12 [ arrowhead=box, arrowtail=box]
11 -> 13 [ arrowhead=box, arrowtail=box]
10 -> 11 [ arrowhead=box, arrowtail=box]
9 changes: 8 additions & 1 deletion packages/cli/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@
We're marking this as a breaking change as this could subtly introduce cycles in the project graph
that weren't present before, and for Node.js projects, this may inject `peerDependencies`.

#### 🚀 Updates
#### 🎉 Release

- Rewrote the dependency graph from the ground-up:
- Now known as the action graph.
@@ -50,6 +50,13 @@
current batch to complete.
- For large graphs, this should result in a significant performance improvement, upwards of 10x.
- Persistent tasks will still be ran as a batch, but since it's the last operation, it's fine.
- Released a new GitHub action,
[`moonrepo/setup-toolchain`](https://github.com/marketplace/actions/setup-proto-and-moon-toolchains),
that replaces both `setup-moon-action` and `setup-proto`.

#### 🚀 Updates

- Added a `moon action-graph` command and deprecated `moon dep-graph`.

#### 🐞 Fixes