Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Temporarily fix unknown cycle issue. #1097

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix: Temporarily fix unknown cycle issue. #1097

merged 3 commits into from
Oct 5, 2023

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Oct 5, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Run report for 887dd875 (ubuntu-latest, 16)

Total time: 2m 28s | Comparison time: 10m 18s | Estimated savings: 7m 49s (75.9% faster)

Action Time Status Info
🟩 SetupNodeTool(16.20.2) 21.4s Passed
🟩 SyncNodeProject(types) 4.4s Passed
🟩 InstallNodeDeps(16.20.2) 1m 18s Passed
🟦 RunTarget(types:build) 6.6s Cached
🟩 SyncNodeProject(runtime) 5.2s Passed
🟩 SyncNodeProject(website) 472.9ms Passed
🟩 SyncNodeProject(report) 473.1ms Passed
🟦 RunTarget(runtime:build) 2.7s Cached
🟩 SyncWorkspace 2.2s Passed
🟦 RunTarget(website:typecheck) 5.1s Cached
🟦 RunTarget(website:test) 3.9s Cached
🟦 RunTarget(website:lint) 1.8s Cached
🟩 RunTarget(website:format) 10.7s Passed
🟦 RunTarget(report:typecheck) 11.1s Cached
🟦 RunTarget(report:test) 2s Cached
🟦 RunTarget(report:lint) 1.6s Cached
🟩 RunTarget(report:format) 4.9s Passed
🟦 RunTarget(report:build) 5s Cached
🟦 RunTarget(runtime:typecheck) 2.1s Cached
🟦 RunTarget(runtime:test) 3.9s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 5.1s Cached
🟩 RunTarget(runtime:format) 4s Passed
🟦 RunTarget(website:build) 8.1s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 16

Variables:

MOON_NODE_VERSION = 16.20.2
Touched files
.yarn/versions/8aeb4131.yml
crates/cli/tests/snapshots/run_test__errors_for_cycle_in_task_deps.snap
crates/core/dep-graph/src/dep_graph.rs
crates/core/dep-graph/tests/dep_graph_test.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Run report for 887dd875 (windows-latest, 20)

Total time: 3m 7s | Comparison time: 8m 13s | Estimated savings: 5m 6s (62.1% faster)

Action Time Status Info
🟩 SetupNodeTool(20.8.0) 29s Passed
🟩 SyncNodeProject(types) 481.1ms Passed
🟩 InstallNodeDeps(20.8.0) 2m 3s Passed SLOW
🟦 RunTarget(types:build) 2.5s Cached
🟩 SyncNodeProject(runtime) 2.5s Passed
🟩 SyncNodeProject(website) 619ms Passed
🟩 SyncNodeProject(report) 619.4ms Passed
🟦 RunTarget(runtime:build) 1s Cached
🟩 SyncWorkspace 416.5ms Passed
🟦 RunTarget(website:typecheck) 979.4ms Cached
🟦 RunTarget(website:test) 1.2s Cached
🟦 RunTarget(website:lint) 1.5s Cached
🟩 RunTarget(website:format) 12s Passed
🟦 RunTarget(report:typecheck) 11.8s Cached
🟦 RunTarget(report:test) 1.5s Cached
🟦 RunTarget(report:lint) 3.1s Cached
🟩 RunTarget(report:format) 3.7s Passed
🟦 RunTarget(report:build) 2.2s Cached
🟦 RunTarget(runtime:typecheck) 1.3s Cached
🟦 RunTarget(runtime:test) 1.6s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.5s Cached
🟩 RunTarget(runtime:format) 1.7s Passed
🟦 RunTarget(website:build) 8.1s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.8.0
Touched files
.yarn/versions/8aeb4131.yml
crates/cli/tests/snapshots/run_test__errors_for_cycle_in_task_deps.snap
crates/core/dep-graph/src/dep_graph.rs
crates/core/dep-graph/tests/dep_graph_test.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Run report for 887dd875 (windows-latest, 18)

Total time: 2m 58s | Comparison time: 12m 40s | Estimated savings: 9m 41s (76.5% faster)

Action Time Status Info
🟩 SetupNodeTool(18.18.0) 21.1s Passed
🟩 SyncNodeProject(types) 3.6s Passed
🟩 InstallNodeDeps(18.18.0) 1m 38s Passed
🟦 RunTarget(types:build) 2.3s Cached
🟩 SyncNodeProject(runtime) 893.4ms Passed
🟩 SyncNodeProject(website) 3.7s Passed
🟩 SyncNodeProject(report) 3.7s Passed
🟦 RunTarget(runtime:build) 2.7s Cached
🟩 SyncWorkspace 1.1s Passed
🟦 RunTarget(website:typecheck) 2.2s Cached
🟦 RunTarget(website:test) 2.1s Cached
🟦 RunTarget(website:lint) 5s Cached
🟩 RunTarget(website:format) 16.2s Passed
🟦 RunTarget(report:typecheck) 16.1s Cached
🟦 RunTarget(report:test) 5.6s Cached
🟦 RunTarget(report:lint) 2.4s Cached
🟩 RunTarget(report:format) 2.3s Passed
🟦 RunTarget(report:build) 6s Cached
🟦 RunTarget(runtime:typecheck) 8.4s Cached
🟦 RunTarget(runtime:test) 5.3s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 4.2s Cached
🟩 RunTarget(runtime:format) 6.1s Passed
🟦 RunTarget(website:build) 10.7s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.18.0
Touched files
.yarn/versions/8aeb4131.yml
crates/cli/tests/snapshots/run_test__errors_for_cycle_in_task_deps.snap
crates/core/dep-graph/src/dep_graph.rs
crates/core/dep-graph/tests/dep_graph_test.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Run report for 59e5548a (ubuntu-latest, 18)

Total time: 3m 21s | Comparison time: 13m 39s | Estimated savings: 10m 17s (75.4% faster)

Action Time Status Info
🟩 SetupNodeTool(18.18.0) 21.8s Passed
🟩 SyncNodeProject(types) 3.9s Passed
🟩 InstallNodeDeps(18.18.0) 1m 48s Passed
🟦 RunTarget(types:build) 7.2s Cached
🟩 SyncNodeProject(runtime) 4.9s Passed
🟩 SyncNodeProject(website) 3.6s Passed
🟩 SyncNodeProject(report) 3.6s Passed
🟦 RunTarget(runtime:build) 917.9ms Cached
🟩 SyncWorkspace 2.1s Passed
🟦 RunTarget(website:typecheck) 4.6s Cached
🟩 RunTarget(website:test) 11.8s Passed
🟦 RunTarget(website:lint) 9.7s Cached
🟩 RunTarget(website:format) 14.1s Passed
🟦 RunTarget(report:typecheck) 2.8s Cached
🟦 RunTarget(report:test) 14.4s Cached
🟦 RunTarget(report:lint) 5.6s Cached
🟩 RunTarget(report:format) 8.6s Passed
🟦 RunTarget(report:build) 8.4s Cached
🟦 RunTarget(runtime:typecheck) 4.6s Cached
🟦 RunTarget(runtime:test) 4.7s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 5s Cached
🟩 RunTarget(runtime:format) 4.3s Passed
🟦 RunTarget(website:build) 9.3s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.18.0
Touched files
crates/cli/tests/snapshots/run_test__errors_for_cycle_in_task_deps.snap
crates/core/dep-graph/src/dep_graph.rs
crates/core/dep-graph/tests/dep_graph_test.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Run report for 887dd875 (windows-latest, 16)

Total time: 3m 37s | Comparison time: 14m 9s | Estimated savings: 10m 32s (74.4% faster)

Action Time Status Info
🟩 SetupNodeTool(16.20.2) 33.2s Passed
🟩 SyncNodeProject(types) 1.8s Passed
🟩 InstallNodeDeps(16.20.2) 1m 56s Passed
🟦 RunTarget(types:build) 3.5s Cached
🟩 SyncNodeProject(runtime) 2s Passed
🟩 SyncNodeProject(website) 3.9s Passed
🟩 SyncNodeProject(report) 2.1s Passed
🟦 RunTarget(runtime:build) 4.3s Cached
🟩 SyncWorkspace 2s Passed
🟦 RunTarget(website:typecheck) 2.9s Cached
🟦 RunTarget(website:test) 1.7s Cached
🟦 RunTarget(website:lint) 3.2s Cached
🟩 RunTarget(website:format) 18.2s Passed
🟦 RunTarget(report:typecheck) 16.6s Cached
🟦 RunTarget(report:test) 3.2s Cached
🟦 RunTarget(report:lint) 4.9s Cached
🟩 RunTarget(report:format) 5.5s Passed
🟦 RunTarget(report:build) 5.6s Cached
🟦 RunTarget(runtime:typecheck) 3.5s Cached
🟦 RunTarget(runtime:test) 7.9s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 9.5s Cached
🟩 RunTarget(runtime:format) 6.4s Passed
🟦 RunTarget(website:build) 12.8s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 16

Variables:

MOON_NODE_VERSION = 16.20.2
Touched files
.yarn/versions/8aeb4131.yml
crates/cli/tests/snapshots/run_test__errors_for_cycle_in_task_deps.snap
crates/core/dep-graph/src/dep_graph.rs
crates/core/dep-graph/tests/dep_graph_test.rs
packages/cli/CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Run report for 887dd875 (ubuntu-latest, 20)

Total time: 2m 41s | Comparison time: 7m 11s | Estimated savings: 4m 29s (62.5% faster)

Action Time Status Info
🟩 SetupNodeTool(20.8.0) 21.5s Passed
🟩 SyncNodeProject(types) 492.6ms Passed
🟩 InstallNodeDeps(20.8.0) 1m 50s Passed
🟦 RunTarget(types:build) 1.3s Cached
🟩 SyncNodeProject(runtime) 620.8ms Passed
🟩 SyncNodeProject(website) 517.9ms Passed
🟩 SyncNodeProject(report) 531.3ms Passed
🟦 RunTarget(runtime:build) 882.5ms Cached
🟩 SyncWorkspace 662.1ms Passed
🟦 RunTarget(website:typecheck) 1.3s Cached
🟦 RunTarget(website:test) 1.3s Cached
🟦 RunTarget(website:lint) 1.4s Cached
🟩 RunTarget(website:format) 12.2s Passed
🟦 RunTarget(report:typecheck) 12.1s Cached
🟦 RunTarget(report:test) 1.5s Cached
🟦 RunTarget(report:lint) 1.4s Cached
🟩 RunTarget(report:format) 2.1s Passed
🟦 RunTarget(report:build) 2.2s Cached
🟦 RunTarget(runtime:typecheck) 1.5s Cached
🟦 RunTarget(runtime:test) 1.4s Cached
And 3 more...
Expanded report
Action Time Status Info
🟦 RunTarget(runtime:lint) 1.3s Cached
🟩 RunTarget(runtime:format) 2.1s Passed
🟦 RunTarget(website:build) 6s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.8.0
Touched files
.yarn/versions/8aeb4131.yml
crates/cli/tests/snapshots/run_test__errors_for_cycle_in_task_deps.snap
crates/core/dep-graph/src/dep_graph.rs
crates/core/dep-graph/tests/dep_graph_test.rs
packages/cli/CHANGELOG.md

@milesj milesj merged commit 28252d5 into master Oct 5, 2023
25 checks passed
@milesj milesj deleted the fix-1095 branch October 5, 2023 18:43
milesj added a commit that referenced this pull request Oct 5, 2023
* Fix cycle.

* Update changelog.

* Add patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant