Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix flaky tests and CI pipeline. #1128

Merged
merged 8 commits into from
Oct 19, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Polish.
  • Loading branch information
milesj committed Oct 19, 2023
commit 78f2c4038cdc5f4d2faa824dded7d8974b3d1542
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ on:
schedule:
- cron: '0 0 * * *'
# Uncomment to test in PRs (its safe)
pull_request:
# pull_request:

permissions:
contents: write
@@ -28,8 +28,8 @@ jobs:
runs-on: ubuntu-latest
outputs:
publish:
${{ github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' ||
github.event_name == 'schedule' || contains(github.ref, 'develop-') }}
${{ github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' ||
contains(github.ref, 'develop-') }}
nightly: ${{ steps.plan-step.outputs.nightly }}
npm-channel: ${{ steps.plan-step.outputs.npm-channel }}
steps:
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest4, self-hosted-laptop-macos-m1, self-hosted-laptop-windows-i7]
os: [ubuntu-latest, self-hosted-laptop-macos-m1, self-hosted-laptop-windows-i7]
fail-fast: false
steps:
- uses: actions/checkout@v4
1 change: 0 additions & 1 deletion scripts/release/setupNpm.sh
Original file line number Diff line number Diff line change
@@ -23,7 +23,6 @@ if [[ "$NIGHTLY" == "true" ]]; then
echo "$package"
cd "./$package" || exit
pkg=$(jq ".version += \"$preid\"" package.json)
echo "$pkg"
echo "$pkg" > package.json
cd ../..
done
Loading