Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Use a PATH based approach for task execution. #1208

Merged
merged 36 commits into from
Dec 9, 2023

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Nov 27, 2023

Previously, when we would execute a task, we would attempt to find the real binary for the command on the file system, and execute it directly. For simple tools like bun/node/rust, this was super simple. But for packages within a tool/platform, like node modules and cargo bins, this was extremely complicated and brittle.

To remedy this, we're now using a shell + PATH based approach, where we rely on the OS to find the applicable binaries. We just need to ensure all the correct paths are aggregated.

Copy link

github-actions bot commented Nov 28, 2023

Run report for 20630fc6 (ubuntu-latest, 20)

Total time: 1m 27s | Comparison time: 6m 37s | Estimated savings: 5m 9s (78.0% faster)

Action Time Status Info
🟩 SyncWorkspace 1.4s Passed
🟩 SetupNodeTool(20.10.0) 15.1s Passed
🟩 InstallNodeDeps(20.10.0) 46.6s Passed
🟩 SyncNodeProject(types) 835.7ms Passed
🟩 SyncNodeProject(visualizer) 840.5ms Passed
🟩 SyncNodeProject(report) 678.3ms Passed
🟩 SyncNodeProject(runtime) 683ms Passed
🟦 RunTask(types:build) 1.7s Cached
🟩 RunTask(types:format) 3.1s Passed
🟦 RunTask(types:lint) 2.4s Cached
🟦 RunTask(types:test) 2.1s Cached
🟦 RunTask(report:build) 2s Cached
🟩 RunTask(report:format) 2.9s Passed
🟦 RunTask(report:lint) 2.3s Cached
🟦 RunTask(report:test) 1.3s Cached
🟦 RunTask(report:typecheck) 1.8s Cached
🟦 RunTask(types:typecheck) 1.4s Cached
🟦 RunTask(runtime:build) 2.2s Cached
🟩 SyncNodeProject(website) 1.1s Passed
🟩 RunTask(runtime:format) 1.6s Passed
And 13 more...
Expanded report
Action Time Status Info
🟦 RunTask(website:build) 3s Cached
🟩 RunTask(website:format) 8.4s Passed
🟦 RunTask(website:lint) 2s Cached
🟦 RunTask(website:test) 2s Cached
🟦 RunTask(website:typecheck) 1.6s Cached
🟦 RunTask(runtime:lint) 2.4s Cached
🟦 RunTask(runtime:test) 1.3s Cached
🟦 RunTask(runtime:typecheck) 1.4s Cached
🟦 RunTask(visualizer:build) 2.5s Cached
🟩 RunTask(visualizer:format) 3.3s Passed
🟦 RunTask(visualizer:lint) 2.1s Cached
🟦 RunTask(visualizer:test) 1.2s Cached
🟦 RunTask(visualizer:typecheck) 819.8ms Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.10.0
Touched files
.github/workflows/pr.yml
.github/workflows/rust.yml
.moon/workspace.yml
.prototools
Cargo.lock
Cargo.toml
crates/bun/platform/src/actions/run_target.rs
crates/bun/platform/src/bun_platform.rs
crates/bun/tool/src/bun_tool.rs
crates/cli/src/commands/bin.rs
crates/cli/src/commands/upgrade.rs
crates/cli/src/main.rs
crates/cli/tests/bin_test.rs
crates/cli/tests/run_node_test.rs
crates/cli/tests/run_system_test.rs
crates/cli/tests/run_test.rs
crates/cli/tests/snapshots/action_graph_test__action_graph__aliases__resolves_aliases_in_task_deps.snap
crates/cli/tests/snapshots/project_test__root_level.snap
crates/cli/tests/snapshots/run_node_test__aliases__runs_via_package_name.snap
crates/cli/tests/snapshots/run_node_test__passes_args_through.snap
crates/core/action-pipeline/Cargo.toml
crates/core/action-pipeline/src/actions/sync_workspace.rs
crates/core/moon/src/lib.rs
crates/core/runner/src/runner.rs
crates/core/test-utils/src/cli.rs
crates/core/tool/Cargo.toml
crates/core/tool/src/lib.rs
crates/core/tool/src/tool.rs
crates/deno/platform/src/deno_platform.rs
crates/deno/platform/src/lib.rs
crates/deno/platform/src/platform.rs
crates/deno/tool/src/deno_tool.rs
crates/node/lang/Cargo.toml
crates/node/lang/src/node.rs
crates/node/platform/src/actions/run_target.rs
crates/node/platform/src/node_platform.rs
crates/node/tool/src/bun_tool.rs
crates/node/tool/src/node_tool.rs
crates/node/tool/src/npm_tool.rs
crates/node/tool/src/pnpm_tool.rs
crates/node/tool/src/yarn_tool.rs
crates/rust/platform/src/rust_platform.rs
crates/rust/platform/tests/rust_platform_test.rs
crates/rust/tool/src/rust_tool.rs
crates/system/platform/Cargo.toml
crates/system/platform/src/lib.rs
crates/system/platform/src/platform.rs
crates/system/platform/src/system_platform.rs
crates/system/platform/src/tool.rs
nextgen/common/src/consts.rs
nextgen/process/src/command.rs
nextgen/process/src/shell.rs
nextgen/task-builder/src/tasks_builder.rs
nextgen/task-builder/tests/tasks_builder_test.rs
nextgen/task/src/task_options.rs
nextgen/test-utils/src/platform_manager.rs
nextgen/vcs/src/process_cache.rs
packages/cli/CHANGELOG.md
tests/fixtures/cases/moon.yml
tests/fixtures/cases/target-scope-a/moon.yml
tests/fixtures/cases/target-scope-b/moon.yml
tests/fixtures/cases/target-scope-c/moon.yml
tests/fixtures/node/deps-a/moon.yml
tests/fixtures/node/deps-b/moon.yml
tests/fixtures/node/deps-c/moon.yml
tests/fixtures/project-graph/aliases/node-name-only/moon.yml
tests/fixtures/project-graph/aliases/node-name-scope/moon.yml
tests/fixtures/system/windows/echo.ps1
tests/fixtures/system/windows/moon.yml
website/blog/2022-10-06_v0.16.mdx
website/blog/2023-07-10_moon-v1.10.mdx
website/blog/2023-12-12_moon-v1.18.mdx
website/docs/commands/overview.mdx
website/docs/config/project.mdx
website/docs/faq.mdx

Copy link

github-actions bot commented Nov 28, 2023

Run report for 20630fc6 (ubuntu-latest, 18)

Total time: 1m 26s | Comparison time: 6m 37s | Estimated savings: 5m 11s (78.3% faster)

Action Time Status Info
🟩 SyncWorkspace 1.4s Passed
🟩 SetupNodeTool(18.19.0) 16.3s Passed
🟩 InstallNodeDeps(18.19.0) 44.4s Passed
🟩 SyncNodeProject(types) 723.7ms Passed
🟩 SyncNodeProject(visualizer) 726.7ms Passed
🟩 SyncNodeProject(report) 1.3s Passed
🟩 SyncNodeProject(runtime) 1.3s Passed
🟦 RunTask(types:build) 1.7s Cached
🟩 RunTask(types:format) 2.4s Passed
🟦 RunTask(report:build) 2.1s Cached
🟩 RunTask(report:format) 3.1s Passed
🟦 RunTask(report:lint) 2.5s Cached
🟦 RunTask(report:test) 1.5s Cached
🟦 RunTask(report:typecheck) 2.5s Cached
🟦 RunTask(types:lint) 1.7s Cached
🟦 RunTask(types:test) 2.1s Cached
🟦 RunTask(types:typecheck) 1.3s Cached
🟦 RunTask(runtime:build) 1.3s Cached
🟩 SyncNodeProject(website) 1.3s Passed
🟩 RunTask(runtime:format) 2.4s Passed
And 13 more...
Expanded report
Action Time Status Info
🟦 RunTask(runtime:lint) 1.7s Cached
🟦 RunTask(website:build) 2s Cached
🟩 RunTask(website:format) 8.3s Passed
🟦 RunTask(website:lint) 2.7s Cached
🟦 RunTask(website:test) 1.3s Cached
🟦 RunTask(website:typecheck) 2.1s Cached
🟦 RunTask(runtime:test) 1.7s Cached
🟦 RunTask(runtime:typecheck) 2.4s Cached
🟦 RunTask(visualizer:build) 1.3s Cached
🟩 RunTask(visualizer:format) 2.9s Passed
🟦 RunTask(visualizer:lint) 2s Cached
🟦 RunTask(visualizer:test) 2.4s Cached
🟦 RunTask(visualizer:typecheck) 1.6s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.19.0
Touched files
.github/workflows/pr.yml
.github/workflows/rust.yml
.moon/workspace.yml
.prototools
Cargo.lock
Cargo.toml
crates/bun/platform/src/actions/run_target.rs
crates/bun/platform/src/bun_platform.rs
crates/bun/tool/src/bun_tool.rs
crates/cli/src/commands/bin.rs
crates/cli/src/commands/upgrade.rs
crates/cli/src/main.rs
crates/cli/tests/bin_test.rs
crates/cli/tests/run_node_test.rs
crates/cli/tests/run_system_test.rs
crates/cli/tests/run_test.rs
crates/cli/tests/snapshots/action_graph_test__action_graph__aliases__resolves_aliases_in_task_deps.snap
crates/cli/tests/snapshots/project_test__root_level.snap
crates/cli/tests/snapshots/run_node_test__aliases__runs_via_package_name.snap
crates/cli/tests/snapshots/run_node_test__passes_args_through.snap
crates/core/action-pipeline/Cargo.toml
crates/core/action-pipeline/src/actions/sync_workspace.rs
crates/core/moon/src/lib.rs
crates/core/runner/src/runner.rs
crates/core/test-utils/src/cli.rs
crates/core/tool/Cargo.toml
crates/core/tool/src/lib.rs
crates/core/tool/src/tool.rs
crates/deno/platform/src/deno_platform.rs
crates/deno/platform/src/lib.rs
crates/deno/platform/src/platform.rs
crates/deno/tool/src/deno_tool.rs
crates/node/lang/Cargo.toml
crates/node/lang/src/node.rs
crates/node/platform/src/actions/run_target.rs
crates/node/platform/src/node_platform.rs
crates/node/tool/src/bun_tool.rs
crates/node/tool/src/node_tool.rs
crates/node/tool/src/npm_tool.rs
crates/node/tool/src/pnpm_tool.rs
crates/node/tool/src/yarn_tool.rs
crates/rust/platform/src/rust_platform.rs
crates/rust/platform/tests/rust_platform_test.rs
crates/rust/tool/src/rust_tool.rs
crates/system/platform/Cargo.toml
crates/system/platform/src/lib.rs
crates/system/platform/src/platform.rs
crates/system/platform/src/system_platform.rs
crates/system/platform/src/tool.rs
nextgen/common/src/consts.rs
nextgen/process/src/command.rs
nextgen/process/src/shell.rs
nextgen/task-builder/src/tasks_builder.rs
nextgen/task-builder/tests/tasks_builder_test.rs
nextgen/task/src/task_options.rs
nextgen/test-utils/src/platform_manager.rs
nextgen/vcs/src/process_cache.rs
packages/cli/CHANGELOG.md
tests/fixtures/cases/moon.yml
tests/fixtures/cases/target-scope-a/moon.yml
tests/fixtures/cases/target-scope-b/moon.yml
tests/fixtures/cases/target-scope-c/moon.yml
tests/fixtures/node/deps-a/moon.yml
tests/fixtures/node/deps-b/moon.yml
tests/fixtures/node/deps-c/moon.yml
tests/fixtures/project-graph/aliases/node-name-only/moon.yml
tests/fixtures/project-graph/aliases/node-name-scope/moon.yml
tests/fixtures/system/windows/echo.ps1
tests/fixtures/system/windows/moon.yml
website/blog/2022-10-06_v0.16.mdx
website/blog/2023-07-10_moon-v1.10.mdx
website/blog/2023-12-12_moon-v1.18.mdx
website/docs/commands/overview.mdx
website/docs/config/project.mdx
website/docs/faq.mdx

Copy link

github-actions bot commented Nov 28, 2023

Run report for 20630fc6 (windows-latest, 20)

Total time: 1m 50s | Comparison time: 6m 23s | Estimated savings: 4m 32s (71.1% faster)

Action Time Status Info
🟩 SyncWorkspace 3.9s Passed
🟩 SetupNodeTool(20.10.0) 23s Passed
🟩 InstallNodeDeps(20.10.0) 58.2s Passed
🟩 SyncNodeProject(types) 569.5ms Passed
🟩 SyncNodeProject(visualizer) 571.8ms Passed
🟩 SyncNodeProject(report) 852.3ms Passed
🟦 RunTask(types:build) 1.4s Cached
🟩 RunTask(types:format) 3.3s Passed
🟦 RunTask(types:lint) 1.8s Cached
🟦 RunTask(report:build) 1.1s Cached
🟩 RunTask(report:format) 3.2s Passed
🟦 RunTask(report:lint) 2.1s Cached
🟦 RunTask(report:test) 1.8s Cached
🟦 RunTask(report:typecheck) 1.1s Cached
🟦 RunTask(types:test) 1.5s Cached
🟦 RunTask(types:typecheck) 1.8s Cached
🟩 SyncNodeProject(runtime) 1.5s Passed
🟦 RunTask(runtime:build) 1s Cached
🟩 SyncNodeProject(website) 1s Passed
🟩 RunTask(runtime:format) 2.6s Passed
And 13 more...
Expanded report
Action Time Status Info
🟦 RunTask(runtime:lint) 1.4s Cached
🟦 RunTask(website:build) 1.5s Cached
🟩 RunTask(website:format) 9.2s Passed
🟦 RunTask(website:lint) 2.1s Cached
🟦 RunTask(website:test) 2.5s Cached
🟦 RunTask(website:typecheck) 1.2s Cached
🟦 RunTask(runtime:test) 2s Cached
🟦 RunTask(runtime:typecheck) 2.3s Cached
🟦 RunTask(visualizer:build) 1.6s Cached
🟩 RunTask(visualizer:format) 3.1s Passed
🟦 RunTask(visualizer:lint) 1.3s Cached
🟦 RunTask(visualizer:test) 2s Cached
🟦 RunTask(visualizer:typecheck) 1.7s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20

Variables:

MOON_NODE_VERSION = 20.10.0
Touched files
.github/workflows/pr.yml
.github/workflows/rust.yml
.moon/workspace.yml
.prototools
Cargo.lock
Cargo.toml
crates/bun/platform/src/actions/run_target.rs
crates/bun/platform/src/bun_platform.rs
crates/bun/tool/src/bun_tool.rs
crates/cli/src/commands/bin.rs
crates/cli/src/commands/upgrade.rs
crates/cli/src/main.rs
crates/cli/tests/bin_test.rs
crates/cli/tests/run_node_test.rs
crates/cli/tests/run_system_test.rs
crates/cli/tests/run_test.rs
crates/cli/tests/snapshots/action_graph_test__action_graph__aliases__resolves_aliases_in_task_deps.snap
crates/cli/tests/snapshots/project_test__root_level.snap
crates/cli/tests/snapshots/run_node_test__aliases__runs_via_package_name.snap
crates/cli/tests/snapshots/run_node_test__passes_args_through.snap
crates/core/action-pipeline/Cargo.toml
crates/core/action-pipeline/src/actions/sync_workspace.rs
crates/core/moon/src/lib.rs
crates/core/runner/src/runner.rs
crates/core/test-utils/src/cli.rs
crates/core/tool/Cargo.toml
crates/core/tool/src/lib.rs
crates/core/tool/src/tool.rs
crates/deno/platform/src/deno_platform.rs
crates/deno/platform/src/lib.rs
crates/deno/platform/src/platform.rs
crates/deno/tool/src/deno_tool.rs
crates/node/lang/Cargo.toml
crates/node/lang/src/node.rs
crates/node/platform/src/actions/run_target.rs
crates/node/platform/src/node_platform.rs
crates/node/tool/src/bun_tool.rs
crates/node/tool/src/node_tool.rs
crates/node/tool/src/npm_tool.rs
crates/node/tool/src/pnpm_tool.rs
crates/node/tool/src/yarn_tool.rs
crates/rust/platform/src/rust_platform.rs
crates/rust/platform/tests/rust_platform_test.rs
crates/rust/tool/src/rust_tool.rs
crates/system/platform/Cargo.toml
crates/system/platform/src/lib.rs
crates/system/platform/src/platform.rs
crates/system/platform/src/system_platform.rs
crates/system/platform/src/tool.rs
nextgen/common/src/consts.rs
nextgen/process/src/command.rs
nextgen/process/src/shell.rs
nextgen/task-builder/src/tasks_builder.rs
nextgen/task-builder/tests/tasks_builder_test.rs
nextgen/task/src/task_options.rs
nextgen/test-utils/src/platform_manager.rs
nextgen/vcs/src/process_cache.rs
packages/cli/CHANGELOG.md
tests/fixtures/cases/moon.yml
tests/fixtures/cases/target-scope-a/moon.yml
tests/fixtures/cases/target-scope-b/moon.yml
tests/fixtures/cases/target-scope-c/moon.yml
tests/fixtures/node/deps-a/moon.yml
tests/fixtures/node/deps-b/moon.yml
tests/fixtures/node/deps-c/moon.yml
tests/fixtures/project-graph/aliases/node-name-only/moon.yml
tests/fixtures/project-graph/aliases/node-name-scope/moon.yml
tests/fixtures/system/windows/echo.ps1
tests/fixtures/system/windows/moon.yml
website/blog/2022-10-06_v0.16.mdx
website/blog/2023-07-10_moon-v1.10.mdx
website/blog/2023-12-12_moon-v1.18.mdx
website/docs/commands/overview.mdx
website/docs/config/project.mdx
website/docs/faq.mdx

Copy link

github-actions bot commented Nov 28, 2023

Run report for be94c70b (windows-latest, 18)

Total time: 24m 54s | Comparison time: 397m 49s | Estimated savings: 372m 55s (93.7% faster)

Action Time Status Info
🟩 SyncWorkspace 3s Passed
🟩 SetupNodeTool(18.19.0) 19.9s Passed
🟩 InstallNodeDeps(18.19.0) 1m 1s Passed
🟩 SyncNodeProject(types) 427.2ms Passed
🟩 SyncNodeProject(visualizer) 429.6ms Passed
🟩 SyncNodeProject(report) 3m Passed SLOW
🟦 RunTask(types:build) 4m 31s Cached SLOW
🟩 RunTask(types:format) 4m 33s Passed SLOW
🟦 RunTask(types:lint) 4m 32s Cached SLOW
🟦 RunTask(report:build) 3m 1s Cached SLOW
🟩 RunTask(report:format) 4m 33s Passed SLOW
🟦 RunTask(report:lint) 4m 32s Cached SLOW
🟦 RunTask(report:test) 4m 32s Cached SLOW
🟦 RunTask(report:typecheck) 3m 1s Cached SLOW
🟦 RunTask(types:test) 3m 1s Cached SLOW
🟦 RunTask(types:typecheck) 3m 2s Cached SLOW
🟩 SyncNodeProject(runtime) 3m 1s Passed SLOW
🟦 RunTask(runtime:build) 1.1s Cached
🟩 SyncNodeProject(website) 1.1s Passed
🟩 RunTask(runtime:format) 4m 47s Passed SLOW
And 13 more...
Expanded report
Action Time Status Info
🟦 RunTask(runtime:lint) 4m 46s Cached SLOW
🟦 RunTask(website:build) 1.6s Cached
🟩 RunTask(website:format) 10.1s Passed
🟦 RunTask(website:lint) 3s Cached
🟦 RunTask(website:test) 2.4s Cached
🟦 RunTask(website:typecheck) 1.2s Cached
🟩 RunTask(runtime:test) 4m 47s Passed SLOW
🟦 RunTask(runtime:typecheck) 4m 46s Cached SLOW
🟦 RunTask(visualizer:build) 1.8s Cached
🟩 RunTask(visualizer:format) 1m 33s Passed
🟦 RunTask(visualizer:lint) 1m 31s Cached
🟦 RunTask(visualizer:test) 1m 32s Cached
🟦 RunTask(visualizer:typecheck) 1m 32s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18

Variables:

MOON_NODE_VERSION = 18.19.0
Touched files
.github/workflows/pr.yml
.github/workflows/rust.yml
.moon/workspace.yml
.prototools
Cargo.lock
Cargo.toml
crates/bun/platform/src/actions/run_target.rs
crates/bun/platform/src/bun_platform.rs
crates/bun/tool/src/bun_tool.rs
crates/cli/src/commands/bin.rs
crates/cli/src/commands/upgrade.rs
crates/cli/src/main.rs
crates/cli/tests/bin_test.rs
crates/cli/tests/run_node_test.rs
crates/cli/tests/run_system_test.rs
crates/cli/tests/run_test.rs
crates/cli/tests/snapshots/action_graph_test__action_graph__aliases__resolves_aliases_in_task_deps.snap
crates/cli/tests/snapshots/project_test__root_level.snap
crates/cli/tests/snapshots/run_node_test__aliases__runs_via_package_name.snap
crates/cli/tests/snapshots/run_node_test__passes_args_through.snap
crates/core/action-pipeline/Cargo.toml
crates/core/action-pipeline/src/actions/sync_workspace.rs
crates/core/moon/src/lib.rs
crates/core/runner/src/runner.rs
crates/core/test-utils/src/cli.rs
crates/core/tool/Cargo.toml
crates/core/tool/src/lib.rs
crates/core/tool/src/tool.rs
crates/deno/platform/src/deno_platform.rs
crates/deno/platform/src/lib.rs
crates/deno/platform/src/platform.rs
crates/deno/tool/src/deno_tool.rs
crates/node/lang/Cargo.toml
crates/node/lang/src/node.rs
crates/node/platform/src/actions/run_target.rs
crates/node/platform/src/node_platform.rs
crates/node/tool/src/bun_tool.rs
crates/node/tool/src/node_tool.rs
crates/node/tool/src/npm_tool.rs
crates/node/tool/src/pnpm_tool.rs
crates/node/tool/src/yarn_tool.rs
crates/rust/platform/src/rust_platform.rs
crates/rust/platform/tests/rust_platform_test.rs
crates/rust/tool/src/rust_tool.rs
crates/system/platform/Cargo.toml
crates/system/platform/src/lib.rs
crates/system/platform/src/platform.rs
crates/system/platform/src/system_platform.rs
crates/system/platform/src/tool.rs
nextgen/common/src/consts.rs
nextgen/process/src/command.rs
nextgen/process/src/shell.rs
nextgen/task-builder/src/tasks_builder.rs
nextgen/task-builder/tests/tasks_builder_test.rs
nextgen/task/src/task_options.rs
nextgen/test-utils/src/platform_manager.rs
nextgen/vcs/src/process_cache.rs
packages/cli/CHANGELOG.md
tests/fixtures/cases/moon.yml
tests/fixtures/cases/target-scope-a/moon.yml
tests/fixtures/cases/target-scope-b/moon.yml
tests/fixtures/cases/target-scope-c/moon.yml
tests/fixtures/node/deps-a/moon.yml
tests/fixtures/node/deps-b/moon.yml
tests/fixtures/node/deps-c/moon.yml
tests/fixtures/project-graph/aliases/node-name-only/moon.yml
tests/fixtures/project-graph/aliases/node-name-scope/moon.yml
tests/fixtures/system/windows/echo.ps1
tests/fixtures/system/windows/moon.yml
website/blog/2022-10-06_v0.16.mdx
website/blog/2023-07-10_moon-v1.10.mdx
website/blog/2023-12-12_moon-v1.18.mdx
website/docs/commands/overview.mdx
website/docs/config/project.mdx
website/docs/faq.mdx

@rotu
Copy link
Contributor

rotu commented Dec 1, 2023

I don't use moon meaningfully yet, so take my feedback with a heaping tablespoon of salt.

I personally try to keep tasks as shell-agnostic as possible - it's annoying when, e.g. I clone a npm project on Windows only to find that the package scripts call rm -rf and need to be modified to run! Or to find that the scripts use some bash-specific behavior which doesn't work on Mac (which uses zsh by default).

Even on Windows, I don't know if I'd actually want all the stuff (like the many PowerShell cmdlet abbreviations) to resolve in a script, unless I opt in specifically.

@milesj milesj changed the title new: Run all tasks through a toolchain based shell. new: Use a PATH based approach for task execution. Dec 8, 2023
@milesj milesj marked this pull request as ready for review December 9, 2023 00:58
@milesj milesj merged commit f7bd6b1 into develop-1.18 Dec 9, 2023
19 of 23 checks passed
@milesj milesj deleted the 1.18-tool-shell branch December 9, 2023 20:12
milesj added a commit that referenced this pull request Dec 11, 2023
* new: Rework `moon init` command. (#1204)

* Minor polish.

* Update init/node.

* Update ts/rust.

* Added bun.

* Update changelog.

* Update error.

* Final pass.

* Fix tests.

* Polish rust.

* Add paths.

* Add new methods.

* Update deno.

* Update bun.

* Update deno.

* Update rust.

* Update node.

* Add target paths.

* Add env vars.

* Update bin.

* Rework vars.

* Avoid latest version.

* Fix tests.

* Update docs.

* Install proto.

* Polish consts.

* Update lookup paths.

* Always use a shell.

* Remove shell from vcs.

* Copy bin.

* Polish.

* Fix workspace.

* Fixes.

* Disable proto for tests.

* Only run on linux.

* Start on blog post.

* Fix windows shell.

* Fix tests.

* More fixes.

* More fixes.

* Fix format.

* Update docs.

* Fallback to a version.

* Remove snapshot.

* Update proto config.
milesj added a commit that referenced this pull request Dec 12, 2023
* new: Rework `moon init` command. (#1204)

* Minor polish.

* Update init/node.

* Update ts/rust.

* Added bun.

* Update changelog.

* Update error.

* Final pass.

* Fix tests.

* Polish rust.

* Add paths.

* Add new methods.

* Update deno.

* Update bun.

* Update deno.

* Update rust.

* Update node.

* Add target paths.

* Add env vars.

* Update bin.

* Rework vars.

* Avoid latest version.

* Fix tests.

* Update docs.

* Install proto.

* Polish consts.

* Update lookup paths.

* Always use a shell.

* Remove shell from vcs.

* Copy bin.

* Polish.

* Fix workspace.

* Fixes.

* Disable proto for tests.

* Only run on linux.

* Start on blog post.

* Fix windows shell.

* Fix tests.

* More fixes.

* More fixes.

* Fix format.

* Update docs.

* Fallback to a version.

* Remove snapshot.

* Update proto config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants