Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix affected for empty inputs. #1746

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: Fix affected for empty inputs. #1746

merged 1 commit into from
Dec 4, 2024

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Dec 4, 2024

Fixes #1743

Copy link

github-actions bot commented Dec 4, 2024

Run report for ba9878ea (ubuntu-latest, 20)

Total time: 2m 46s | Comparison time: 3m 13s | Estimated savings: 27.5s (14.2% faster)

Action Time Status Info
🟩 SyncWorkspace 28ms Passed
🟩 SetupToolchain(node:~20) 20.8s Passed
🟩 SyncProject(node, types) 2.9ms Passed
🟩 SyncProject(node, runtime) 3ms Passed
🟩 SyncProject(node, website) 3.4ms Passed
🟩 InstallWorkspaceDeps(node:~20) 42.9s Passed
🟦 RunTask(types:build) 871.6ms Cached
🟦 RunTask(runtime:build) 541.8ms Cached
🟦 RunTask(website:typecheck) 585.3ms Cached
🟦 RunTask(website:test) 933ms Cached
🟦 RunTask(website:lint) 1.3s Cached
🟩 RunTask(website:format) 10.1s Passed
🟩 RunTask(website:build) 1m 41s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20
Touched files
CHANGELOG.md
crates/affected/src/affected_tracker.rs
crates/affected/tests/__fixtures__/tasks/base/moon.yml
crates/affected/tests/affected_tracker_test.rs
website/docs/guides/root-project.mdx

Copy link

github-actions bot commented Dec 4, 2024

Run report for ba9878ea (ubuntu-latest, 22)

Total time: 2m 42s | Comparison time: 3m 3s | Estimated savings: 21.7s (11.8% faster)

Action Time Status Info
🟩 SyncWorkspace 27.7ms Passed
🟩 SetupToolchain(node:~22) 23.4s Passed
🟩 SyncProject(node, types) 3.1ms Passed
🟩 SyncProject(node, runtime) 2.9ms Passed
🟩 SyncProject(node, website) 4.6ms Passed
🟩 InstallWorkspaceDeps(node:~22) 41.4s Passed
🟦 RunTask(types:build) 582.3ms Cached
🟦 RunTask(runtime:build) 470.9ms Cached
🟦 RunTask(website:lint) 387.6ms Cached
🟦 RunTask(website:test) 907.7ms Cached
🟦 RunTask(website:typecheck) 1s Cached
🟩 RunTask(website:format) 10.1s Passed
🟩 RunTask(website:build) 1m 36s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 22
Touched files
CHANGELOG.md
crates/affected/src/affected_tracker.rs
crates/affected/tests/__fixtures__/tasks/base/moon.yml
crates/affected/tests/affected_tracker_test.rs
website/docs/guides/root-project.mdx

Copy link

github-actions bot commented Dec 4, 2024

Run report for ba9878ea (ubuntu-latest, 18)

Total time: 2m 52s | Comparison time: 3m 12s | Estimated savings: 20.4s (10.6% faster)

Action Time Status Info
🟩 SyncWorkspace 27.8ms Passed
🟩 SetupToolchain(node:~18) 21.2s Passed
🟩 SyncProject(node, types) 3ms Passed
🟩 SyncProject(node, runtime) 3.1ms Passed
🟩 SyncProject(node, website) 3.5ms Passed
🟩 InstallWorkspaceDeps(node:~18) 42.7s Passed
🟦 RunTask(types:build) 651.2ms Cached
🟦 RunTask(runtime:build) 412.6ms Cached
🟦 RunTask(website:typecheck) 401.7ms Cached
🟦 RunTask(website:test) 885.6ms Cached
🟦 RunTask(website:lint) 1s Cached
🟩 RunTask(website:format) 10.7s Passed
🟩 RunTask(website:build) 1m 47s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18
Touched files
CHANGELOG.md
crates/affected/src/affected_tracker.rs
crates/affected/tests/__fixtures__/tasks/base/moon.yml
crates/affected/tests/affected_tracker_test.rs
website/docs/guides/root-project.mdx

Copy link

github-actions bot commented Dec 4, 2024

Run report for ba9878ea (windows-latest, 20)

Total time: 1m 46s | Comparison time: 3m 12s | Estimated savings: 1m 26s (44.9% faster)

Action Time Status Info
🟩 SyncWorkspace 31.5ms Passed
🟩 SetupToolchain(node:~20) 29.3s Passed
🟩 SyncProject(node, types) 5ms Passed
🟩 SyncProject(node, runtime) 3.5ms Passed
🟩 SyncProject(node, website) 4ms Passed
🟩 InstallWorkspaceDeps(node:~20) 1m 4s Passed
🟦 RunTask(types:build) 913.3ms Cached
🟦 RunTask(runtime:build) 642.9ms Cached
🟦 RunTask(website:typecheck) 730.8ms Cached
🟦 RunTask(website:lint) 1.1s Cached
🟦 RunTask(website:test) 1.1s Cached
🟦 RunTask(website:build) 6.1s Cached
🟩 RunTask(website:format) 10s Passed
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20
Touched files
CHANGELOG.md
crates/affected/src/affected_tracker.rs
crates/affected/tests/__fixtures__/tasks/base/moon.yml
crates/affected/tests/affected_tracker_test.rs
website/docs/guides/root-project.mdx

Copy link

github-actions bot commented Dec 4, 2024

Run report for ba9878ea (windows-latest, 22)

Total time: 1m 43s | Comparison time: 3m 14s | Estimated savings: 1m 31s (46.8% faster)

Action Time Status Info
🟩 SyncWorkspace 31.7ms Passed
🟩 SetupToolchain(node:~22) 31.9s Passed
🟩 SyncProject(node, types) 5.1ms Passed
🟩 SyncProject(node, runtime) 3.5ms Passed
🟩 SyncProject(node, website) 3.5ms Passed
🟩 InstallWorkspaceDeps(node:~22) 59.7s Passed
🟦 RunTask(types:build) 968.9ms Cached
🟦 RunTask(runtime:build) 615.2ms Cached
🟦 RunTask(website:test) 835.3ms Cached
🟦 RunTask(website:typecheck) 1.2s Cached
🟦 RunTask(website:lint) 1.6s Cached
🟦 RunTask(website:build) 6s Cached
🟩 RunTask(website:format) 9.7s Passed
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 22
Touched files
CHANGELOG.md
crates/affected/src/affected_tracker.rs
crates/affected/tests/__fixtures__/tasks/base/moon.yml
crates/affected/tests/affected_tracker_test.rs
website/docs/guides/root-project.mdx

Copy link

github-actions bot commented Dec 4, 2024

Run report for ba9878ea (windows-latest, 18)

Total time: 1m 46s | Comparison time: 2m 48s | Estimated savings: 1m 2s (36.8% faster)

Action Time Status Info
🟩 SyncWorkspace 33.7ms Passed
🟩 SetupToolchain(node:~18) 29.6s Passed
🟩 SyncProject(node, types) 4.5ms Passed
🟩 SyncProject(node, runtime) 3.7ms Passed
🟩 SyncProject(node, website) 4.4ms Passed
🟩 InstallWorkspaceDeps(node:~18) 1m 4s Passed
🟦 RunTask(types:build) 667.7ms Cached
🟦 RunTask(runtime:build) 463.1ms Cached
🟦 RunTask(website:test) 559.3ms Cached
🟦 RunTask(website:lint) 675.5ms Cached
🟦 RunTask(website:typecheck) 675.9ms Cached
🟦 RunTask(website:build) 4.7s Cached
🟩 RunTask(website:format) 10.9s Passed
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18
Touched files
CHANGELOG.md
crates/affected/src/affected_tracker.rs
crates/affected/tests/__fixtures__/tasks/base/moon.yml
crates/affected/tests/affected_tracker_test.rs
website/docs/guides/root-project.mdx

@milesj milesj enabled auto-merge (squash) December 4, 2024 20:23
@milesj milesj merged commit e44b7ee into master Dec 4, 2024
27 checks passed
@milesj milesj deleted the fix-1204 branch December 4, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Tasks with no inputs are always considered affected
1 participant