Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Commit

Permalink
Update tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
milesj committed Mar 1, 2024
1 parent be26080 commit 8a84dfa
Show file tree
Hide file tree
Showing 6 changed files with 303 additions and 52 deletions.
5 changes: 3 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ members = ["crates/*"]
extism-pdk = { version = "1.1.0" }
proto_pdk = { version = "0.17.2" } #, path = "../../proto/crates/pdk" }
proto_pdk_api = { version = "0.17.1" } #, path = "../../proto/crates/pdk-api" }
proto_pdk_test_utils = { version = "0.19.2" } #, path = "../../proto/crates/pdk-test-utils" }
proto_pdk_test_utils = { version = "0.19.3" } #, path = "../../proto/crates/pdk-test-utils" }
regex = { version = "1.10.3", default-features = false, features = [
"std",
"unicode",
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ npm|pnpm|yarn = "source:https://github.com/moonrepo/node-plugin/releases/downloa
All plugins can be configured with a `.prototools` file.

- `bundled-npm` (bool) - When `node` is installed, also install `npm` with the version of npm that came bundled with Node.js. Defaults to `false`.
- `shared-globals-dir` (bool) - Installs npm, pnpm, or yarn global packages to a shared location: `~/.proto/tools/node/globals`. Defaults to `false`.
- `shared-globals-dir` (bool) - EXPERIMENTAL: Global npm, pnpm, or yarn packages are installed to a shared location: `~/.proto/tools/node/globals`. Defaults to `false`.

```toml
[tools.node]
Expand Down
1 change: 1 addition & 0 deletions crates/node-depman/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ regex = { workspace = true }
serde = { workspace = true }

[dev-dependencies]
proto_pdk_api = { workspace = true }
proto_pdk_test_utils = { workspace = true }
serde_json = { workspace = true }
starbase_sandbox = { workspace = true }
Expand Down
4 changes: 3 additions & 1 deletion crates/node-depman/src/proto.rs
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,9 @@ pub fn pre_run(Json(input): Json<RunHook>) -> FnResult<Json<RunHookResult>> {

if aliases.iter().any(|alias| *alias == args[0])
&& args.iter().any(|arg| arg == "--global" || arg == "-g")
&& args.iter().all(|arg| arg != "--global-dir")
&& args
.iter()
.all(|arg| arg != "--global-dir" && arg != "--global-bin-dir")
{
// These arguments aren't ideal, but pnpm doesn't support
// environment variables from what I've seen...
Expand Down
Loading

0 comments on commit 8a84dfa

Please sign in to comment.