new: Add crate for installing system dependencies. (#203)

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
         os: [ubuntu-latest, windows-latest]
       fail-fast: false
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: moonrepo/setup-rust@v1
         with:
           components: rustfmt
@@ -30,7 +30,7 @@ jobs:
         os: [ubuntu-latest, windows-latest]
       fail-fast: false
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: moonrepo/setup-rust@v1
         with:
           components: clippy
@@ -44,7 +44,7 @@ jobs:
         os: [ubuntu-latest, macos-latest, windows-latest]
       fail-fast: false
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: moonrepo/setup-proto@v1
       - uses: moonrepo/setup-rust@v1
         with:
@@ -71,7 +71,7 @@ jobs:
         os: [ubuntu-latest, macos-latest, windows-latest]
       fail-fast: false
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: moonrepo/setup-rust@v1
         with:
           bins: cargo-wasi

Cargo.toml

@@ -5,8 +5,8 @@ default-members = ["crates/cli"]
 
 [workspace.dependencies]
 cached = "0.46.0"
-clap = "4.4.5"
-clap_complete = "4.4.2"
+clap = "4.4.6"
+clap_complete = "4.4.3"
 convert_case = "0.6.0"
 extism = "0.5.2"
 extism-pdk = "0.3.4"

crates/cli/Cargo.toml

@@ -30,6 +30,7 @@ path = "src/main.rs"
 proto_core = { version = "0.18.6", path = "../core" }
 proto_pdk_api = { version = "0.7.2", path = "../pdk-api" }
 proto_wasm_plugin = { version = "0.6.7", path = "../wasm-plugin" }
+system_env = { version = "0.0.1", path = "../system-env" }
 chrono = "0.4.31"
 clap = { workspace = true, features = ["derive", "env"] }
 clap_complete = { workspace = true }

crates/cli/src/commands/install.rs

@@ -126,7 +126,7 @@ pub async fn internal_install(args: InstallArgs) -> SystemResult {
         tool.get_resolved_version()
     ));
 
-    let installed = tool.setup(&version).await?;
+    let installed = tool.setup(&version, false).await?;
 
     pb.finish_and_clear();
 

crates/cli/src/commands/run.rs

@@ -1,15 +1,13 @@
 use crate::commands::install::{internal_install, InstallArgs};
 use clap::Args;
 use miette::IntoDiagnostic;
-use proto_core::{
-    detect_version, is_command_on_path, load_tool, Id, ProtoError, UnresolvedVersionSpec,
-    UserConfig,
-};
+use proto_core::{detect_version, load_tool, Id, ProtoError, UnresolvedVersionSpec, UserConfig};
 use proto_pdk_api::RunHook;
 use starbase::system;
 use starbase_styles::color;
 use std::env;
 use std::process::exit;
+use system_env::is_command_on_path;
 use tokio::process::Command;
 use tracing::debug;
 
@@ -103,7 +101,7 @@ pub async fn run(args: ArgsRef<RunArgs>) -> SystemResult {
     // Run the command
     let mut command = match bin_path.extension().map(|e| e.to_str().unwrap()) {
         Some("ps1") => {
-            let mut cmd = Command::new(if is_command_on_path("pwsh".into()) {
+            let mut cmd = Command::new(if is_command_on_path("pwsh") {
                 "pwsh"
             } else {
                 "powershell"

crates/cli/tests/plugins_test.rs

@@ -21,7 +21,7 @@ where
 
     env::set_var("PROTO_HOME", fixture.path().to_string_lossy().to_string());
 
-    tool.setup(&UnresolvedVersionSpec::parse("1.0.0").unwrap())
+    tool.setup(&UnresolvedVersionSpec::parse("1.0.0").unwrap(), false)
         .await
         .unwrap();
 

crates/core/src/error.rs

@@ -17,6 +17,10 @@ pub enum ProtoError {
     #[error("Failed to install {tool}. {error}")]
     InstallFailed { tool: String, error: String },
 
+    #[diagnostic(code(proto::tool::build_failed))]
+    #[error("Failed to build tool from {}: {status}", .url.style(Style::Url))]
+    BuildFailed { url: String, status: String },
+
     #[diagnostic(code(proto::misc::offline))]
     #[error("Internet connection required, unable to download and install tools.")]
     InternetConnectionRequired,
@@ -60,6 +64,10 @@ pub enum ProtoError {
     )]
     UnknownTool { id: Id },
 
+    #[diagnostic(code(proto::build::unsupported))]
+    #[error("Build from source is not supported for {}.", .tool.style(Style::Id))]
+    UnsupportedBuildFromSource { tool: Id },
+
     #[diagnostic(code(proto::unsupported::shell))]
     #[error("Unable to detect shell.")]
     UnsupportedShell,

crates/core/src/helpers.rs

@@ -1,5 +1,6 @@
 use crate::error::ProtoError;
 use cached::proc_macro::cached;
+use miette::IntoDiagnostic;
 use once_cell::sync::Lazy;
 use regex::Regex;
 use serde::de::DeserializeOwned;
@@ -92,45 +93,6 @@ pub fn is_cache_enabled() -> bool {
     })
 }
 
-#[cached]
-#[cfg(windows)]
-pub fn is_command_on_path(name: String) -> bool {
-    let Ok(system_path) = env::var("PATH") else {
-        return false;
-    };
-    let Ok(path_ext) = env::var("PATHEXT") else {
-        return false;
-    };
-    let exts = path_ext.split(';').collect::<Vec<_>>();
-
-    for path_dir in env::split_paths(&system_path) {
-        for ext in &exts {
-            if path_dir.join(format!("{name}{ext}")).exists() {
-                return true;
-            }
-        }
-    }
-
-    false
-}
-
-#[cached]
-#[cfg(not(windows))]
-pub fn is_command_on_path(name: String) -> bool {
-    let Ok(system_path) = env::var("PATH") else {
-        return false;
-    };
-
-    for path_dir in env::split_paths(&system_path) {
-        #[allow(clippy::needless_borrow)]
-        if path_dir.join(&name).exists() {
-            return true;
-        }
-    }
-
-    false
-}
-
 pub fn is_archive_file<P: AsRef<Path>>(path: P) -> bool {
     is_supported_archive_extension(path.as_ref())
 }
@@ -155,6 +117,13 @@ pub fn hash_file_contents<P: AsRef<Path>>(path: P) -> miette::Result<String> {
     Ok(hash)
 }
 
+pub fn extract_filename_from_url<U: AsRef<str>>(url: U) -> miette::Result<String> {
+    let url = url::Url::parse(url.as_ref()).into_diagnostic()?;
+    let segments = url.path_segments().unwrap();
+
+    Ok(segments.last().unwrap().to_owned())
+}
+
 pub fn read_json_file_with_lock<T: DeserializeOwned>(path: impl AsRef<Path>) -> miette::Result<T> {
     let path = path.as_ref();
     let mut content = fs::read_file_with_lock(path)?;