fix: Fix broken symlinks not being removed. (#294)

CHANGELOG.md

@@ -12,6 +12,10 @@
 
 ## Unreleased
 
+#### 🐞 Fixes
+
+- Fixed an issue where broken symlinks would fail to be removed. This would result in subsequent "File exists (os error 17)" errors.
+
 #### ⚙️ Internal
 
 - Updated Rust to v1.74.

Cargo.toml

@@ -34,7 +34,7 @@ starbase_archive = { version = "0.2.4", features = [
 starbase_events = "0.2.2"
 starbase_sandbox = { version = "0.1.12" }
 starbase_styles = "0.1.16"
-starbase_utils = { version = "0.3.8", default-features = false, features = [
+starbase_utils = { version = "0.3.11", default-features = false, features = [
 	"json",
 	"toml",
 ] }

crates/cli/src/commands/clean.rs

@@ -206,7 +206,7 @@ pub async fn purge_tool(id: &Id, yes: bool) -> SystemResult {
 
         // Delete binaries
         for bin in tool.get_bin_locations()? {
-            fs::remove_file(bin.path)?;
+            fs::remove_link(bin.path)?;
         }
 
         // Delete shims

crates/cli/tests/clean_test.rs

@@ -34,8 +34,17 @@ mod clean {
     #[test]
     fn purges_tool_bin() {
         let sandbox = create_empty_sandbox();
-        sandbox.create_file("bin/node", "");
-        sandbox.create_file("bin/node.exe", "");
+        sandbox.create_file("tools/node/fake/file", "");
+        sandbox.create_file("bin/other", "");
+
+        let bin = sandbox.path().join(if cfg!(windows) {
+            "bin/node.exe"
+        } else {
+            "bin/node"
+        });
+
+        #[allow(deprecated)]
+        std::fs::soft_link(sandbox.path().join("tools/node/fake/file"), &bin).unwrap();
 
         let mut cmd = create_proto_command(sandbox.path());
         cmd.arg("clean")
@@ -45,11 +54,8 @@ mod clean {
             .assert()
             .success();
 
-        if cfg!(windows) {
-            assert!(!sandbox.path().join("bin/node.exe").exists());
-        } else {
-            assert!(!sandbox.path().join("bin/node").exists());
-        }
+        assert!(!bin.exists());
+        assert!(bin.symlink_metadata().is_err());
     }
 
     #[test]

crates/core/src/tool.rs

@@ -1456,7 +1456,7 @@ impl Tool {
                 "Creating binary symlink"
             );
 
-            fs::remove_file(&output_path)?;
+            fs::remove_link(&output_path)?;
 
             #[cfg(windows)]
             {
@@ -1556,9 +1556,9 @@ impl Tool {
 
         // If no more default version, delete the symlink,
         // otherwise the OS will throw errors for missing sources
-        if self.manifest.default_version.is_none() {
+        if self.manifest.default_version.is_none() || self.manifest.installed_versions.is_empty() {
             for bin in self.get_bin_locations()? {
-                fs::remove_file(bin.path)?;
+                fs::remove_link(bin.path)?;
             }
         }
 
@@ -1579,7 +1579,7 @@ impl Tool {
             "Cleaning up temporary files and downloads"
         );
 
-        fs::remove(self.get_temp_dir())?;
+        fs::remove_dir_all(self.get_temp_dir())?;
 
         Ok(())
     }