Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.22 #272

Merged
merged 7 commits into from
Nov 8, 2023
Merged

v0.22 #272

merged 7 commits into from
Nov 8, 2023

Conversation

milesj
Copy link
Contributor

@milesj milesj commented Nov 6, 2023

No description provided.

@rotu
Copy link
Contributor

rotu commented Nov 8, 2023

I'm a little iffy on the concept of a parent bin putting any significant logic in parent bin determination. If I'm running a script with npm run, and that path contains node myscript.js, we probably need that node invocation to resolve to the same .exe as whatever magic determines the parent executable.

@milesj
Copy link
Contributor Author

milesj commented Nov 8, 2023

@rotu Do you have an actual example?

I tried using the shell scripts provided by npm/yarn, like bin/npm instead of bin/npm-cli.js, but they were completely broken as those scripts do a lot of weird path detection stuff, which isn't compatible with proto. So I have to execute the JS files using the parent (node).

Let's see how 0.22 works for you and if there's still any weirdness.

@rotu
Copy link
Contributor

rotu commented Nov 8, 2023

@rotu Do you have an actual example?

I don't right now since I'm not quite sure how things will work after this release. The thing I intend to try upon this release is:

$env:PATH=(Join-Path $env:PROTO_HOME "bin")
& proto run node -- --version
& proto run npm -- exec -c 'node --version'

I'm not totally sure what I expect the result to be, especially if the globally pinned node version is different from the locally pinned one!

but they were completely broken as those scripts do a lot of weird path detection stuff

Agreed. I think the shell scripts are more headache than help and I'm glad to see them go!

@milesj milesj merged commit c54096e into master Nov 8, 2023
14 checks passed
@milesj milesj deleted the develop-0.22 branch November 8, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants