Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix listing globals. Update plugins. #305

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix: Fix listing globals. Update plugins. #305

merged 2 commits into from
Nov 23, 2023

Conversation

milesj
Copy link
Contributor

@milesj milesj commented Nov 23, 2023

@rotu Fixes things.

One caveat though is that Python bins and globals are the same dir, so listing globals lists a bunch of other stuff. Not sure we can work around that easily.

Screenshot 2023-11-22 at 4 22 40 PM

@rotu
Copy link
Contributor

rotu commented Nov 23, 2023

One caveat though is that Python bins and globals are the same dir, so listing globals lists a bunch of other stuff.

A “global” could mean the name of a package, a module, or a binary. What do you intend proto to mean by that word for Python?

@milesj
Copy link
Contributor Author

milesj commented Nov 23, 2023

list-global is meant to display global packages that the user has ideally installed with install-global. Showing more than what they installed may confuse users.

@milesj milesj merged commit 9a8873b into master Nov 23, 2023
14 checks passed
@milesj milesj deleted the fix-list-global branch November 23, 2023 01:29
@rotu
Copy link
Contributor

rotu commented Nov 23, 2023

list-global is meant to display global packages that the user has ideally installed with install-global. Showing more than what they installed may confuse users.

Hmmm that’s a hard problem! pip doesn’t track which dependencies are directly requested. And listing out some bin folder won’t do since a package may have zero, one, or several executables.

I’ve enjoyed using poetry in the past to specify projects or environments. I’ve found pipenv to be a terrible experience (but I don’t remember why). And a requirements.txt file is probably the lightest-weight way to do it (with something like pip-sync)

Also I haven’t tried pdm meaningfully yet. I got distracted by bugs in proto :-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants