Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Audit 08/20 #596

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: Audit 08/20 #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d260de5
fix: Improve nu syntax.
milesj Aug 20, 2024
fc59072
fix: Show config mode possible values.
milesj Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@
- [Rust](https://github.com/moonrepo/tools/blob/master/tools/rust/CHANGELOG.md)
- [TOML schema](https://github.com/moonrepo/tools/blob/master/tools/internal-schema/CHANGELOG.md)

## Unreleased

#### 🚀 Updates

- Improved Nushell generated syntax.

#### 🐞 Fixes

- Fixed `--help` not showing possible values for `--config-mode`.

## 0.40.0

#### 💥 Breaking
Expand Down
5 changes: 3 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ starbase_archive = { version = "0.8.4", features = [
] }
starbase_events = { version = "0.6.3" }
starbase_sandbox = { version = "0.7.2" }
starbase_shell = { version = "0.5.5", features = ["miette"] }
starbase_shell = { version = "0.5.6", features = ["miette"] }
starbase_styles = { version = "0.4.2" }
starbase_utils = { version = "0.8.7", default-features = false, features = [
"json",
Expand Down
2 changes: 1 addition & 1 deletion crates/cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ name = "proto-shim"
path = "src/main_shim.rs"

[dependencies]
proto_core = { version = "0.40.1", path = "../core" }
proto_core = { version = "0.40.1", path = "../core", features = ["clap"] }
proto_installer = { version = "0.7.0", path = "../installer" }
proto_pdk_api = { version = "0.23.0", path = "../pdk-api" }
proto_shim = { version = "0.5.0", path = "../shim" }
Expand Down
5 changes: 5 additions & 0 deletions crates/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ version_spec = { version = "0.7.0", path = "../version-spec", features = [
warpgate = { version = "0.17.0", path = "../warpgate", features = [
"schematic",
] }
clap = { workspace = true, optional = true }
indexmap = { workspace = true }
miette = { workspace = true }
minisign-verify = "0.2.1"
Expand Down Expand Up @@ -49,3 +50,7 @@ uuid = { workspace = true }
[dev-dependencies]
starbase_sandbox = { workspace = true }
tokio = { workspace = true }

[features]
default = []
clap = ["dep:clap"]
1 change: 1 addition & 0 deletions crates/core/src/proto_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ fn validate_reserved_words(

derive_enum!(
#[derive(ConfigEnum, Copy, Default)]
#[cfg_attr(feature = "clap", derive(clap::ValueEnum))]
pub enum ConfigMode {
Global,
Local,
Expand Down