Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Commit

Permalink
docs: Add caveat.
Browse files Browse the repository at this point in the history
  • Loading branch information
milesj committed Sep 6, 2023
1 parent 97310a0 commit af1dd5a
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

[Python](https://www.python.org/) WASM plugin for [proto](https://github.com/moonrepo/proto).

## Caveats

This plugin only supports pre-builts via [indygreg/python-build-standalone](https://github.com/indygreg/python-build-standalone), and primarily only Python 3.

Building from source (with `python-build`), and supporting Python 2, will be supported in the future.

## Contributing

Build the plugin:
Expand Down
4 changes: 2 additions & 2 deletions src/proto.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ pub fn locate_bins(Json(input): Json<LocateBinsInput>) -> FnResult<Json<LocateBi
let mut bin_path = format_bin_name("install/bin/python3", env.os);
let mut globals_lookup_dirs = vec!["$HOME/.local/bin".to_owned()];

// Only available for pre-builts
// Manifest is only available for pre-builts
let manifest_path = input.context.tool_dir.join("PYTHON.json");

if manifest_path.exists() {
Expand All @@ -83,7 +83,7 @@ pub fn locate_bins(Json(input): Json<LocateBinsInput>) -> FnResult<Json<LocateBi
bin_path = manifest.python_exe;

if env.os == HostOS::Windows {
let formatted_version = manifest.python_major_minor_version.replace(".", "");
let formatted_version = manifest.python_major_minor_version.replace('.', "");

globals_lookup_dirs.push(format!(
"$APPDATA/Roaming/Python{}/Scripts",
Expand Down
2 changes: 2 additions & 0 deletions src/version.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(dead_code)]

use once_cell::sync::Lazy;
use regex::Regex;

Expand Down

0 comments on commit af1dd5a

Please sign in to comment.