Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: simplify data structs #273

Closed
wants to merge 7 commits into from
Closed

Conversation

alovak
Copy link
Contributor

@alovak alovak commented Sep 6, 2023

The goal of this PR is to implement (now it's more like proof of concept) the proposal #277 to use go basic types in the data structs instead of *field.String, *field.Numeric, etc. like this:

	type authRequestData struct {
		MTI                  string `index:"0"`
		PrimaryAccountNumber string `index:"2"`
		ProcessingCode       int    `index:"3"`
	}

@alovak alovak changed the title simplify data structs Experimental: simplify data structs Sep 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Patch coverage: 46.07% and project coverage change: -1.10% ⚠️

Comparison is base (b652df4) 73.70% compared to head (3d54372) 72.60%.

❗ Current head 3d54372 differs from pull request most recent head 255001f. Consider uploading reports for the commit 255001f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   73.70%   72.60%   -1.10%     
==========================================
  Files          43       44       +1     
  Lines        2282     2351      +69     
==========================================
+ Hits         1682     1707      +25     
- Misses        369      412      +43     
- Partials      231      232       +1     
Files Changed Coverage Δ
field/numeric.go 65.13% <10.00%> (-18.01%) ⬇️
field/string.go 70.96% <25.00%> (-12.17%) ⬇️
message.go 72.85% <70.00%> (+0.90%) ⬆️
field_tag.go 72.97% <72.97%> (ø)
field/composite.go 82.01% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@alovak
Copy link
Contributor Author

alovak commented Jan 26, 2024

this PR was a proof of concept. Now all ideas are implemented in the module.

@alovak alovak closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants