Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andrei cloud composite spec builder #285

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

mfdeveloper508
Copy link
Contributor

@mfdeveloper508 mfdeveloper508 commented Sep 26, 2023

#283

need to specify linter ignore roles for special lines

specs/builder.go Outdated Show resolved Hide resolved
specs/builder_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (b05481c) 73.95% compared to head (371d2ed) 74.76%.
Report is 11 commits behind head on master.

❗ Current head 371d2ed differs from pull request most recent head 5d18200. Consider uploading reports for the commit 5d18200 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   73.95%   74.76%   +0.81%     
==========================================
  Files          43       43              
  Lines        2338     2453     +115     
==========================================
+ Hits         1729     1834     +105     
- Misses        378      395      +17     
+ Partials      231      224       -7     
Files Coverage Δ
message.go 74.10% <ø> (-0.80%) ⬇️
field/bitmap.go 69.29% <50.00%> (-1.76%) ⬇️
field/hex.go 80.00% <90.00%> (+11.46%) ⬆️
field/track1.go 69.02% <42.85%> (ø)
field/track2.go 68.22% <42.85%> (ø)
field/track3.go 61.79% <42.85%> (ø)
field/binary.go 71.05% <82.22%> (+10.37%) ⬆️
field/numeric.go 87.06% <82.22%> (+3.92%) ⬆️
field/string.go 83.33% <81.81%> (+0.20%) ⬆️
specs/builder.go 67.53% <64.00%> (-1.43%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alovak alovak merged commit c741d11 into master Oct 6, 2023
9 checks passed
@alovak alovak deleted the Andrei-cloud-compositeSpecBuilder branch October 6, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants