Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve web tests #298

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Conversation

kingosticks
Copy link
Member

During review/testing of #287 I realised there's a potential problem with the way we mix relative and absolute URLs when using the web client when it comes to trying to clear specific parts of the cache. So I wanted to be a lot more explicit in the tests and and have the URLs we use more closely match reality. This will be helpful for the PR that addresses this issue.

Plus a fix I had been sitting on for a while which uses the skip_refresh_token in the other places it's useful (rather than directly messing about with numbers).

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #298 (d04787e) into master (790b7b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          13       13           
  Lines        1206     1206           
=======================================
  Hits         1166     1166           
  Misses         40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790b7b7...d04787e. Read the comment docs.

@kingosticks kingosticks merged commit fabc7a7 into mopidy:master Jan 6, 2021
@kingosticks kingosticks deleted the improve-web-tests branch January 6, 2021 01:21
@kingosticks kingosticks self-assigned this Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant