Use the long-form Spotify URL for user playlists. #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For logged in user 'foo', Web API endpoint "me/playlists" returns the same as "users/foo/playlists" (including headers). When we use the former, the "next" links in the response always use the latter. This leaves us with a mix of URL formats in our cache and will make identifying/invalidating these entries harder. This change ensures all the URLs look the same. No behaviour has changed.
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 13 13
Lines 1207 1207
=======================================
Hits 1167 1167
Misses 40 40
Continue to review full report at Codecov.
|
kingosticks
added a commit
to kingosticks/mopidy-spotify
that referenced
this pull request
Dec 20, 2023
For logged in user 'foo', Web API endpoint "me/playlists" returns the same as "users/foo/playlists" (including headers). When we use the former, the "next" links in the response always use the latter. This leaves us with a mix of URL formats in our cache and will make identifying/invalidating these entries harder. This change ensures all the URLs look the same. No behaviour has changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For logged in user 'foo', Web API endpoint "me/playlists"
returns the same as "users/foo/playlists" (including headers).
When we use the former, the "next" links in the response always use
the latter. This leaves us with a mix of URL formats in our cache
and will make identifying/invalidating these entries harder.
This change ensures all the URLs look the same. No behaviour has
changed.
This will make cache invalidation in #287 a little simpler and makes sense to do anyway.