Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to JUnit 5 and Gradle 7 #170

Closed
wants to merge 2 commits into from

Conversation

MohammadAlHajj
Copy link

Dear Mr. Jones
please find the connected commits to the below repos:

  • mantle-usl
  • moqui-framework
  • moqu-runtime

the goal of these commits is to move to Gradle 7.2 and to Junit 5

gradle 7:
changes need some

  • more testing since i don't know if any more dependencies need to be changed to "java-library"'s 'api' dependency type or kept at gradle's built-in implementation type.
  • These changes rely on the user's projects and which dependencies need their internals exposed to the user's projects.
  • I also solved the known issue (noted in runtime > base-component > webroot > gradel.build):
    How to handle deprecated message related to Gradle 6.0 and the gradle-js-plugin ? eriwen/gradle-js-plugin#168
    by doing:
    Gradle 6.0.1 Build Failed eriwen/gradle-js-plugin#177 (comment)
  • NOTE: the above project is probably dead and i highly advise the maintainer with the sufficient knowledge to find a replacement.... storing jars in the repo is obviously not an acceptable permanent solution
  • Moving to gradle 7 allows the use of the newest Kotlin compiler in our projects and opens the door for moving to Java 11 or possibly java 17 whenit is released

JUnit5

  • changes are none-intrusive since applying the new Jupiter and Vintage engines together allows both JUnit 4 and 5 tests to be run simultaneously..... It also separates the result of junit 4 tests into more readable chunks in Intellij (on running "gradle test"). Each test is now part of a subtree with the containing class as the new root of the test group
  • Please note that i changed " ignoreFailures = true" since moqui (framework and usl) already has failing tests (on my project) and this blocks the execution of any further tests found in the user's module

For any modification to the commit or for further information, please contact me on [email protected]

Mohammad Al-Hajj added 2 commits August 27, 2021 19:07
-All test tasks now have "ignoreFailures = true" since some stock tests are failing already and blocking the custom tests of the user
@jonesde
Copy link
Member

jonesde commented Apr 25, 2022

Closing in favor of moqui:java11 branch

@jonesde jonesde closed this Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants