Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add advanced search #67

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add advanced search #67

wants to merge 4 commits into from

Conversation

ivelt2
Copy link

@ivelt2 ivelt2 commented Nov 20, 2023

No description provided.

Copy link

what-the-diff bot commented Nov 20, 2023

PR Summary

  • Implementation of Advanced Search Functionality
    A new file named advancedsearch.js was introduced. This file contains necessary code for implementing an Advanced Search feature which involves the creation of a new button and a corresponding popup box for enhanced search functionality.
  • Inclusion of advancedsearch.js in contentScript.js
    Changes were made to the contentScript.js file so that the new advancedsearch.js file could be appropriately used in the system. This ensures that the advanced search feature can interact properly with other elements of the software.
  • Update of manifest.json to Accommodate advancedsearch.js
    The manifest.json file, which provides important information about the various components and capabilities of our extension, was updated to include the new advancedsearch.js file. This allows the advanced search feature to be recognized and properly utilized by the broader system.

@ivelt2
Copy link
Author

ivelt2 commented Nov 20, 2023

I see you are back active, wanted to PR again

Copy link
Contributor

@chucem chucem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! please explain what this feature is doing

also please name it in cammelCase advancedSearch.js

extension/js/contentScript.js Outdated Show resolved Hide resolved
@chucem
Copy link
Contributor

chucem commented Nov 21, 2023

if I get it right, I think you try to see topics like active posts with more advanced filters

image

so maybe add it on every page, and add it to this menu where we have this search already:
image

and when its selected you can change the url of the original links to the one that does the advanced search

forgive me if I got it all wrong

@mordechairoth
Copy link
Owner

@ivelt2 As @chucem pointed out, please explain the goal of this feature and what problem it solves, and attach screenshots of how this feature will look/behave when merged.

Co-authored-by: חכם ממה נשתנה <[email protected]>
@ivelt2
Copy link
Author

ivelt2 commented Nov 21, 2023

The goal of this addition is to add a feature for selective unread or active posts. when clicking this new button on the home page, you add checkboxes to all forums and allows the user to select which forums they want to see the unread posts from.

image

image

see here for the demand
https://www.ivelt.com/forum/viewtopic.php?t=62887

@chucem
Copy link
Contributor

chucem commented Nov 21, 2023

now I get it... but maybe save the selection in browser memory so user don't have to select every thing every time?

also the checkboxs and the ratio boxes can use a little left margin

@ivelt2
Copy link
Author

ivelt2 commented Nov 22, 2023

Feel free to play with the styles you need. I am not good at styling at all. I can save it to a cookie just like I did on ivelt2.github.io we will need to plan a bit on how we want the feature to look...
Ideally, I would want to create a SAVE button that would save the current selection into an easily accessible link for users to be able to return to and have up to, say, 3 bookmarks. We need to think this through. For now, I would deploy as is, maybe updating styles as you feel fit. Then let's gather some user feedback and take it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants