Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fdc3 - Enable Fdc3 as an optional feature #347

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Sep 1, 2023

Changes:

  • Added Directory.Build.props files
  • Moved composeui-fdc3 js implementation under fdc3/js folder
  • Renamed PreloadFdc3 to ResourceNames
  • Added MessagingRouter.Client to the solution for building the project
  • Refactored namespaces in Shell and Shell.Tests projects,
  • Added Fdc3Options to check if it is enabled from appsettings.json
  • Renamed Fdc3DesktopAgentConfig to Fdc3DesktopAgentBuilder
  • Modified ServiceCollectionExtensions in Fdc3DesktopAgent
  • Added ServiceCollection extension method for DesktopAgent to check the Fdc3Options and inject DesktopAgent if that is enabled from config
  • Added TODO to ResourceReader that we should move this utility to a new project later under src/shared/dotnet
  • Added missing headers
  • Fixing DesktopAgent.Tests's DesktopAgent setup
  • Removed WithUserChannel from DesktopAgent's Fdc3DesktopAgentBuilder
  • Removed internal BuilderActions property from Fdc3Options

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #347 (1b528ec) into main (605c56e) will increase coverage by 2.70%.
The diff coverage is 53.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   74.58%   77.29%   +2.70%     
==========================================
  Files         155      156       +1     
  Lines        5474     5302     -172     
  Branches      233      233              
==========================================
+ Hits         4083     4098      +15     
+ Misses       1390     1203     -187     
  Partials        1        1              
Files Changed Coverage Δ
...dc3/js/composeui-fdc3/src/ComposeUIDesktopAgent.ts 83.00% <ø> (ø)
...poseui-fdc3/src/infrastructure/ComposeUIChannel.ts 100.00% <ø> (ø)
...oseui-fdc3/src/infrastructure/ComposeUIListener.ts 92.20% <ø> (ø)
...omposeui-fdc3/src/infrastructure/ComposeUITopic.ts 93.10% <ø> (ø)
.../infrastructure/messages/Fdc3FindChannelRequest.ts 100.00% <ø> (ø)
...structure/messages/Fdc3GetCurrentContextRequest.ts 100.00% <ø> (ø)
src/shell/dotnet/Shell/App.xaml.cs 0.00% <0.00%> (ø)
...tnet/Shell/ImageSource/DefaultImageSourcePolicy.cs 0.00% <ø> (ø)
.../Shell/ImageSource/EnvironmentImageSourcePolicy.cs 0.00% <0.00%> (ø)
...ll/dotnet/Shell/ImageSource/ImageSourceProvider.cs 0.00% <ø> (ø)
... and 15 more

... and 8 files with indirect coverage changes

@lilla28 lilla28 force-pushed the fdc3/optional-feature branch from 0e12856 to c079d51 Compare September 4, 2023 10:24
@lilla28 lilla28 force-pushed the fdc3/optional-feature branch 3 times, most recently from eec754c to 598968e Compare September 6, 2023 08:27
@lilla28 lilla28 force-pushed the fdc3/optional-feature branch from 0aa0317 to a6d160b Compare September 6, 2023 10:46
@lilla28 lilla28 marked this pull request as ready for review September 6, 2023 10:47
@lilla28 lilla28 requested a review from a team September 6, 2023 10:47
@lilla28 lilla28 force-pushed the fdc3/optional-feature branch from 540e07b to 4550c10 Compare September 6, 2023 11:06
@lilla28 lilla28 force-pushed the fdc3/optional-feature branch 2 times, most recently from 7d333dd to 771495b Compare September 8, 2023 13:33
BalassaMarton
BalassaMarton previously approved these changes Sep 11, 2023
@lilla28 lilla28 force-pushed the fdc3/optional-feature branch from 94b3e49 to 1b528ec Compare September 11, 2023 14:29
@lilla28 lilla28 merged commit 846f612 into morganstanley:main Sep 14, 2023
3 of 4 checks passed
@lilla28 lilla28 deleted the fdc3/optional-feature branch May 15, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants