chore(deps): bump Microsoft.Web.WebView2 from 1.0.2045.28 to 1.0.2365.46 in /src/shell/dotnet/Shell #512
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
.NET
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage 88.69% 88.69%
=======================================
Files 42 42
Lines 2283 2283
Branches 284 284
=======================================
Hits 2025 2025
Misses 254 254
Partials 4 4 |
dependabot
bot
force-pushed
the
dependabot/nuget/src/shell/dotnet/Shell/Microsoft.Web.WebView2-1.0.2365.46
branch
8 times, most recently
from
bc5610f
to
d9471d1
Compare
|
@psmulovics @ztanczos Does this require any desktop installation or can this be merged? |
|
Had same question to @ztanczos today morning. Each version of the WV2 nuget has a range of versions of the runtime it can work with. If we take granted companies do keep up with the security updates around Microsoft Office, it would mean they have an up to date version of the runtime too. So we can draw a line in the sand, like 10 weeks, if the minimum of a WebView2 nuget's matching runtime version is older than 10 weeks, we should merge. |
|
For this particular version of nuget, the minimum Edge version is 122, which was released on 2/23/2024, which seems to me a little too new to pick up. Based on the 10 week line, if we agree on that, we should pick up version 2210 from late December probably. |
|
While manual testing the shell I faced no issues with the rendering of the web applications. |
Bumps Microsoft.Web.WebView2 from 1.0.2045.28 to 1.0.2365.46. --- updated-dependencies: - dependency-name: Microsoft.Web.WebView2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/nuget/src/shell/dotnet/Shell/Microsoft.Web.WebView2-1.0.2365.46
branch
from
d9471d1
to
1e91d6d
Compare
|
@dependabot ignore this minor version |
|
OK, I won't notify you about version 1.0.x again, unless you re-open this PR. |
dependabot
bot
deleted the
dependabot/nuget/src/shell/dotnet/Shell/Microsoft.Web.WebView2-1.0.2365.46
branch
|
As discussed, we would pick a particular schedule to be slightly behind of our release schedule, so @kruplm , could you please submit a PR with the same content but for version 2210? |
Bumps Microsoft.Web.WebView2 from 1.0.2045.28 to 1.0.2365.46.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)