Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm-provenance) - Update to Node.js 20 and add npm package provenance #566

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Mar 22, 2024

Add npm package provenance, modified package.json files to contain repository and publish information.
Based on the documentation: https://docs.npmjs.com/generating-provenance-statements#using-third-party-package-publishing-tools using 3rd party libraries (Lerna) to publish we should define EITHER an environment variable (NPM_CONFIG_PROVENANCE) OR add publish configs to the package.json files OR add a .npmrc file where we can set the provenance to true.

Based on the release https://github.com/lerna/lerna/releases/tag/6.6.2 : Lerna does support provenance from the 6.6.2 version. We are on the 8.1.2.

FYI: lerna/lerna#3657 ;

I added package.json reporitory and publishConfigs and environment variable as well to be sure that the provenance flag is set.

…nance, modified package.json files to contain repository and publish information
@lilla28 lilla28 requested a review from a team as a code owner March 22, 2024 13:31
src/fdc3/js/composeui-fdc3/package.json Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (f2a349f) to head (6b8f298).
Report is 1 commits behind head on main.

❗ Current head 6b8f298 differs from pull request most recent head b63ca04. Consider uploading reports for the commit b63ca04 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          45       45           
  Lines        2359     2359           
  Branches      299      239   -60     
=======================================
  Hits         2126     2126           
- Misses        229      232    +3     
+ Partials        4        1    -3     

see 3 files with indirect coverage changes

@psmulovics psmulovics merged commit c9428b9 into morganstanley:main Mar 22, 2024
3 checks passed
kruplm added a commit that referenced this pull request Apr 10, 2024
…nance (#566)

* feat(npm-provenance) - Update to Node.js 20 and add npm package provenance, modified package.json files to contain repository and publish information

* fix(package.json) - Typos, restricted access in publishConfig

---------

Co-authored-by: kruplm <[email protected]>
@lilla28 lilla28 deleted the npm/provenance branch May 15, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants