-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(npm-provenance) - Update to Node.js 20 and add npm package provenance #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nance, modified package.json files to contain repository and publish information
psmulovics
reviewed
Mar 22, 2024
kruplm
requested changes
Mar 22, 2024
kruplm
requested changes
Mar 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 45 45
Lines 2359 2359
Branches 299 239 -60
=======================================
Hits 2126 2126
- Misses 229 232 +3
+ Partials 4 1 -3 |
kruplm
approved these changes
Mar 22, 2024
bingenito
approved these changes
Mar 22, 2024
kruplm
added a commit
that referenced
this pull request
Apr 10, 2024
…nance (#566) * feat(npm-provenance) - Update to Node.js 20 and add npm package provenance, modified package.json files to contain repository and publish information * fix(package.json) - Typos, restricted access in publishConfig --------- Co-authored-by: kruplm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add npm package provenance, modified package.json files to contain repository and publish information.
Based on the documentation: https://docs.npmjs.com/generating-provenance-statements#using-third-party-package-publishing-tools using 3rd party libraries (Lerna) to publish we should define EITHER an environment variable (NPM_CONFIG_PROVENANCE) OR add publish configs to the package.json files OR add a .npmrc file where we can set the provenance to true.
Based on the release https://github.com/lerna/lerna/releases/tag/6.6.2 : Lerna does support provenance from the 6.6.2 version. We are on the 8.1.2.
FYI: lerna/lerna#3657 ;
I added package.json reporitory and publishConfigs and environment variable as well to be sure that the provenance flag is set.