[Certora] Verif math is safe #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2024
|
I don't like the naming, feel free to throw in your suggestions. |
QGarchery
reviewed
Nov 4, 2024
QGarchery
requested changes
Nov 5, 2024
QGarchery
previously approved these changes
Nov 13, 2024
QGarchery
previously approved these changes
Nov 13, 2024
MathisGD
previously approved these changes
Nov 13, 2024
colin-morpho
dismissed stale reviews from MathisGD and QGarchery
via
27364f0
QGarchery
approved these changes
Nov 13, 2024
MathisGD
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that mathematical operations are safe.
Some operation could be a source for underflows, as well some expressions are rewritten for convenience.
This PR ensures that the rewritten operations are equivalent and that underflows are not possible.
Before accepting this PR make sure that:
Closes #81 .