Skip to content

Commit

Permalink
Coverity scan: Uninitialized scalar variable
Browse files Browse the repository at this point in the history
* CID 350633
* CID 512344
* CID 514343
  • Loading branch information
wwmayer authored and chennes committed Nov 13, 2024
1 parent 4bc8cd6 commit ee1af27
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Mod/Assembly/Gui/ViewProviderAssembly.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,16 @@ struct MovingObject
std::string& s)

Check warning on line 60 in src/Mod/Assembly/Gui/ViewProviderAssembly.h

View workflow job for this annotation

GitHub Actions / Lint / Lint

parameter name 's' is too short, expected at least 2 characters [readability-identifier-length]
: obj(o)
, plc(p)
, ref(nullptr)
, rootObj(ro)
, sub(s)
{}

// Default constructor
MovingObject()
: obj(nullptr)
, plc(Base::Placement())
, ref(nullptr)
, rootObj(nullptr)
, sub("")
{}

~MovingObject()

Check warning on line 75 in src/Mod/Assembly/Gui/ViewProviderAssembly.h

View workflow job for this annotation

GitHub Actions / Lint / Lint

use '= default' to define a trivial destructor [modernize-use-equals-default]
Expand Down
1 change: 1 addition & 0 deletions src/Mod/CAM/libarea/Adaptive.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2781,6 +2781,7 @@ void Adaptive2d::ProcessPolyNode(Paths boundPaths, Paths toolBoundPaths)
// double(entryPoint.Y)/scaleFactor << endl;

AdaptiveOutput output;
output.ReturnMotionType = 0;
output.HelixCenterPoint.first = double(entryPoint.X) / scaleFactor;
output.HelixCenterPoint.second = double(entryPoint.Y) / scaleFactor;

Expand Down
1 change: 1 addition & 0 deletions src/Mod/Sketcher/Gui/TaskSketcherConstraints.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,7 @@ FilterValueBitset ConstraintFilterList::getMultiFilter()

TaskSketcherConstraints::TaskSketcherConstraints(ViewProviderSketch* sketchView)
: TaskBox(Gui::BitmapFactory().pixmap("Sketcher_CreateLineAngleLength"), tr("Constraints"), true, nullptr)
, specialFilterMode{SpecialFilterType::None}
, sketchView(sketchView)
, inEditMode(false)
, ui(new Ui_TaskSketcherConstraints)
Expand Down

0 comments on commit ee1af27

Please sign in to comment.