Patch 20 #5
Closed
Patch 20 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_Specific_Child [Arch] [Draft] Add guard for RootNode specific child
Improves compatibility when using the legacy editor. Corrects a number of issues that prevented saved files from being displayed when using the legacy editor. Reduces the verbosity of console messages.
fix position of #endif for MEFISTO removal
Fixes FreeCAD#11873 this was the primary goal of these changes Fixes (partially) FreeCAD#11874 the parts of a polyline are combined as a compound object (shape) but it would be preferable for them to be made into a wire (if possible) Fixes FreeCAD#11872 Objects in a block definition are now kept separately until the block is inserted, in which case the inserted objects are subject to all the other options regarding combining. Fixes (partially, review required) FreeCAD#11871 Text and dimensions are now kept as part of the block definition and are placed in the drawing when the block is inserted but this code has not been extensively tested. Affects FreeCAD#11875, custom types are not made, but the labels now reflect the object types rather than all being "Shapennn" This leaves the importer options handling in a bit of a mess that needs cleanup eventually, but this can be a new issue. This includes some importer flags that have no corresponding options (e.g. import frozen layers), some flags not yet implemented, some flags not yet even declared in the code because their implementation is further off (import hatch outlines), and some suggested future options (import SOLIDs as faces) Centralize the calculation of the OCS for entities as they're read from the DXF. Most of the entities don't use this yet, but some of them roll their own crude Normal Vector handling. Because the new code takes priority over the old for reading the normal vector, such code will always see (0, 0, 1) as the extrusion direction.
The relative checkbox was hidden by mistake.
* Added test for MapperMaker::modified Signed-off-by: CalligaroV <[email protected]>
Toponaming: Transfer in makeElementRefine
* Added test for MapperMaker::generated * Renamed spit into splitMkr in the test for MapperMaker::modified * Disabled test for TopoShape::makeElementWires Signed-off-by: CalligaroV <[email protected]>
…ponamingTopoShapeWire # Conflicts: # src/Mod/Part/App/TopoShape.h # src/Mod/Part/App/TopoShapeExpansion.cpp
* Renamed enum classes members to lowercaseCapword * Moved struct ShapeHasher back to TopoShapeMapper.h * Added test for MapperMaker::generated * Modifications for clang-tidy warnings * Formatting Signed-off-by: CalligaroV <[email protected]>
These are intended to use when calculating normal simply with points could be numerically expensive or otherwise nonviable.
As opposed to "punctual" that already exists for curves.
For use in angle-via-point with complex curves.
The following commits were squashed into this [Sketcher] Handle some corner cases in AngleViaPoint [Sketcher] Avoid redundant constraints with B-splines... When involving tangent, perpendicular and angle constraints. [Sketcher] Add pre-commit changes [Sketcher] Do not allow 2-selection tangent with B-spline Also... [Sketcher] Report error when using direct tangency with B-splines [Sketcher] Fix malformed constraint when B-spline is selected second To clarify, this means the second curve selected. The position of the point in selection order does not matter in angle-via-point. [Sketcher] Fix wrong number for B-Spline tangent on redundancy [Sketcher] Remove existing point-on-object in some redundant cases Particularly when point constrained on a B-spline is being used for tangent, perpendicular or angle via point with the same B-spline. [Sketcher] Fix direction issue with B-spline tangents. Without these changes the solver might try to "twist" the B-spline to make the angle between curves be 0 instead of PI (which may be closer to the initial shape).
If needed this can be moved to a gtest,
Needed for gtests currently.
...for use in tests.
…PartBoolean Toponaming: transfer in FeaturePartBoolean
…tangency-splines [Sketcher] General Tangency with B-splines (re-do)
Finds the bounding sphere when the editing view provider is set. This ensures the right bounding sphere is used for finding the near and far clipping plane
…e-to-context-menu [Sketcher] add translate and scale commands to context menu
Based on the modifications to InputStream from the LinkStage3 fork. Needed for correct restoration of StringHasher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.