MOSIP-23551: Added validators for DocType and DocCat code in valid document entity #937
Conversation
…cument entity Signed-off-by: Balaji <[email protected]>
balaji-alluru
force-pushed
the
patchb-1
branch
from
406b166 to
71db745
Compare
| @AttributeOverride(name = "docCategoryCode", column = @Column(name = "doccat_code", nullable = false, length = 36)) }) | ||
|
|
||
| @Column(name = "doctyp_code", nullable = false, length = 36) | ||
| @DocTypeCode(message = "docType is Invalid") |
There was a problem hiding this comment.
It is always better to set error_code in the message instead of message directly.
| private String docTypeCode; | ||
|
|
||
| @Id | ||
| @Column(name = "doccat_code", nullable = false, length = 36) | ||
| @DocCatCode(message = "docCategory is Invalid") |
There was a problem hiding this comment.
It is always better to set error_code in the message instead of message directly.
| @Retention(RetentionPolicy.RUNTIME) | ||
| public @interface DocCatCode { | ||
|
|
||
| String message() default "docCategory is Invalid"; |
There was a problem hiding this comment.
It is always better to set error_code in the message instead of message directly.
|
|
||
| public class DocCatCodeValidator implements ConstraintValidator<DocCatCode, String> { | ||
|
|
||
| private List<String> docCatCode; |
There was a problem hiding this comment.
Its a list then why is the variable name singular?
| } | ||
|
|
||
| if(null != value && !value.isEmpty()) { | ||
| return docCatCode.contains(value); |
There was a problem hiding this comment.
What happens when a new document category is added? how and when the docCatCode list is refreshed?
| @Retention(RetentionPolicy.RUNTIME) | ||
| public @interface DocTypeCode { | ||
|
|
||
| String message() default "docType is Invalid"; |
There was a problem hiding this comment.
It is always better to set error_code in the message instead of message directly.
|
|
||
| public class DocTypeCodeValidator implements ConstraintValidator<DocTypeCode, String> { | ||
|
|
||
| private List<String> docTypeCode; |
There was a problem hiding this comment.
Its a list then why is the variable name singular?
| } | ||
|
|
||
| if(null != value && !value.isEmpty()) { | ||
| return docTypeCode.contains(value); |
There was a problem hiding this comment.
What happens when a new document category is added? how and when the docCatCode list is refreshed?
| @@ -113,7 +113,7 @@ public void setUp() throws Exception { | |||
| @Test | |||
| @WithUserDetails(value = "zonal-admin") | |||
| public void t002lostRidTest() throws Exception { | |||
There was a problem hiding this comment.
Let's rename the test method name based on the agreed convention
methodNameUnderTest_scenarioName_ Result
…