Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INJIMOB-2471] remove id field from mock VCs #86

Merged
merged 5 commits into from
Dec 16, 2024
Merged

[INJIMOB-2471] remove id field from mock VCs #86

merged 5 commits into from
Dec 16, 2024

Conversation

KiruthikaJeyashankar
Copy link

@KiruthikaJeyashankar KiruthikaJeyashankar commented Dec 16, 2024 •
edited
Loading

id field is removed from

  • ldp_vc format VCs as spec states that ID is an optional field
  • mso_mdoc format VCs as there is no explicit statement about id field in the VC content

Other changes include

@KiruthikaJeyashankar
[INJIMOB-2471] modify MdocGenerator kotlin to Java class
1d2d8db 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2471] modify CBORConvertor kotlin to Java class
7f3a0b1 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2471] remove id field from mock VCs
ad20adc 
id field is removed from both ldp_vc and mso_mdoc format VCs. For ldp_vcs id field is marked as optional

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2471] update version of mock-certify-plugin to 0.3.1-SNAPSHOT
98e4bd2 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2471] rm unused kotlin dependencies
19b5851 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@vishwa-vyom vishwa-vyom merged commit 3a6d62f into mosip:develop Dec 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwa-vyom vishwa-vyom vishwa-vyom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KiruthikaJeyashankar @vishwa-vyom