Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INJICERT-695] add Mock mdoc VCI plugin #89

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

KiruthikaJeyashankar
Copy link

@KiruthikaJeyashankar KiruthikaJeyashankar commented Dec 17, 2024

Add support for Mobile Driving license by MockMdocVCIPlugin

  • mosip.certify.mock.vciplugin.issuer.key-cert - This will holding the details of document signer (DS) certificate in the form -> "$base64EncodedPrivateKey||$base64EncodedCertificate"
  • As of now, only issuer certificate (DS) is available and its used to sign the mdoc. But as per spec, DS certificate is signed by the issuing authority’s root CA certificate basically IA creates a certificate chain keeping the
    • root = root CA certificate
    • leaf = DS certificate
      And only the DS certificate is attached to the credential.Root certificate is not available as of now and is a limitation.

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar KiruthikaJeyashankar changed the title [INJICERT-xxx] add Mock mdoc VCI plugin [INJICERT-695] add Mock mdoc VCI plugin Dec 17, 2024
mosip.certify.mock.vciplugin.issuer.key-cert changed to mosip.certify.mock.vciplugin.mdoc.issuer-key-cert

Signed-off-by: KiruthikaJeyashankar <[email protected]>
Signed-off-by: KiruthikaJeyashankar <[email protected]>
Copy link
Member

@vishwa-vyom vishwa-vyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is just a mock implementation with limitations, I have reviewed only at high level

@vishwa-vyom
Copy link
Member

Since the failure is not releated to the current changed and it is fixed by @Piyush7034, currently merging this.

@vishwa-vyom vishwa-vyom merged commit 3a51e4e into mosip:release-0.3.x Dec 18, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants