[MOSIP-37815] Passing the Value with Namespace

Signed-off-by: VSIVAKALYAN <[email protected]>
mosip · Nov 27, 2024 · e8f54b5 · e8f54b5
1 parent 03a6969
commit e8f54b5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/deploy/signup-service/install.sh b/deploy/signup-service/install.sh
@@ -98,12 +98,12 @@ function installing_signup() {
     fi
   done
 
-read -p "Enter KAFKA_CONSUMER_GROUP_ID: " kafkaConsumerGroupId
+echo Installing signup with KAFKA_CONSUMER_GROUP_ID="mock-signup-idv-kafka-$NS"
 
   echo Installing signup
-  helm -n $NS install signup mosip/signup \
+  helm -n $NS install signup /home/siva/Videos/DSD_recordings/DSD6684/esignet-signup/helm/signup-service \
     -f values.yaml --version $CHART_VERSION $ENABLE_INSECURE $plugin_option \
-    --set kafkaConsumerGroupId="$kafkaConsumerGroupId" \
+    --set kafkaConsumerGroupId="mock-signup-idv-kafka-$NS" \
     --set metrics.serviceMonitor.enabled=$servicemonitorflag --wait
 
   kubectl -n $NS  get deploy -o name |  xargs -n1 -t  kubectl -n $NS rollout status

diff --git a/helm/signup-service/templates/deployment.yaml b/helm/signup-service/templates/deployment.yaml
@@ -92,6 +92,8 @@ spec:
           env:
             - name: container_user
               value: {{ .Values.containerSecurityContext.runAsUser }}
+            - name: KAFKA_CONSUMER_GROUP_ID
+              value: mock-signup-idv-kafka-{{ .Release.Namespace }}" # Using the namespace dynamically
             - name: JDK_JAVA_OPTIONS
               value: {{ .Values.additionalResources.javaOpts }}
             {{- if .Values.pluginUrlEnv }}

diff --git a/helm/signup-service/values.yaml b/helm/signup-service/values.yaml
@@ -241,12 +241,7 @@ updateStrategy:
 ##     value: "bar"
 ##
 
-# Other configurations...
-kafkaConsumerGroupId: ""  # Placeholder for user input
-
 extraEnvVars: |
-  - name: KAFKA_CONSUMER_GROUP_ID
-    value: {{ .Values.kafkaConsumerGroupId | quote }}
   - name: MOSIP_ESIGNET_HOST
     valueFrom:
       configMapKeyRef: